From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAB26C433F5 for ; Fri, 27 May 2022 09:27:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350546AbiE0J1b (ORCPT ); Fri, 27 May 2022 05:27:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240813AbiE0J11 (ORCPT ); Fri, 27 May 2022 05:27:27 -0400 Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F20AC63C4; Fri, 27 May 2022 02:27:24 -0700 (PDT) Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 27 May 2022 18:27:23 +0900 Received: from mail.mfilter.local (m-filter-2 [10.213.24.62]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 38E212058456; Fri, 27 May 2022 18:27:23 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 27 May 2022 18:27:23 +0900 Received: from [10.212.245.54] (unknown [10.212.245.54]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 98E1DB62E2; Fri, 27 May 2022 18:27:22 +0900 (JST) Subject: Re: [PATCH] dt-bindings: PCI: socionext,uniphier-pcie: Add missing child interrupt controller To: Rob Herring Cc: Bjorn Helgaas , Krzysztof Kozlowski , Masami Hiramatsu , PCI , devicetree@vger.kernel.org, linux-arm-kernel , linux-kernel@vger.kernel.org References: <20220525210117.2489333-1-robh@kernel.org> <35c700f6-ce67-89d5-0f29-426acd33efa9@socionext.com> From: Kunihiko Hayashi Message-ID: <82815ff7-08ad-5f31-a249-448f990863e5@socionext.com> Date: Fri, 27 May 2022 18:27:22 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/05/26 21:46, Rob Herring wrote: > On Thu, May 26, 2022 at 4:02 AM Kunihiko Hayashi > wrote: >> >> Hi Rob, >> >> On 2022/05/26 6:01, Rob Herring wrote: >>> The Socionext interrupt controller internal to the the PCI block isn't >>> documented which causes warnings when unevaluatedProperties check is >>> also fixed. Add the 'interrupt-controller' child node and properties and >>> fixup the example so that interrupt properties can be parsed. >> >> Surely internal interrupt controller isn't described, and should be >> documented. >> And the child node name "legacy-interrupt-controller" also should be >> fixed. >> >> Reviewed-by: Kunihiko Hayashi > > Thanks. > >> >> BTW I can't reproduce such warnings with my environment. >> Can you show the command line to reproduce the warnings? > > "causes warnings when unevaluatedProperties check is also fixed" > > You won't. I have a fix in dtschema pending, but first all the > warnings that appear need to be fixed. I understand. I don't care abort the warning on the way to fix. Thank you, --- Best Regards Kunihiko Hayashi