From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4796334682 for ; Thu, 22 Jan 2026 09:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769075931; cv=none; b=R/b6TRo1PKL7Wzcz1c/UGilo4+Da18DKhtaj0j8qcjXBr64CqmnsRXEmbmMveUHLedWyTv3vFYG8uxxcutMqSbsNrceJ5xp0qd44Z7Al5FBaRmG2ZO3QXmwrE7jINgANycATUYto9oEAyr+YeMDq6zPjTy2CprZLTO4ctzJ5Z9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769075931; c=relaxed/simple; bh=TGZ0rNzf2/Bkr4tJ2ZKGZj3qqNf4EwfsNP+W4wHnDZE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aAUTQQmZovEOhY4NiO2FK30VGcH1FIRTZvq9+ShcfMrqmp+WC/9Xbd2Oyud04md2HmtNdDxs8MVPcZ9T5sKLpWntgwqEiEQshR+WOyiczo4DdPRIMJiQ+IJoX6sFkizp8G1mXJZODB/oD3EeazLt03IKG1buPhruwpq+OuBTDXw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hhKldijI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=qGdbKpY8; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hhKldijI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="qGdbKpY8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769075928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8bga0PmTXpqJChMQAWzNuOW8OkwpWAb0ZdUEZncBTc8=; b=hhKldijIQin703iUhO/q5HrslQSO+yiOqlAp00co3nf90qV2SwoRpJKzXEqeJ3LAI1h8v+ TDr999cmMGRse6HI7QVJm4y5bJ+oaaXfqkdYQ29d6HimHGSdFPxIdIk9IY4GD/EvS/CPC5 5Phjy25jrL7afTvFlM2ZKM6J/xqusQw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-138-d0EtX7tPNEKCqFjJzNjpiQ-1; Thu, 22 Jan 2026 04:58:47 -0500 X-MC-Unique: d0EtX7tPNEKCqFjJzNjpiQ-1 X-Mimecast-MFC-AGG-ID: d0EtX7tPNEKCqFjJzNjpiQ_1769075926 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-47edfdc6c1aso5770525e9.3 for ; Thu, 22 Jan 2026 01:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769075926; x=1769680726; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8bga0PmTXpqJChMQAWzNuOW8OkwpWAb0ZdUEZncBTc8=; b=qGdbKpY86MKLwsmG/6a26h80cYtgnZRjohUtNG49xKvnqDOCbugI1N4sXJ8ahH+NZU pYO0g/r5sftG4565WtJxzsg971M6dYd6YQ04u57ymnBmndxUhDKTtJxoaJprP4hH1VN7 lXdlLtENFA/eRCqf7tEWZqUAtAWxoqYirY2cwh5kMNrueIN+NeeI6SzwO+VlDIlneZXF FI6fOO1rIlrOl0HjSf9AStK22T9GD9kzKCyzHWzUDADufxB6mmELH1KkhGJNtWcbQ7oc rgk1vuvVgwtTU4TSctsbNgmh2gRnCGLBr/VsUo+2YVvsMIe86FGwsrfaPjB2lrr/q3fG bHTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769075926; x=1769680726; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8bga0PmTXpqJChMQAWzNuOW8OkwpWAb0ZdUEZncBTc8=; b=hBYzBOiaUChk300zoJkt8klPHAi4bhgrmPzBZ9VSlG8AGOS3iCAe0LQlzYJhP0xc1u uXPzCyZoYhvFzmjPhRTS1FWS6CXr5EhBpPlYEXH+zzSatOvV9nbpyCkpBTAb1XD0bgXs Mx1D7gRD+F692SznaBb995omZ4FFsD0+EojkQoxEBd8s+iHxvSCGfjKjB0LAbCY7bgYK asTQa7VAuoNMbGc+Ho3g9brc3ya2EO7Ml/1ujSqAP+1aRysov2rlMTZvkoJ8yna9D3yh mUG4kVIHj6KL0zBYQkcvBkV4+HEAEuXhkm1JkHu/j+HZC1cgWxGqSoFiFptJ5IuCwo5a vddg== X-Forwarded-Encrypted: i=1; AJvYcCVADyMfsizRETODZmZgaAqvVTV/6HHcOm+javF8z+DQfjUUMF6fnAEqDTPXrNBjDqBroFdnKC8/1d/6IZo=@vger.kernel.org X-Gm-Message-State: AOJu0YyqGForwMo0jrWKGjR9+B6MKsE9MMnyIMae6xw4SS97lBqPDJrf bzmXy7dATNfdzEUnd0Uc0g5ga/gACYe1di/9Yzjdrz5HUwt00VlUtrHHyK1vD3QsK3jtEENCPcv Fe1wa/6VTHL774/Rd/Uhgp0RZYI5ZE/G50CRiLwWK3LfWfYNioh1+EyVOuR9JL8ulKA== X-Gm-Gg: AZuq6aLq0D9f0X64gTzn/Fn6/fKo4cVXMgtyvOGB1NaUknG9StF7ReP2aJCBGPX0SyD HcbGUt7NIB6anxUrIp9Wr8OQF9uv5hGMzv5cUJpdAzmrcU/uwyxLTO+ArJNmGoLdfW4PThKwB0R IFuRxEh44/vO3KGKFiZmp+oVusZDzAZ0r0SXFbFC7W6BSPEbOQpcoYr9z2XeXWiHa05OlVBeT54 fK4dW/D2xajcLoHEcrTwhs3W5se31rmlouFVHMSSPBezTUHFpU2dxunXRlzeCzloTfcC0/rSFcL zDY5YyTk7eQJdIBrFhstlnX0FvEurVOIQQVvOotvhtK25dF4UA/PXzpQUyZChxyTwI5rFBQI6kv pKcOODs/MBQju X-Received: by 2002:a05:600c:3ba8:b0:47e:e48b:506d with SMTP id 5b1f17b1804b1-4801eac88fcmr326422925e9.16.1769075926020; Thu, 22 Jan 2026 01:58:46 -0800 (PST) X-Received: by 2002:a05:600c:3ba8:b0:47e:e48b:506d with SMTP id 5b1f17b1804b1-4801eac88fcmr326422735e9.16.1769075925628; Thu, 22 Jan 2026 01:58:45 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.175]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-480470474cbsm54975415e9.8.2026.01.22.01.58.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 01:58:45 -0800 (PST) Message-ID: <8285c951-7e24-404f-8c58-ad7766dc3620@redhat.com> Date: Thu, 22 Jan 2026 10:58:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v6 2/3] net: dsa: yt921x: Return early for failed MIB read To: Yangfl , Andrew Lunn Cc: netdev@vger.kernel.org, Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-kernel@vger.kernel.org References: <20260118013019.1078847-1-mmyangfl@gmail.com> <20260118013019.1078847-3-mmyangfl@gmail.com> <5afaff9c-7be2-4464-b675-4bf70aaa17af@lunn.ch> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1/18/26 8:24 PM, Yangfl wrote: > On Mon, Jan 19, 2026 at 12:06 AM Andrew Lunn wrote: >> >> On Sun, Jan 18, 2026 at 09:30:15AM +0800, David Yang wrote: >>> This patch does not change anything effectively, but serves as a >>> prerequisite for another patch. >>> >>> Signed-off-by: David Yang >>> --- >>> drivers/net/dsa/yt921x.c | 11 +++++++---- >>> 1 file changed, 7 insertions(+), 4 deletions(-) >>> >>> diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c >>> index 5e4e8093ba16..fe08385445d2 100644 >>> --- a/drivers/net/dsa/yt921x.c >>> +++ b/drivers/net/dsa/yt921x.c >>> @@ -707,6 +707,12 @@ static int yt921x_read_mib(struct yt921x_priv *priv, int port) >>> WRITE_ONCE(*valp, val); >>> } >>> >>> + if (res) { >>> + dev_err(dev, "Failed to %s port %d: %i\n", "read stats for", >>> + port, res); >>> + return res; >>> + } >> >> I know you are just moving code around, so i can understand a straight >> cut/paste. >> >> However, when i look at the code, what is the point of %s and the >> constant "read stats for"? >> >> Andrew > > The error format is used many times across the file, so using the same > string helps reduce the data size a bit. I think you could/should clean the implementation encapsulating the dev_err in an helper tacking the variable string as an argument. Since you have to repost, you could introduce a pre-req patch doing that. Thanks, Paolo