From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756037AbbE2Iyf (ORCPT ); Fri, 29 May 2015 04:54:35 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:59027 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755634AbbE2IxF (ORCPT ); Fri, 29 May 2015 04:53:05 -0400 From: Arnd Bergmann To: Tejun Heo Cc: Li Zefan , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] cgroup: add seq_file forward declaration for struct cftype Date: Fri, 29 May 2015 10:52:59 +0200 Message-ID: <8289624.GnpfIU6Era@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Lc1hwevokDXaSXHCE1Xds9W+e3STPlvgjKlXovpQnJx9FbHoRus ifp64LOOTGoU6L0u2KP1aAdelKKuNX5htRP1nSB80QJTvYCgYbt9WwBaHQrtQjIBe81v2+C 4jlo7k0+tOo0sMrQSUR2EFM/+BaIcyyNJ35hyzrbnhXTE7R7iO21sJAeYqjRSmSiDkS82n8 sH/+f9YMMX+sITBdkGbTQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Recent header file changes for cgroup caused lots of warnings about a missing struct seq_file form declaration for every inclusion of include/linux/cgroup-defs.h. As some files are built with -Werror, this leads to build failure like: from /git/arm-soc/drivers/gpu/drm/tilcdc/tilcdc_crtc.c:18: /git/arm-soc/include/linux/cgroup-defs.h:354:25: error: 'struct seq_file' declared inside parameter list [-Werror] cc1: all warnings being treated as errors make[6]: *** [drivers/gpu/drm/tilcdc/tilcdc_crtc.o] Error 1 This patch adds the declaration, which resolves both the warnings and the drm failure. Signed-off-by: Arnd Bergmann Fixes: b4a04ab7a37b ("cgroup: separate out include/linux/cgroup-defs.h") diff --git a/include/linux/cgroup-defs.h b/include/linux/cgroup-defs.h index 7d83d7f73420..ab9dd741ab99 100644 --- a/include/linux/cgroup-defs.h +++ b/include/linux/cgroup-defs.h @@ -302,6 +302,8 @@ struct cgroup_root { char name[MAX_CGROUP_ROOT_NAMELEN]; }; +struct seq_file; + /* * struct cftype: handler definitions for cgroup control files *