mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jasmin J." <jasmin@anw.at>
To: eddi1983 <eddi1983@gmx.net>, mchehab@kernel.org
Cc: gregkh@linuxfoundation.org, diaconitatamara@gmail.com,
	daniel.baluta@gmail.com, eraretuya@gmail.com,
	elise.lennion@gmail.com, linux-media@vger.kernel.org,
	0devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: media: cxd2099: Fix checkpatch issues
Date: Tue, 16 May 2017 22:47:48 +0200	[thread overview]
Message-ID: <82946e90-46a5-de5a-40db-adeaa4839976@anw.at> (raw)
In-Reply-To: <20170516200740.27692-1-eddi1983@gmx.net>

Hello Christoph!

The current cxd2099 driver is an old version. DD provides a newer variant.
Please see my patch series
   http://www.mail-archive.com/linux-media@vger.kernel.org/msg112410.html
Especially this patch
   http://www.mail-archive.com/linux-media@vger.kernel.org/msg112409.html
where I remove this useless printing already.

I kept the "slot_shutdown" print in my series, because it is useful and called
only if someone removes the CAM, but I removed all the other useless ones.

So I can agree with your first hunk.

It would be better to wait with this change after my series is approved!

BR,
    Jasmin

      reply	other threads:[~2017-05-16 20:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-16 20:07 eddi1983
2017-05-16 20:47 ` Jasmin J. [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82946e90-46a5-de5a-40db-adeaa4839976@anw.at \
    --to=jasmin@anw.at \
    --cc=0devel@driverdev.osuosl.org \
    --cc=daniel.baluta@gmail.com \
    --cc=diaconitatamara@gmail.com \
    --cc=eddi1983@gmx.net \
    --cc=elise.lennion@gmail.com \
    --cc=eraretuya@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®