From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5F15C43603 for ; Tue, 17 Dec 2019 12:54:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B127A2072D for ; Tue, 17 Dec 2019 12:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728134AbfLQMyo (ORCPT ); Tue, 17 Dec 2019 07:54:44 -0500 Received: from foss.arm.com ([217.140.110.172]:36234 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727310AbfLQMyo (ORCPT ); Tue, 17 Dec 2019 07:54:44 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D455731B; Tue, 17 Dec 2019 04:54:43 -0800 (PST) Received: from [192.168.0.9] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B3AFE3F719; Tue, 17 Dec 2019 04:54:41 -0800 (PST) Subject: Re: [Patch v6 5/7] sched/fair: update cpu_capacity to reflect thermal pressure To: Thara Gopinath , mingo@redhat.com, peterz@infradead.org, ionela.voinescu@arm.com, vincent.guittot@linaro.org, rui.zhang@intel.com, qperret@google.com, daniel.lezcano@linaro.org, viresh.kumar@linaro.org Cc: linux-kernel@vger.kernel.org, amit.kachhap@gmail.com, javi.merino@kernel.org, amit.kucheria@verdurent.com References: <1576123908-12105-1-git-send-email-thara.gopinath@linaro.org> <1576123908-12105-6-git-send-email-thara.gopinath@linaro.org> From: Dietmar Eggemann Message-ID: <829b67ec-d463-2ed5-749b-11fa9def26ad@arm.com> Date: Tue, 17 Dec 2019 13:54:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1576123908-12105-6-git-send-email-thara.gopinath@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/12/2019 05:11, Thara Gopinath wrote: > cpu_capacity relflects the maximum available capacity of a cpu. Thermal s/relflects/reflects [...] > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > index e12a375..4840655 100644 > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -7725,8 +7725,15 @@ static unsigned long scale_rt_capacity(struct sched_domain *sd, int cpu) > if (unlikely(irq >= max)) > return 1; > > + /* > + * avg_rt.util avg and avg_dl.util track binary signals > + * (running and not running) with weights 0 and 1024 respectively. What exactly is this weight here? I assume the 'unsigned long load' parameter of ___update_load_avg(). At least this would match its use in __update_load_avg_se(). [...]