From: Kumar Gala <galak@kernel.crashing.org>
To: Cody P Schafer <cody@linux.vnet.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org,
LKML <linux-kernel@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc/mm: eliminate unneeded for_each_memblock
Date: Mon, 7 Jan 2013 10:42:02 -0600 [thread overview]
Message-ID: <82A31E2D-FA24-44CF-9812-9E8062AFA6F4@kernel.crashing.org> (raw)
In-Reply-To: <1357322760-12197-1-git-send-email-cody@linux.vnet.ibm.com>
On Jan 4, 2013, at 12:06 PM, Cody P Schafer wrote:
> The only persistent change made by this loop is calling
> memblock_set_node() once for each memblock, which is not useful (and has
> no effect) as memblock_set_node() is not called with any
> memblock-specific parameters.
>
> Subsistute a single memblock_set_node().
> ---
> arch/powerpc/mm/mem.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
Missing a signed-off-by
- k
next prev parent reply other threads:[~2013-01-07 16:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 18:06 Cody P Schafer
2013-01-07 16:42 ` Kumar Gala [this message]
2013-01-09 22:40 ` [PATCH v2] " Cody P Schafer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82A31E2D-FA24-44CF-9812-9E8062AFA6F4@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=cody@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®