From: Luka Gejak <luka.gejak@linux.dev>
To: Mehmet Fide <mehmet.fide@gmail.com>, Ping-Ke Shih <pkshih@realtek.com>
Cc: Po-Hao Huang <phhuang@realtek.com>, Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
mehmet.fide@screeningeagle.com
Subject: Re: [PATCH rtw-next] wifi: rtw88: find an associated station without allocating
Date: Wed, 18 Nov 2026 14:10:10 +0100 [thread overview]
Message-ID: <82D0B44A-7B20-4564-A368-5C834ADC6F8D@linux.dev> (raw)
In-Reply-To: <20261118104738.2020747-1-mehmet.fide@gmail.com>
On November 18, 2026 11:47:38 AM GMT+01:00, Mehmet Fide
<mehmet.fide@gmail.com> wrote:
>From: Mehmet Fide <mehmet.fide@screeningeagle.com>
>
>rtw_core_check_sta_active() collects the interfaces with
>rtw_iterate_vifs(), which allocates an entry per interface with
>GFP_ATOMIC and skips the interface when that fails. A station skipped
>this way counts as not active: on BSS_CHANGED_BSSID and in
>rtw_ops_stop_ap() rtw_clear_op_chan() then drops the operating channel
>saved for it, and a later hardware scan no longer goes back to that
>channel between the channels it scans.
>
>Both callers hold the wiphy mutex. Walk the active interfaces with
>for_each_active_interface(), which does not allocate.
>
>Fixes: 96fbb84de4ff ("wifi: rtw88: handle station mode concurrent scan with AP mode")
>Reported-by: Luka Gejak <luka.gejak@linux.dev>
>Closes: https://lore.kernel.org/linux-wireless/9BC4FC13-5723-4711-9798-11E3C285C7F1@linux.dev/
>Suggested-by: Ping-Ke Shih <pkshih@realtek.com>
>Signed-off-by: Mehmet Fide <mehmet.fide@screeningeagle.com>
>---
>
Looks good to me,
Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
Best regards,
Luka Gejak
prev parent reply other threads:[~2026-11-18 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 10:47 Mehmet Fide
2026-11-18 13:10 ` Luka Gejak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82D0B44A-7B20-4564-A368-5C834ADC6F8D@linux.dev \
--to=luka.gejak@linux.dev \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mehmet.fide@gmail.com \
--cc=mehmet.fide@screeningeagle.com \
--cc=phhuang@realtek.com \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®