mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: linux-bluetooth@vger.kernel.org,
	"Linux Kernel" <linux-kernel@vger.kernel.org>,
	"David Miller" <davem@davemloft.net>
Subject: Re: hci reset on init
Date: Mon, 3 Mar 2008 11:56:09 +0100	[thread overview]
Message-ID: <82FF3AE0-C5AB-4CDB-B065-EF6025FA2608@holtmann.org> (raw)
In-Reply-To: <a8e1da0803021741x7c8fc880g9259196adb062fd9@mail.gmail.com>

Hi Dave,

> Recently, I find my usb bluetooth dongle doesn't work after reboot  
> or resume.
>
> Kernel report (with bluetooth mouse active):
>
> Feb 15 16:54:32 darkstar kernel: hci_acldata_packet: hci0 ACL packet  
> for unknown
> connection handle 43
> Feb 15 16:54:34 darkstar last message repeated 124 times
>
> I fixed it by adding HCI_RESET to CSR usb id:
>        { USB_DEVICE(0x0a12, 0x0001), .driver_info = HCI_CSR | 
> HCI_RESET},
>
> Maybe you have known that there's other reports about this on
> bluetooth list as well.
>
> Most of the ids in hci_usb.c have the HCI_RESET option set.  Does we
> need to do this automaticly?  I want to know whether sending reset
> request on init in hci_core.c is better, or at least the btusb driver
> need these porting.
>
> What's your opinion?

this is a clear NAK since you gonna break all old CSR based dongles.  
Within the Bluetooth 1.0b and 1.1 specification there was an issues  
with if HCI_Reset should only reset the Bluetooth internals or also  
the transport. So issuing HCI_Reset on an old dongle will cause an USB  
reset.

The solution is to find the build id when CSR produced correct  
firmware and set the HCI_RESET quirk based on that. I meant to do this  
for a long time, but so far never got around to inquiry the correct  
build id where this got fixed.

Regards

Marcel


      reply	other threads:[~2008-03-03 10:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03  1:41 Dave Young
2008-03-03 10:56 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82FF3AE0-C5AB-4CDB-B065-EF6025FA2608@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=davem@davemloft.net \
    --cc=hidave.darkstar@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®