From: Frank Rowand <frowand.list@gmail.com>
To: "Stephen Rothwell" <sfr@canb.auug.org.au>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Jacob Keller <jacob.e.keller@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] Documentation/process: hardcoded core.abbrev considered harmful!
Date: Wed, 30 Jan 2019 15:36:49 -0800 [thread overview]
Message-ID: <82a0b13b-edfc-46cc-ac7c-005f973009c4@gmail.com> (raw)
In-Reply-To: <20190130111846.0a6b8e2c@canb.auug.org.au>
On 1/29/19 4:18 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Thu, 20 Dec 2018 01:01:12 +0100 Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
>>
>> Stop recommending that core.abbrev=12 be hardcoded when referring to
>> kernel commits, and instead rely on the git's default abbreviation.
>>
>> Hardcoding this at "12" was done in
>> 8401aa1f5997 ("Documentation/SubmittingPatches: describe the Fixes:
>> tag", 2014-06-06), back then Linus's git/git@e6c587c733 ("abbrev: auto
>> size the default abbreviation", 2016-09-30) had not yet landed, and
>> the default abbreviation was "7".
>>
>> At the time linux.git had around 3.5 million objects, so if the auto
>> sizing had been in effect "11" would have been picked. Now "12" is
>> what we pick by default anyway.
>>
>> More importantly, we'll roll over to "13" at around 16 million
>> objects, which given the growth rate isn't that far off. At that point
>> this documentation will be worse than the default.
>>
>> Let's just stop doing this. Git versions as of 2.11 released over 2
>> years ago use the auto-sizing, and it seems like a fair assumption
>> that kernel developers use a fairly recent git version.
That might not be a fair assumption. The two systems that I submit
patches from have git versions older than 2.11.
-Frank
>>
>> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
>
> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> Since I have been checking Fixes: tags, it has become obvious that some
> kernel developers have core.abbrev set to 7, 9 or 10 (or maybe they are
> running very old versions of git). Hopefully this will encourage them
> to remove that setting (and upgrade).
>
> Can someone (Jon?) please apply this patch?
>
prev parent reply other threads:[~2019-01-30 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 9:25 [PATCH] doc: update SubmittingPatches about the Fixes tag Jeff Kirsher
2018-12-20 0:01 ` [PATCH] Documentation/process: hardcoded core.abbrev considered harmful! Ævar Arnfjörð Bjarmason
2019-01-15 19:41 ` Joe Perches
2019-01-15 19:44 ` Keller, Jacob E
2019-01-30 0:18 ` Stephen Rothwell
2019-01-30 23:36 ` Frank Rowand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82a0b13b-edfc-46cc-ac7c-005f973009c4@gmail.com \
--to=frowand.list@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=avarab@gmail.com \
--cc=corbet@lwn.net \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome