From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 746D030504A for ; Mon, 3 Nov 2025 13:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178271; cv=none; b=Nec+nTxzN8FeDaPKtgEuiC7cAsbHUPVC9KgOjY+xdzZi/BVFXzAW4La4rO3R4bQ34QBJx2LwaVUUTE23AGuVio+f7g1CjZY50+vYYiCDT2Z86B0bSRIkw2G8lkqzD1sJtEc9xUJbFRMnl8R1YYcj2mARUumRNX7we7GiJghTOY0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762178271; c=relaxed/simple; bh=oqfFJNXZLEsYjH9PTXpTyYjWvDmTRpxQNsIZRJK9uKE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u9gnwtpLzCiv6UozU4aI+XvlHoKkJCah1YXRjQV1UgRobgZfJJnv+xKjfk4GxEFvVXM+LsKsc/fCiDRZV1DIj6uQHiXI/VdaQhTqbjL82bjEYFjwXEeM0U3rjTLAyFLLjz/N6KfN0v7r9ZkLkzTqMZHIDRtnXDDXfDfol4o4Lxk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mAgK7BQU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UZ4ie+Yx; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mAgK7BQU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=UZ4ie+Yx; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mAgK7BQU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UZ4ie+Yx"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mAgK7BQU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="UZ4ie+Yx" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9E8C521C2D; Mon, 3 Nov 2025 13:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762178267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIjV9U0NNgfYzKLHl2MuM8jO1y2K8JQroe0WUEJLL+U=; b=mAgK7BQU8kGeI6byxBNZi+DPhCczwCIwhKevkET5Vy+HcBpCnV1KUd38wUsR5JpFkQV2p3 d5tYkGlJ51fhu5TbIYU9MOJy4fXj8M4rU7dpTU1xKPHPpUmzy8dR3K+xneYIOzKzlUsKwo Pi+nNtj6eD0rWeoUyp6OW87g/jO1mDU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762178267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIjV9U0NNgfYzKLHl2MuM8jO1y2K8JQroe0WUEJLL+U=; b=UZ4ie+YxwPKQ4s0PtG64bvTHVKgTouLZxLrX7scmno8B/tZ2dQmcVdoBuO8P/+NVCDEIbn oEfwxw8HsA/UUwBg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1762178267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIjV9U0NNgfYzKLHl2MuM8jO1y2K8JQroe0WUEJLL+U=; b=mAgK7BQU8kGeI6byxBNZi+DPhCczwCIwhKevkET5Vy+HcBpCnV1KUd38wUsR5JpFkQV2p3 d5tYkGlJ51fhu5TbIYU9MOJy4fXj8M4rU7dpTU1xKPHPpUmzy8dR3K+xneYIOzKzlUsKwo Pi+nNtj6eD0rWeoUyp6OW87g/jO1mDU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1762178267; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PIjV9U0NNgfYzKLHl2MuM8jO1y2K8JQroe0WUEJLL+U=; b=UZ4ie+YxwPKQ4s0PtG64bvTHVKgTouLZxLrX7scmno8B/tZ2dQmcVdoBuO8P/+NVCDEIbn oEfwxw8HsA/UUwBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 621281364F; Mon, 3 Nov 2025 13:57:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id NtV9F9u0CGlVOAAAD6G6ig (envelope-from ); Mon, 03 Nov 2025 13:57:47 +0000 Message-ID: <82a1b667-428f-4bc5-8326-63f9e729c460@suse.de> Date: Mon, 3 Nov 2025 14:57:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmet-auth: update sc_c in target host hash calculation To: Alistair Francis Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Alistair Francis References: <20251029045327.2035337-1-alistair.francis@wdc.com> <9b8d8baf-022a-49a9-b8b9-db699125e064@suse.de> <72c291ff-8295-4bef-b368-68c24aa983ec@suse.de> Content-Language: en-US From: Hannes Reinecke In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,wdc.com:email,imap1.dmz-prg2.suse.org:helo] X-Spam-Flag: NO X-Spam-Score: -4.30 X-Spam-Level: On 11/3/25 03:28, Alistair Francis wrote: > On Wed, Oct 29, 2025 at 9:33 PM Hannes Reinecke wrote: >> >> On 10/29/25 12:20, Alistair Francis wrote: >>> On Wed, Oct 29, 2025 at 6:10 PM Hannes Reinecke wrote: >>>> >>>> On 10/29/25 05:53, alistair23@gmail.com wrote: >>>>> From: Alistair Francis >>>>> >>>>> Commit 7e091add9c43 "nvme-auth: update sc_c in host response" added >>>>> the sc_c variable to the dhchap queue context structure which is >>>>> appropriately set during negotiate and then used in the host response. >>>>> >>>>> This breaks secure concat connections with a Linux target as the target >>>>> code wasn't updated at the same time. This patch fixes this by adding a >>>>> new sc_c variable to the host hash calculations. >>>>> >>>>> Signed-off-by: Alistair Francis >>>>> --- >>>>> drivers/nvme/host/auth.c | 1 + >>>>> drivers/nvme/target/auth.c | 3 ++- >>>>> drivers/nvme/target/fabrics-cmd-auth.c | 1 + >>>>> drivers/nvme/target/nvmet.h | 1 + >>>>> 4 files changed, 5 insertions(+), 1 deletion(-) >>>>> >>>> I've already send a similar patch for this, which actually should >>>> already have been merged. >>>> Can you check if that works for you? >>> >>> I checked master when I sent this and there was nothing applied. Is it >>> in a different tree? >>> >> >> https://lore.kernel.org/linux-nvme/aPl4-6WQ940kUso7@kbusch-mbp/T/#t > > Thanks. > > Your patch is now in master, but doesn't fix the issue for me. I still > get failures with a secure concat connection. > > My patch (rebased on top of yours) fixes the issue for me > Ah. So please add a proper 'Fixes' tag. (and fixup the kbuild failure while at it ...) Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich