mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: "Ioana Risteiu" <Ioana.Risteiu@analog.com>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Michael Hennerich" <Michael.Hennerich@analog.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Ramona Nechita" <ramona.nechita@analog.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 0/4] Add IIO backend support for AD7779
Date: Tue, 26 Aug 2025 11:24:26 -0500	[thread overview]
Message-ID: <82a21a66-409f-4ec8-9351-365031b8646b@baylibre.com> (raw)
In-Reply-To: <20250825221355.6214-1-Ioana.Risteiu@analog.com>

On 8/25/25 5:13 PM, Ioana Risteiu wrote:
>   - Add axi_adc_num_lanes_set in the adi_axi_adc_ops structure to support
>   setting number of lanes used by AXI ADC.
>   - Add the generic io-backends property to the AD7779 binding to enable
>   support for the IIO backend framework.
>   - Add the adi,num-lanes property to set the number of lanes used by
>   AD7779.
>   - Move the initialization specific to communication without iio-backend
>   into a separate setup function.
>   - Add a new functionality to ad7779 driver that streams data through data
>   output interface using IIO backend interface.

It is more helpful for the cover letter to contain a high-level
overview of why you want this series included in the kernel. We
can look at the individual patches to see what they are about, so
repeating that here isn't especially helpful.

For example, I would write the cover letter for this series like this:

The AD7779 ADC chip has a secondary data bus for high-speed data
transfers. To make use of this bus, it is connected to an FPGA IP
core [1] which is handled using the IIO backend framework. This IP
core connects to the data bus lines as well as the data ready signal
on the ADC. This interface can use 1, 2 or 4 lanes at a time.

This series extends the devicetree bindings to describe these wiring
configuration, extends the IIO backend framework to allow setting the
number of lanes that are being used, and extends the ad7779 driver to
allow using such a backend for reading data in buffered reads.

[1]: https://analogdevicesinc.github.io/hdl/projects/ad777x_fmcz/index.html

> 
> Ioana Risteiu (4):
>   iio: adc: adi-axi-adc: add axi_adc_num_lanes_set
>   dt-bindings: iio: adc: add IIO backend support
>   iio: adc: extract setup function without backend
>   iio: adc: update ad7779 to use IIO backend
> 
>  .../bindings/iio/adc/adi,ad7779.yaml          |  44 +++-
>  drivers/iio/adc/ad7779.c                      | 192 ++++++++++++++----
>  drivers/iio/adc/adi-axi-adc.c                 |   1 +
>  3 files changed, 196 insertions(+), 41 deletions(-)
> 

Please include a changelog of what was changed in each revision of
the series along with links to the previous revisions. Tools like
b4 can help automate this.

https://docs.kernel.org/6.16/process/submitting-patches.html

  parent reply	other threads:[~2025-08-26 16:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 22:13 Ioana Risteiu
2025-08-25 22:13 ` [PATCH v6 1/4] iio: adc: adi-axi-adc: add axi_adc_num_lanes_set Ioana Risteiu
2025-08-25 22:13 ` [PATCH v6 2/4] dt-bindings: iio: adc: add IIO backend support Ioana Risteiu
2025-08-25 22:13 ` [PATCH v6 3/4] iio: adc: extract setup function without backend Ioana Risteiu
2025-08-25 22:13 ` [PATCH v6 4/4] iio: adc: update ad7779 to use IIO backend Ioana Risteiu
2025-08-26 16:24 ` David Lechner [this message]
2025-08-31 12:37   ` [PATCH v6 0/4] Add IIO backend support for AD7779 Jonathan Cameron
2025-09-10 16:34     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82a21a66-409f-4ec8-9351-365031b8646b@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=Ioana.Risteiu@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=ramona.nechita@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®