From: Andrew Lunn <andrew@lunn.ch>
To: Wei Fang <wei.fang@nxp.com>
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Clark Wang <xiaoning.wang@nxp.com>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Aziz Sellami <aziz.sellami@nxp.com>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95
Date: Mon, 3 Nov 2025 14:16:19 +0100 [thread overview]
Message-ID: <82a5d4b9-9327-4f0e-86ec-8861e1de57f2@lunn.ch> (raw)
In-Reply-To: <PAXPR04MB8510D431ACAF445F8E516A0288C7A@PAXPR04MB8510.eurprd04.prod.outlook.com>
> > So you have up to 32 virtual MDIO busses stacked on top of one
>
> Theoretically, there are up to 33 virtual MDIO buses, 32 port MDIO +
> 1 'EMDIO function'. The EMDIO function can access all the PHYs on
> the physical MDIO bus.
The EMDIO function sound dangerous. All the locking and PHY drivers
assume they have exclusive access to a devices on the bus. Bad things
will happen if they don't. And given how infrequently MDIO is
typically used, such bugs are going to be hard to find.
You might want to make the 32 port MDIOs and the EMDIO mutually
exclusive, so you can eliminate those potential bugs.
Andrew
next prev parent reply other threads:[~2025-11-03 13:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 9:15 Wei Fang
2025-10-30 9:15 ` [PATCH net-next 1/3] net: enetc: set external MDIO PHY address for i.MX95 ENETC Wei Fang
2025-10-30 9:15 ` [PATCH net-next 2/3] net: enetc: set external MDIO PHY address for i.MX94 ENETC Wei Fang
2025-10-30 9:15 ` [PATCH net-next 3/3] net: enetc: add port MDIO support for ENETC v4 Wei Fang
2025-10-30 17:43 ` [PATCH net-next 0/3] net: enetc: add port MDIO support for both i.MX94 and i.MX95 Andrew Lunn
2025-10-31 1:49 ` Wei Fang
2025-10-31 12:31 ` Andrew Lunn
2025-11-01 0:24 ` Wei Fang
2025-11-01 14:43 ` Andrew Lunn
2025-11-03 2:11 ` Wei Fang
2025-11-03 13:16 ` Andrew Lunn [this message]
2025-11-04 2:29 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82a5d4b9-9327-4f0e-86ec-8861e1de57f2@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=aziz.sellami@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®