mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Kuppuswamy Sathyanarayanan
	<sathyanarayanan.kuppuswamy@linux.intel.com>,
	Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org
Subject: Re: [PATCH v1] efi/libstub: Add Confidential Computing (CC) measurement support
Date: Sun, 04 Feb 2024 07:46:44 +0100	[thread overview]
Message-ID: <82a84e769875c70279348179c1b2b63a16770c8e.camel@HansenPartnership.com> (raw)
In-Reply-To: <20240203075736.3982371-1-sathyanarayanan.kuppuswamy@linux.intel.com>

On Sat, 2024-02-03 at 07:57 +0000, Kuppuswamy Sathyanarayanan wrote:
> If the virtual firmware implements TPM support, TCG2 protocol will be
> used for kernel measurements and event logging support. But in CC
> environment, not all platforms support or enable the TPM feature.
> UEFI specification [1] exposes protocol and interfaces used for
> kernel measurements in CC platforms without TPM support.
> 
> Currently, the efi-stub only supports the kernel related measurements
> for the platform that supports TCG2 protocol. So, extend it add
> CC measurement protocol (EFI_CC_MEASUREMENT_PROTOCOL) and event
> logging support. Event logging format in the CC environment is the
> same as TCG2.

Why do we have to do this anymore?  Given that you're already pushing
patches that map RTMRs to TPM PCRs:

https://lore.kernel.org/lkml/20240128212532.2754325-4-sameo@rivosinc.com/

Can't you just add a stub TCG2 driver to EFI that exposes only the
ability to log and measure using this mapping?  That way all our
existing code will "just work" without the need to understand anything
about confidential computing or add new code to do the measurement?

James


  parent reply	other threads:[~2024-02-04  6:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-03  7:57 Kuppuswamy Sathyanarayanan
2024-02-03 16:59 ` Ard Biesheuvel
2024-02-03 22:44   ` Kuppuswamy Sathyanarayanan
2024-02-04  6:46 ` James Bottomley [this message]
2024-02-04 20:27   ` Kuppuswamy Sathyanarayanan
2024-02-04 22:03     ` Ard Biesheuvel
2024-02-05 20:13       ` Kuppuswamy Sathyanarayanan
2024-02-05  8:20     ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82a84e769875c70279348179c1b2b63a16770c8e.camel@HansenPartnership.com \
    --to=james.bottomley@hansenpartnership.com \
    --cc=ardb@kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®