From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 699CF39C63E for ; Tue, 26 May 2026 08:55:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785736; cv=none; b=B+BPAaKeYMt9w0cPf2FnLIjUKt/uuV7lGiI/JNz/CKXdBNJYAr41Pdb7PiaUBPNtA5PeDJTADKMr97qEvHAy2V1z2xBSLvS/NDxevdIpeMl6BN9XPqJyFv0Tdhu821Kbz3DUyvaSofywwYjBCYr4n8IyQBT9hdUOYStYeJXaUfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779785736; c=relaxed/simple; bh=f5KtYKaGJIxJIH6az8ZfzoSlLeMtkQY1lpV+rUwL+KQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q/dQhhxRJhI6LxeL2QWWYvYa1ckBUWnMgr88gwM0TaCBRX58auDKZUYJdas4xVUNtSth3/2aHS4A9u7qFX2FBKHLEhSE4H1xoKu277Kx0prmEfsqR6NFpSiGNXK64firBSYxKdXRaS3pMtWyJSakxY6dDkG1oII7ViFyRYk5w2s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YV7HYVYN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kOy8k96w; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YV7HYVYN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kOy8k96w" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64Q70Ip73263603 for ; Tue, 26 May 2026 08:55:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lW+9suIyqVCiJGP9No19FKzkPfU8OlRbEUkWKfC9f+4=; b=YV7HYVYNNxtmRNDt fqLX21zOLn9xr6KdWdFRx7xpanAs3FfIPeMi8WBSnozd67JKodgAIPDUZ5LOqfJQ 1qlBS5MN+esEN1hguBnApfVoxbLIG2YpuzLkr8/G6mFB3Or1lwaQw6BVXlsTwhUQ B7ti7z7zj+wx4heoDd+wmtr3x3dP10ozxXCmRO8WS9YGtB2zbi/MKQrFOk/bxtMs wmqoaOFMUFXx5PLmTUG9Fs2NZx66HM5oVHOmPl4L26QYdRMlDdR0t8RP2Bhf2Xc5 3PEBgYohLB4ItwmG18UKouY9MOhv0IjtKxEAmHooCn2UY+Vcag//c9RXLN3tblD/ TG5cxw== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ecnhs3kcm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 26 May 2026 08:55:33 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-516eaf9fb76so46983231cf.1 for ; Tue, 26 May 2026 01:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779785733; x=1780390533; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lW+9suIyqVCiJGP9No19FKzkPfU8OlRbEUkWKfC9f+4=; b=kOy8k96wAYKMw1oN78aAhVP8QRYK6ICVv/KydJcvFs2PMnxSWFN2EiLery05mqqDyu mV8CnkqzQFF6g928HcU2EIgRxFCHyTpXLid+bz3WEkn/1gxOfteBBmiejoRXK72lo3E4 OrD2HDCdIpqCxNKtIhQwvjNbCiHucCuNZjHN7cv7yI4hC9bttwgs+OKQfx7yTNR91qfg 2dp+qoK9PAJzjt/hxcTLdPNguwIw2OnUvmyV4qtTfpC53JfdQck3cP7denSeZVvmp8EG NWaj7b64GZZVLp9cAliSeHf/7Idb2hr4YfMsMYAhJosmCvYK6cRCSpwKKCMhZ0CkdnxN vBHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779785733; x=1780390533; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lW+9suIyqVCiJGP9No19FKzkPfU8OlRbEUkWKfC9f+4=; b=sBVnaVs6Ks8SvqA+9yqrbuV8ZR/IPvlU8XYOQzQ/O2PkuuepeYRHQC524hHML5Wa4t xE7USezR1qkGRKxJRJ9Sctjx/S+AfRHtid20qXi5VWtCzo1id8oXBQ+a/LHqbcYJYtI6 yJX7dBnPfK5Cdm6K8cGxj/V/xsf5S8pjBc6q6k0oNwPmecnaR+0ExiyXdoVV5uHEYYmu o7cFjYI5qKLPk7OnSefQuZTb1FLKBuAM3BKf1Y/dZPLbEeiFvNAMl87nnNfITJ0cGuF6 kjutrUpedLrnQQlzwPRpCFL1YJ79JSXHXk3y2w6l3y3dQPinsoHdauszDnz7P5GJBYff JJHw== X-Forwarded-Encrypted: i=1; AFNElJ8juARVgMVhq25YVE0/A+zPBFCU5NH+87hG5MvWtyqOvxeUe1XuY1ZKg4AbSHxX/CLRvJ8mtIqxo3RXfd0=@vger.kernel.org X-Gm-Message-State: AOJu0YxtcC/w9de/H9g/8XKVu+3sip6yeJ3fqeci8vsfpJc9Q/K+1lwL 5OC471A2WVkFdiup7ziUy5xOFqVh78mACRFtMEOXIAxvRJ/ojl1lKuFbNF5AuffiSEcW5Ga/Ooe /jFZMXLJ2Fe199r0sjv07xIuDke/nJAKjCzAM96sRNGvuyFk9w/b3eCIpFTdNBj6RFIY= X-Gm-Gg: Acq92OHMQPLlAoeR9X6eRuT3Bkq2Ip42mUbLnq0tF9zeC8DAguUUVcETBmBankD9YJ5 M4aReRb9iUfYtnDy3z57xrMm+Y5iG5/SobWTOqejo2It+/Z7pDhFFscRikKby+MPDvg3inSqPfe GUHBhP0Tb5R8ajSml0Q9LHh8DIkM6sBsEu+ct4YeXqxWgO6yIcILaIZ7wxZNS4RiZ0EyywXVwO0 Yu0dA87v4ps2YrrrhXTWlWQ1d+HKU2bR/rk1nq4UuQbgzBMQ37aIABBVDzFeUNJWw0p0+Lm+tCG t+ipvTxjnk0onMgJvopdEuE04Nz7pxRc3pb9wqoV8ieIC2da0DNx/+DXnCNtMGnlb5xYIHenuCV y0fezgzBB/hFUJTlD6tvRr93EeY/RSLXaAjj5uXILm7o9S0A930hV97GtHXgy+AJUyGh+YuV4HM HxxrBGYm1RnE+mpQXiSKVsHhZ/JsPETga7iB9QuOUKIC3zGI2mWv6JFCs9vr9clZG1ey5vI/1gC aONaXBrOo6Rpvb7 X-Received: by 2002:a05:622a:4e89:b0:516:d66e:7b1d with SMTP id d75a77b69052e-516d66ec014mr228482841cf.27.1779785732762; Tue, 26 May 2026 01:55:32 -0700 (PDT) X-Received: by 2002:a05:622a:4e89:b0:516:d66e:7b1d with SMTP id d75a77b69052e-516d66ec014mr228482591cf.27.1779785732340; Tue, 26 May 2026 01:55:32 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bddc62d3f21sm478681466b.44.2026.05.26.01.55.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 01:55:31 -0700 (PDT) Message-ID: <82a96d57-94fc-470a-b7eb-f0fde0c0dad6@oss.qualcomm.com> Date: Tue, 26 May 2026 10:55:30 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: input: hid-over-i2c: Add reset-gpios property To: Pradyot Kumar Nayak , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Abel Vesa , Dmitry Baryshkov , Benjamin Tissoires , Jiri Kosina Cc: linux-arm-msm@vger.kernel.org, linux-input@vger.kernel.org, Konrad Dybcio , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, 20260519-glymur-mahua-common-nodes-v2-1-9f1b89a3f398@oss.qualcomm.com References: <20260523-arm64-dts-glymur-crd-add-reset-gpio-to-touchscreen-v2-0-5c333051e5bb@oss.qualcomm.com> <20260523-arm64-dts-glymur-crd-add-reset-gpio-to-touchscreen-v2-1-5c333051e5bb@oss.qualcomm.com> From: Hans de Goede Content-Language: en-US, nl In-Reply-To: <20260523-arm64-dts-glymur-crd-add-reset-gpio-to-touchscreen-v2-1-5c333051e5bb@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Vd3H+lp9 c=1 sm=1 tr=0 ts=6a156005 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=DlE_u-NSBxGluEoo6gkA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: 3on4TmIoZA3AXiA0TUKJrvoGVYT1N7uU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI2MDA3NyBTYWx0ZWRfXwU/BiLwxwd+f dzDBLNox0PR0ygHwreu2brtgfqyPV6zABwuxiKI4NZ7Fx2A3XTjWsGa+E9ZIZg+KSG6PP+aA7Ih GVCVEFN9jFpDAA6D+/uQXkxiUD0AHlxWdFfFTJZv8f5gm4La3VqdZa5MA0engdUh1yeZYI9hnbd EUUQpQMGyhFO1nYP1dK4Le3JmzHeIuD0fup3GhyHnaiwCb0qi9H8uZj/jeXcrr1P/MCGf4wAG9z IhQy51HTsMaseJ4KVI1ByG0Tom2LJi23ecC6ENyS80nrhWfZ3BanxP2JKmP49TGudLHRHAv8Fwf a7E7eyKiYzJse7jFx17rFeOHkcc4vTO3g7uCbZ1iRZxDEN20rTLUbrWGxIj9/vfzZQyOk071Qt+ x3vV05Z5z88eCX4humOKTqwi40tt3kdDD4dVr7Y3VcPjf1lNHkFnjO1wdXpFeNSYDRFxkgHQRT5 BYHcCJpCJFhD6tWdzeg== X-Proofpoint-ORIG-GUID: 3on4TmIoZA3AXiA0TUKJrvoGVYT1N7uU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-26_02,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605260077 Hi, On 22-May-26 21:55, Pradyot Kumar Nayak wrote: > Document reset-gpios property for devices that explicitly require > the reset line to be de-asserted during power up. > > Signed-off-by: Pradyot Kumar Nayak > --- > Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml > index 138caad96a29..fe0ec4fce673 100644 > --- a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml > +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml > @@ -50,6 +50,10 @@ properties: > description: Time required by the device after enabling its regulators > or powering it on, before it is ready for communication. > > + reset-gpios: > + maxItems: 1 > + description: GPIO line used to reset the device. > + For I2C HID devices which need a reset, we typically also need reset timings, trying to do I2C transfers to the device directly after the reset has been de-asserted typically will not work and some touchscreen-model specific delay is necessary. So far in the DT world this has been handled by touchscreen vendor specific bindings: Documentation/devicetree/bindings/input/elan,ekth6915.yaml Documentation/devicetree/bindings/input/focaltech,ft8112.yaml Documentation/devicetree/bindings/input/ilitek,ili9882t.yaml Which are all 3 handled by: drivers/hid/i2c-hid/i2c-hid-of-elan.c Which has per compatible match-data with the reset timings. You should probably extend drivers/hid/i2c-hid/i2c-hid-of-elan.c with support for the CRD touchscreen and either add a new compatible to one of the existing 3 bindings; or if the touchscreen controller IC is from a vendor without a binding yet maybe add a new bindings file? There also is: Documentation/devicetree/bindings/input/goodix,gt7375p.yaml which is handled by: drivers/hid/i2c-hid/i2c-hid-of-goodix.c and is special in its own way. Regards, Hans