mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hao Zhang <quic_hazha@quicinc.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@linaro.org>, Leo Yan <leo.yan@linaro.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Mathieu Poirier <mathieu.poirier@linaro.org>,
	Konrad Dybcio <konradybcio@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Andy Gross <agross@kernel.org>,
	"Paul Walmsley" <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Jonathan Corbet <corbet@lwn.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	<coresight@lists.linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	Tingwei Zhang <quic_tingweiz@quicinc.com>,
	Jinlong Mao <quic_jinlmao@quicinc.com>,
	"Yuanfang Zhang" <quic_yuanfang@quicinc.com>,
	Tao Zhang <quic_taozha@quicinc.com>,
	Trilok Soni <quic_tsoni@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>,
	"Bjorn Andersson" <andersson@kernel.org>,
	<linux-doc@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] Documentation: trace: Add documentation for Coresight Dummy Trace
Date: Fri, 12 May 2023 15:51:34 +0800	[thread overview]
Message-ID: <82aab1d7-0157-983a-5f92-3dcd1e04fe23@quicinc.com> (raw)
In-Reply-To: <ZFsdvCuTTEkTm9VA@debian.me>

Hi Bagas,

On 5/10/2023 12:29 PM, Bagas Sanjaya wrote:
> On Sat, Apr 22, 2023 at 03:37:14PM +0800, Hao Zhang wrote:
>> +Introduction
>> +---------------------------
>> +
>> +Coresight Dummy Trace Module is for the specific devices that kernel
>> +don't have permission to access or configure, e.g., CoreSight TPDMs
>> +on Qualcomm platforms. So there need driver to register dummy devices
>> +as Coresight devices. It may also be used to define components that
>> +may not have any programming interfaces (e.g, static links), so that
>> +paths can be established in the driver. Provide Coresight API for
>> +dummy device operations, such as enabling and disabling dummy devices.
>> +Build the Coresight path for dummy sink or dummy source for debugging.
>> +
>> +Config details
>> +---------------------------
>> +
>> +There are two types of nodes, dummy sink and dummy source. The nodes
>> +should be observed at the below coresight path::
>> +
>> +    ``/sys/bus/coresight/devices``.
>> +
>> +e.g.::
>> +
>> +    / $ ls -l /sys/bus/coresight/devices | grep dummy
>> +    dummy0 -> ../../../devices/platform/soc@0/soc@0:dummy_source/dummy0
>> +    dummy1 -> ../../../devices/platform/soc@0/soc@0:dummy_sink/dummy1
> 
> The wording confuses me, so I have to make the improv:
> 
> ---- >8 ----
> diff --git a/Documentation/trace/coresight/coresight-dummy.rst b/Documentation/trace/coresight/coresight-dummy.rst
> index 7cb59f080c8892..f0a92669288b0c 100644
> --- a/Documentation/trace/coresight/coresight-dummy.rst
> +++ b/Documentation/trace/coresight/coresight-dummy.rst
> @@ -8,27 +8,25 @@ Coresight Dummy Trace Module
>       :Date:     May 2023
>   
>   Introduction
> ----------------------------
> +------------
>   
> -Coresight Dummy Trace Module is for the specific devices that kernel
> -don't have permission to access or configure, e.g., CoreSight TPDMs
> -on Qualcomm platforms. So there need driver to register dummy devices
> -as Coresight devices. It may also be used to define components that
> -may not have any programming interfaces (e.g, static links), so that
> -paths can be established in the driver. Provide Coresight API for
> -dummy device operations, such as enabling and disabling dummy devices.
> -Build the Coresight path for dummy sink or dummy source for debugging.
> +The Coresight dummy trace module is for the specific devices that kernel don't
> +have permission to access or configure, e.g., CoreSight TPDMs on Qualcomm
> +platforms. For these devices, a dummy driver is needed to register them as
> +Coresight devices. The module may also be used to define components that may
> +not have any programming interfaces (e.g, static links), so that paths can be
> +created in the driver. It provides Coresight API for operations on dummy
> +devices, such as enabling and disabling them. It also provides the Coresight
> +dummy sink/source paths for debugging.
>   
>   Config details
> ----------------------------
> +--------------
>   
> -There are two types of nodes, dummy sink and dummy source. The nodes
> -should be observed at the below coresight path::
> +There are two types of nodes, dummy sink and dummy source. These nodes
> +are available at ``/sys/bus/coresight/devices``.
>   
> -    ``/sys/bus/coresight/devices``.
> +Example output::
>   
> -e.g.::
> -
> -    / $ ls -l /sys/bus/coresight/devices | grep dummy
> +    $ ls -l /sys/bus/coresight/devices | grep dummy
>       dummy_sink0 -> ../../../devices/platform/soc@0/soc@0:sink/dummy_sink0
>       dummy_source0 -> ../../../devices/platform/soc@0/soc@0:source/dummy_source0
> 
> Thanks.
> 

Thanks for your review and comments, will update it in the next patch 
series.

Thanks,
Hao

      reply	other threads:[~2023-05-12  7:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-22  7:37 [PATCH v3 0/3] Add support to configure Coresight Dummy subunit Hao Zhang
2023-04-22  7:37 ` [PATCH v3 1/3] Coresight: Add coresight dummy driver Hao Zhang
2023-04-24 12:09   ` Suzuki K Poulose
2023-04-28  5:35     ` Hao Zhang
2023-04-22  7:37 ` [PATCH v3 2/3] dt-bindings: arm: Add Coresight Dummy Trace Hao Zhang
2023-04-25 18:46   ` Rob Herring
2023-04-28  7:09     ` Hao Zhang
2023-04-22  7:37 ` [PATCH v3 3/3] Documentation: trace: Add documentation for " Hao Zhang
2023-05-10  4:29   ` Bagas Sanjaya
2023-05-12  7:51     ` Hao Zhang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82aab1d7-0157-983a-5f92-3dcd1e04fe23@quicinc.com \
    --to=quic_hazha@quicinc.com \
    --cc=agross@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=andersson@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=bagasdotme@gmail.com \
    --cc=corbet@lwn.net \
    --cc=coresight@lists.linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=konradybcio@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=mike.leach@linaro.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=quic_jinlmao@quicinc.com \
    --cc=quic_taozha@quicinc.com \
    --cc=quic_tingweiz@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=quic_yuanfang@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®