From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751253AbdE3QbA (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 May 2017 12:31:00 -0400
Received: from smtprelay2.synopsys.com ([198.182.60.111]:36770 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751094AbdE3Qa6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 May 2017 12:30:58 -0400
Subject: Re: [PATCH] arc: Add "include chroot" for DT bindings
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
        <linux-snps-arc@lists.infradead.org>
CC: <linux-kernel@vger.kernel.org>, Stephen Warren <swarren@wwwdotorg.org>,
        Rob Herring <robh+dt@kernel.org>
Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc
References: <1496150575-9273-1-git-send-email-abrodkin@synopsys.com>
From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Message-ID: <82af576a-939b-f8cc-5c52-3b4ffb389dcb@synopsys.com>
Date: Tue, 30 May 2017 09:30:43 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.1
MIME-Version: 1.0
In-Reply-To: <1496150575-9273-1-git-send-email-abrodkin@synopsys.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.10.161.108]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/30/2017 06:22 AM, Alexey Brodkin wrote:
> Basically this extends
> c58299aa8754 "kbuild: create an "include chroot" for DT bindings" for
> ARC where we extensively use Device Tree and there're good reasons
> to use DT bindings, especially if those are required.
> 
> Otherwise on attempt to compile .dts with something like:
> -------------------->8---------------------
>   #include <dt-bindings/net/ti-dp83867.h>
> -------------------->8---------------------
> 
> we inevitably see this compilation failure:
> -------------------->8---------------------
> arch/arc/boot/dts/hsdk.dts:16:40: fatal error: dt-bindings/net/ti-dp83867.h: No such file or directory
>   #include <dt-bindings/net/ti-dp83867.h>
>                                          ^
> compilation terminated.
> -------------------->8---------------------
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> ---
>   arch/arc/boot/dts/include/dt-bindings | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 120000 arch/arc/boot/dts/include/dt-bindings
> 
> diff --git a/arch/arc/boot/dts/include/dt-bindings b/arch/arc/boot/dts/include/dt-bindings
> new file mode 120000
> index 000000000000..08c00e4972fa
> --- /dev/null
> +++ b/arch/arc/boot/dts/include/dt-bindings
> @@ -0,0 +1 @@
> +../../../../../include/dt-bindings
> \ No newline at end of file


I'm OK with adding this to ARC, but won't it be nicer to have a generic include 
helper instead to avoid boilerplate addition in multiple places ?

-Vineet