From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06B8A47DF93 for ; Thu, 2 Jul 2026 10:04:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782986659; cv=none; b=kOCx5mpXEVSRo1C9jNBGlc+ldQE9m+Psc9ELYh2NU+1yv3qKSlQRzpJskcCPaY0FvzT31IeuCV/evclNomtqT/OmYBsyyzb6SyC5fnj0NgIY741VeHKTNh52Wc4ofRKY13mkJC8wfvyTNM8bmG08bvRoNoHwycHGzDcq270BHjE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782986659; c=relaxed/simple; bh=kAbt5jy0AWfc7eQlFbvotBe1BjW17MNU19lTQumf09k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rZ5yQiDXpI+3dGlCahLE+jdoRuGJSTnlVyK3yA88oHvLcZvLiEobvCthYKyOMALIFat5+BN2qFlm0sQeieJFV3iorL89ozDKR0mNRLbLHG3AabLFvqtcAWPQ45DpYHuRcM/JT1sP/NqY++4SUpt35JgYlHgVr7VEoOBPA7YZnh8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hqgWTufH; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RCefbAk+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hqgWTufH"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RCefbAk+" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6628mx123050526 for ; Thu, 2 Jul 2026 10:04:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X/U9dWL01ogUm6KwlW/lYdtEi4/xfsMOfKBCZVVXfEA=; b=hqgWTufHZf4Ieb1K P2cJ09t0KNRmMxs1eaZbg5A6zyeOPRF/vmyBFu4XBJslakJNIXk2uJzvG5xNWcwZ u4OjoYa7E72UDykzvBn7aLTaex/vOYpdSwaaLAGcF+Lea84BMvwTTZf5XCxIYxLv GG6hDkMPDr3ztyC2sOQ0J3JaVzUKL9PCXWaBXpNOFDurAJBAc3jnWo3U8MgH3Np6 FrHph15W3A+ocO2M48Txnb/Xhd5iPF5R3lqHqVY8pk+meOmSTbVLiTRpBjOwFog7 Gj6y0X7AJ6QNOHxcIIK8uJ53V4NiQn+fQn3x3oJbDHG0xhLE6MYF73jYRVh4sP7+ TNsypw== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f58k3axs0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 02 Jul 2026 10:04:16 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51c21be5bb4so8156971cf.0 for ; Thu, 02 Jul 2026 03:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782986656; x=1783591456; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=X/U9dWL01ogUm6KwlW/lYdtEi4/xfsMOfKBCZVVXfEA=; b=RCefbAk+wAB5Bh9T16yom+DzSgs0zFBjw1/5zneWrj7z+4jIr/nMJw4JBdoI652vM0 zQMyXDakp7uz0jz0Mwsxea4DQkdV5ROwQzAxf2Jm7h/h8lsxAErW3qCoELBnDcWmTnNF R+OqdkY9SPK9ejFxQzYriPkqMR8P0EE5YWESao2FmJwNTT3IjivwxY+SBO/T6GrtFCEx 9nv0L/9LPFz0jy4Q5rbhgiuqICa5706PmjGc3lPk30bLNc6zdUAFvFVKXys7JENtsN6N kDe8yvdUN8YWBGH7XurtzQKaIKaXl8ronLu5HY4ITGqlDJG3AkA0ofJeyZpBU9VVw0sA p6UQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782986656; x=1783591456; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=X/U9dWL01ogUm6KwlW/lYdtEi4/xfsMOfKBCZVVXfEA=; b=iApR8LqcgxTJECidkZ0AsPmMVazOor7smHETVa4T9DdsjwnSN5/IBg5LiNuA0a4I58 M9RLjvmPeIThLwu2/Ofq2ANcORRkppztP6qGtYhnjjvxZuOXeZgSx1/ypgWDC5cXWzIa 0YIQPQX8NOcNJ9+WWdDKzKJlxBgW63uqItyf0xv2DwptybGc5MF/RWUNFgSwmupMU07P LYfdpgJOSzDVn1tQXThiMPCRrYa7kDjqkJi2Ozk/gmOJC8X9rJ/VaV3Xn8XxgJaPD3BQ XAT3c+kBGRj0Ek3zao9TJobCkVsu8wCl6Xo2tTBSKh4MViwHh2LhvOhgNmfx69IARqyL VIBA== X-Forwarded-Encrypted: i=1; AFNElJ9Yq/XLWpsh6HLNHmEjuiWcKJeMYwNCPUM10B9P/rri5U4z0LGCLLorurSivtta+EJGVURECRc2lDHsVS4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz3T1rKm40cYlsDBb0a3bA6ORpXklZQpx23CYbEGPx0t+eBkEdb m1dS6171nAeZQ9o77a0k3OD7vFeMMUzebb4ZDbenUYD6nGLOoQXevtgONIULyDngGTXhqbFXNDb I/CmaARsWX29AlqzgKApoy1/GkakCysM3zqeqghQ0g+dcgZQpttuL3uyRdR66X5nsF+A= X-Gm-Gg: AfdE7cnZpoM0s5b0wdq0kLuIrZOrd4jTDzQBfI51jGXeb0iNnMkhVik8/Y4UbxzHhsn GU4hZydBcuDTlF9c3GEZfpWYwaHmONIkI2wxifWjUtYyl/EpE9cnJpUGiQ/nfSqwdDsNPY0erNX 5OUHTIjpblSoJwwf5Wbddm9C/MW+tnzJ0IfcEdwJoCadDan4nX6RvaAZ47bKxXbi6xCYCZu8d/q Z50Qver6AiAJvWzIPkX1JQfbFXQEwFZCxPnA2ObtoUP62j8BvN0h0QltBl2gw03da2qGIuMtHZd 1DiCBEk4sPvCq8diXHkL0T81JpphDRZOwlXo7ZyflXEt9vtcupS9h/kHgGrWkDM++nE6xbihL3r bEIPKyv8HK2LXZVXEJZ+3T9xcHMLQ1q8PqCg= X-Received: by 2002:a05:622a:1aa5:b0:51b:eab3:4ef1 with SMTP id d75a77b69052e-51c26a69173mr42484411cf.4.1782986656211; Thu, 02 Jul 2026 03:04:16 -0700 (PDT) X-Received: by 2002:a05:622a:1aa5:b0:51b:eab3:4ef1 with SMTP id d75a77b69052e-51c26a69173mr42484051cf.4.1782986655684; Thu, 02 Jul 2026 03:04:15 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c12b62c4a72sm102517266b.43.2026.07.02.03.04.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Jul 2026 03:04:14 -0700 (PDT) Message-ID: <82b28f9d-029a-4b5c-852c-7ae74b1ff83f@oss.qualcomm.com> Date: Thu, 2 Jul 2026 12:04:13 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] firmware: qcom: tzmem: guard against IS_ERR() in the cleanup handler To: Mukesh Ojha , Bartosz Golaszewski Cc: Bartosz Golaszewski , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260701-qcom-scm-code-shrink-v1-0-02f5ce02c95a@oss.qualcomm.com> <20260701-qcom-scm-code-shrink-v1-1-02f5ce02c95a@oss.qualcomm.com> <20260702081026.c7rzopcn7vypggjq@hu-mojha-hyd.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260702081026.c7rzopcn7vypggjq@hu-mojha-hyd.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzAyMDEwNCBTYWx0ZWRfX5LYMkcNyyzrF 1FW0SKyXrBM3stnL8e8R9guJrjWY03M9TTi0Q2yGSATNtFOkC0k+AQXeXHpnOx+Ouw3N5FOYVDh ugdAskOrtT01458Ut6gcpZ4Xg6CMnvZuMNSCAM4cefKyDGTdvtkUJHq0VAsXcmAM6o/SEls7Flt WrSFc4HsjxeLxIEYcUdxQicW6U8VZs3JP+ltQSdfd4yXpsWVUSNdpkskL6Myu+snOQui5G+YQwz zROEmP3mVoyafO1DPx+J++EyIqVBFq1UUUJ/IoZFyxRCrGBkICoATrydxiNu/G9Po9HZWMWCetY Uc+lq/637a+5++SSajkkPIqZH2xwi7z+3cNFHe0YYlCJM1W6LWlsW7mBkr0oykjkqBOXHsYOa33 zOOckGAtmRRavLVRW29Bn1T4q+b+DOXR+Te434rWYKU3jPnIc8Jz0QEJbWZ1TEIVeoKal3xOfi3 1bG0p+A2PqbL+yAgMOw== X-Authority-Analysis: v=2.4 cv=SuGgLvO0 c=1 sm=1 tr=0 ts=6a4637a0 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=KwOIPtOmoVbsDEHMBlAA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzAyMDEwNCBTYWx0ZWRfX1FgeYopBsEx3 NonynsHZa8Qc4iJGZFGlSNYGUwhgmUb+yhs6GLaiMvYkny4m7MSobA1ol5DsJBTVzIblM9x8L2t RazB0Y25lpy+FNXqXWqTGtYpjNGuh+0= X-Proofpoint-ORIG-GUID: nFkcwiHvECHnpj7pSlI5Xo7VXvmRrUEn X-Proofpoint-GUID: nFkcwiHvECHnpj7pSlI5Xo7VXvmRrUEn X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-07-02_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607020104 On 7/2/26 10:10 AM, Mukesh Ojha wrote: > On Wed, Jul 01, 2026 at 03:38:55PM +0200, Bartosz Golaszewski wrote: >> We currently only silently skip NULL-pointers in the cleanup handler for >> tzmem. It's possible that we get passed a pointer holding an ERR_PTR() >> value so skip it too. >> >> Signed-off-by: Bartosz Golaszewski >> --- >> include/linux/firmware/qcom/qcom_tzmem.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/linux/firmware/qcom/qcom_tzmem.h b/include/linux/firmware/qcom/qcom_tzmem.h >> index 23173e0c3dddd154dd56dc3dcb56bd20ada0520a..b5520178bf6f53b86b530571a3be9f302225f022 100644 >> --- a/include/linux/firmware/qcom/qcom_tzmem.h >> +++ b/include/linux/firmware/qcom/qcom_tzmem.h >> @@ -58,7 +58,7 @@ devm_qcom_tzmem_pool_new(struct device *dev, >> void *qcom_tzmem_alloc(struct qcom_tzmem_pool *pool, size_t size, gfp_t gfp); >> void qcom_tzmem_free(void *ptr); >> >> -DEFINE_FREE(qcom_tzmem, void *, if (_T) qcom_tzmem_free(_T)) >> +DEFINE_FREE(qcom_tzmem, void *, if (!IS_ERR_OR_NULL(_T)) qcom_tzmem_free(_T)) > > Is this really required? Are we trying to address an issue which > does not exist today? It doesn't, I was scratching my head too, but in patch 2 there's: void *output_rt_tzm __free(qcom_tzmem) = __qcom_scm_pas_get_rsc_table(ctx->pas_id, input_rt_tzm, input_rt_size, &size); and __qcom_scm_pas_get_rsc_table() does throw ERR_PTRs Konrad