mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dou Liyang <douly.fnst@cn.fujitsu.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Pavel Tatashin <pasha.tatashin@oracle.com>,
	<steven.sistare@oracle.com>, <daniel.m.jordan@oracle.com>,
	<linux@armlinux.org.uk>, <schwidefsky@de.ibm.com>,
	<heiko.carstens@de.ibm.com>, <john.stultz@linaro.org>,
	<sboyd@codeaurora.org>, <x86@kernel.org>,
	<linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
	<hpa@zytor.com>, <peterz@infradead.org>, <prarit@redhat.com>,
	<feng.tang@intel.com>, <pmladek@suse.com>,
	<gnomes@lxorguk.ukuu.org.uk>, <linux-s390@vger.kernel.org>,
	<boris.ostrovsky@oracle.com>, <jgross@suse.com>,
	<pbonzini@redhat.com>
Subject: Re: [PATCH v14 20/25] x86/tsc: calibrate tsc only once
Date: Thu, 19 Jul 2018 14:48:28 +0800	[thread overview]
Message-ID: <82b363bb-de81-0ddf-cb0d-83945eba72f0@cn.fujitsu.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1807190818110.1689@nanos.tec.linutronix.de>

Hi Thomas,

At 07/19/2018 02:25 PM, Thomas Gleixner wrote:
> On Thu, 19 Jul 2018, Dou Liyang wrote:
>> At 07/18/2018 10:22 AM, Pavel Tatashin wrote:
>>> +		(unsigned long)cpu_khz % KHZ);
>>>      	if (cpu_khz != tsc_khz) {
>>>    		pr_info("Detected %lu.%03lu MHz TSC",
>>> -			(unsigned long)tsc_khz / 1000,
>>> -			(unsigned long)tsc_khz % 1000);
>>> +			(unsigned long)tsc_khz / KHZ,
>>> +			(unsigned long)tsc_khz % KHZ);
>>> +	}
>>
>> this curly brackets can be removed
> 
> No. They want to stay, really.
> 
>      https://lkml.kernel.org/r/alpine.DEB.2.20.1701171956290.3645@nanos
> 
> The pr_info() is a multiline statement due to the line breaks.
> 

I see, I’ll keep that in mind.

Thanks,

	dou



  reply	other threads:[~2018-07-19  6:48 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-18  2:21 [PATCH v14 00/25] Early boot time stamps Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 01/25] x86/kvmclock: Remove memblock dependency Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 02/25] x86/kvmclock: Remove page size requirement from wall_clock Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 03/25] x86/kvmclock: Decrapify kvm_register_clock() Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 04/25] x86/kvmclock: Cleanup the code Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 05/25] x86/kvmclock: Mark variables __initdata and __ro_after_init Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 06/25] x86/kvmclock: Move kvmclock vsyscall param and init to kvmclock Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 07/25] x86/kvmclock: Switch kvmclock data to a PER_CPU variable Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 08/25] x86/kvmclock: Avoid TSC recalibration Pavel Tatashin
2018-07-18 11:14   ` Paolo Bonzini
2018-07-18 13:33     ` Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 09/25] x86: text_poke() may access uninitialized struct pages Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 10/25] x86: initialize static branching early Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 11/25] x86/CPU: Call detect_nopl() only on the BSP Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 12/25] x86/tsc: redefine notsc to behave as tsc=unstable Pavel Tatashin
2018-07-18  2:21 ` [PATCH v14 13/25] x86/xen/time: initialize pv xen time in init_hypervisor_platform Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 14/25] x86/xen/time: output xen sched_clock time from 0 Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 15/25] s390/time: add read_persistent_wall_and_boot_offset() Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 16/25] time: replace read_boot_clock64() with read_persistent_wall_and_boot_offset() Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 17/25] time: default boot time offset to local_clock() Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 18/25] s390/time: remove read_boot_clock64() Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 19/25] ARM/time: " Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 20/25] x86/tsc: calibrate tsc only once Pavel Tatashin
2018-07-19  5:33   ` Dou Liyang
2018-07-19  6:25     ` Thomas Gleixner
2018-07-19  6:48       ` Dou Liyang [this message]
2018-07-19 10:33   ` Peter Zijlstra
2018-07-19 11:01     ` Thomas Gleixner
2018-07-19 15:58       ` Pavel Tatashin
2018-07-19 16:19         ` Thomas Gleixner
2018-07-19 16:49           ` Pavel Tatashin
2018-07-19 18:38             ` Pavel Tatashin
2018-07-19 20:44               ` Thomas Gleixner
2018-07-19 20:46                 ` Pavel Tatashin
2018-07-23  9:28                   ` Alan Cox
2018-07-18  2:22 ` [PATCH v14 21/25] x86/tsc: initialize cyc2ns when tsc freq. is determined Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 22/25] x86/tsc: use tsc early Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 23/25] sched: move sched clock initialization and merge with generic clock Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 24/25] sched: early boot clock Pavel Tatashin
2018-07-19 10:39   ` Peter Zijlstra
2018-07-19 14:16     ` Pavel Tatashin
2018-07-18  2:22 ` [PATCH v14 25/25] sched: use static key for sched_clock_running Pavel Tatashin
2018-07-19 10:48   ` Peter Zijlstra
2018-07-19 14:24     ` Pavel Tatashin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82b363bb-de81-0ddf-cb0d-83945eba72f0@cn.fujitsu.com \
    --to=douly.fnst@cn.fujitsu.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=daniel.m.jordan@oracle.com \
    --cc=feng.tang@intel.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mingo@redhat.com \
    --cc=pasha.tatashin@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=prarit@redhat.com \
    --cc=sboyd@codeaurora.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=steven.sistare@oracle.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®