From: "Singh, Brijesh" <brijesh.singh@amd.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: "Singh, Brijesh" <brijesh.singh@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"Borislav Petkov" <bp@alien8.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>
Subject: Re: [PATCH 0/2] KVM: SVM: move the SEV command handling into a separate file
Date: Mon, 4 Feb 2019 17:17:57 +0000 [thread overview]
Message-ID: <82b462cf-6e94-0e59-2b98-01cc5acd6ede@amd.com> (raw)
In-Reply-To: <20190201182040.GD12454@linux.intel.com>
On 2/1/19 12:20 PM, Sean Christopherson wrote:
> On Fri, Feb 01, 2019 at 04:47:12PM +0000, Singh, Brijesh wrote:
>> svm.c is pretty huge, before we add more SEV specific commands (e.g SEV-ES,
>> SEV-Migration etc) lets move the SEV command handling into a separate file.
>> There is no logical changes in this series.
>
> Any reason not to create arch/x86/kvm/svm/ before introducing sev.c?
>
There are several features in svm.c that can be moved to different
files, SEV bits are just the start. I was thinking that we create
svm directory after features are separated in different files rather
than creating the directory first. Having said so, I am not oppose
to creating directory first then moving the code in a separate file.
Paolo, Radim
thoughts ?
thanks
next prev parent reply other threads:[~2019-02-04 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 16:47 Singh, Brijesh
2019-02-01 16:47 ` [PATCH 1/2] KVM: SVM: move common struct definitions to header file Singh, Brijesh
2019-02-01 16:47 ` [PATCH 2/2] KVM: SVM: move the SEV specific function in a separate file Singh, Brijesh
2019-02-01 18:20 ` [PATCH 0/2] KVM: SVM: move the SEV command handling into " Sean Christopherson
2019-02-04 17:17 ` Singh, Brijesh [this message]
2019-03-28 14:08 ` Singh, Brijesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82b462cf-6e94-0e59-2b98-01cc5acd6ede@amd.com \
--to=brijesh.singh@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=bp@alien8.de \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®