From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2EF9382376 for ; Thu, 25 Jun 2026 09:25:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782379509; cv=none; b=jV+ipHOAzTB9inPaqI/41gAHZc0iXY1P9ayfzb8F7x1PjYLQxwf2Mdx+L+5h3VFtpcYUn8f6JaWsdOXRGFfzuCsWUBviHuG3U9gq532F24K3soSPj2SfhJOoF7tyo6kjwkqPymThY4cLH7k89NCvLTInzpxNHUTbK8IV11TDeeM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782379509; c=relaxed/simple; bh=S8A0MIsdoB9Z/bl+h5cGSw/0oJ1b71iteY6tOP0fHiw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G+GzNZ4Paz7FKyrP8w7mF+tnCvz0Gu3onFx7q0yvy4FoSyS7cPTA0Gg1wXVUL17a/Q/wu/h8fhub8RshSiOXeDSWS5+KbJ3S8smPs3F2LeyAYefIsEbxQcZ4hzCHDjBaOEXs0azQgM0BmpnCllQH+v/6fZGp5OSVLg/vXeDnvvI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mPhOKPYY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=DSQvy904; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mPhOKPYY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="DSQvy904" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P8pH7M1629590 for ; Thu, 25 Jun 2026 09:25:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= wlNuT8OW5AbZRZ7zo4XpP7ZzYh3qaFOpGyK9QlIFi3o=; b=mPhOKPYYo7sZFSr5 XTZGuZPsvhu69DYlKmxwyy5qidNe0ck28455KYP1eDHO0+1EffsJp3yKo/MjBWNf w71e7JGLRleyPkR4jJYehbB/6ytztBKsQOYouMQwkW61G0X1z7CAP7s739/3o5aO VTtHI2aMYlNluLDZ3jZXA1T9oK07hLSmNZFUElf5bcC+txPB8VDas82GLPId9XBO lWQL2jP8McJUdZ/ToFtRRyi1BIZSubcjvB4b/nSNsGN/PuT87YtInaMCeQTeVqaG 6dz2dtA9qdnncx4/4XlRQFJeoqgHmIdFHHDeP15aE5zsMABnJx8MZrxPxi3cl08m mUixmQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0w0q13ww-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 09:25:06 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2c6b4271491so12269495ad.2 for ; Thu, 25 Jun 2026 02:25:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782379506; x=1782984306; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wlNuT8OW5AbZRZ7zo4XpP7ZzYh3qaFOpGyK9QlIFi3o=; b=DSQvy904739pKXVNqk7EgADlvp0KpqEEzN+oMIAbZqRTLW77FT9ulZnZbWDYlz7dAm WsYpWuQuMkn5eUeWPWk2HfXyYiZHCLQ0drUAAQFsXjbp1JG0+/nXr1y21UJzrUp7Cs++ rPvybZukSUC0Va/PUaOPXLV8MGWqqJYIwjNjZDdgbyZqgkMsaUhW8kH0UcO3sJr4BY4e 9sWkmGtWPNPXTqx2Ie4qvtnC1/Tj6o4anyH02U0Ra8I/J+3sUia5fOB/87B8LhX8PBPZ /zw5MZOP51z7RUBStU71ZGOhNVb4jai4p5CB3dtAQ5HN5ISbAHRH+0gxriGy5QQJShLO HzyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782379506; x=1782984306; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wlNuT8OW5AbZRZ7zo4XpP7ZzYh3qaFOpGyK9QlIFi3o=; b=O4itGeqen3QerxNqK43M+TV03FXHBnIFPXG4JABRxq4XXpqidNQxZR8h+UYgkIeq4z 69EZbtfXOhYsL0aEkqs2owoQs8G1YHEg9pLr11025B2ZeXbllZD6Nd7wWnHLyfzKzy6/ 0UdMeJDeNZCWFWWH+UrQ15qXeBom1yn+SUnlDO2s5V5A2lfkjpGfEdaO//aWfG9fzw4S pRJgoAPnMZY628iLVqsKCtM8VtIa4TK75Pe1pSZwj6BAvyPMye9W1qlSniA+aJCdKydS G3qobpxsuQI6WuRIm4sMNX9Gqk5/x6WYQ9lnRE6QedOt/nCq9xQYe7Pv7lQOqpaOu3+B W1cg== X-Forwarded-Encrypted: i=1; AHgh+RrJ4mcBHrUcvmTv5peq6ThXBFjf8AAYdh30h2lM96UoadkatcPWoXWjaXhFbNmmdFBNcMSOyJuvmb73U7w=@vger.kernel.org X-Gm-Message-State: AOJu0YwP9t3isBYaRuQh9ps6uIX8op5+8vZziKg4JOw7mPUooP4rbZcV 4q1xOa0BUkF9ixDtSp2nuJxLEjG/rP/DVtt3SXzlTKZXu3KUbqnTG7Ohm3sMQeMF60VeIa6PUmD UGIOwLwU2BmZmxgs38XeDyysqU6K3qxQegYW6+veMTG1LRj40W2cDSFjBmk9H3EFXbT4= X-Gm-Gg: AfdE7cnsIcIBcKPrGTq2RCSRSh2325WWvk52u/1N/p4Hp8UrQDeSdE0eJgOSXjoBp+e FTUwpbVtU8bYTHbO6cjhUPosrcAdrj0jt4M2wdlhn5ETTwr9LQoQb+vjl40BHZ1y7gW4MFz8V9G wTFuGxH6wskvc1ySW/KQ2aNAbagMkiFjxPJQ4Y6Ul674KHloHB55R8I7WqqldguOd8rzoUvdC9t Xs8okT+H/NO0wNDum6SGFF5RuCaULw4u8GHVG491DIQPyrCZAW3jgwWb2+xkDBMn6fxzvw/nwBn n2UfEbFrtEErbywDgGjipv8ht1HnEAZRPkOdSmtnNxCTSQ9zCaV2XE0CqsCfnEtI+5Ws+XXFWn0 v00v6jnV1ZBLQbYxeubYKRf7udav4CEDP925KWA== X-Received: by 2002:a17:902:fc4f:b0:2c6:6926:8968 with SMTP id d9443c01a7336-2c7fc7406d5mr19613885ad.20.1782379505609; Thu, 25 Jun 2026 02:25:05 -0700 (PDT) X-Received: by 2002:a17:902:fc4f:b0:2c6:6926:8968 with SMTP id d9443c01a7336-2c7fc7406d5mr19613565ad.20.1782379505130; Thu, 25 Jun 2026 02:25:05 -0700 (PDT) Received: from [10.218.48.36] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c7f5afbbd9sm16716915ad.28.2026.06.25.02.24.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 02:25:04 -0700 (PDT) Message-ID: <82bb1355-7ae5-4123-afe5-890c6a6cdd27@oss.qualcomm.com> Date: Thu, 25 Jun 2026 14:54:58 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/8] irqchip/qcom-pdc: Configure PDC to pass through mode To: Konrad Dybcio , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com> <20260616-hamoa_pdc_v3-v3-5-4d8e1504ea75@oss.qualcomm.com> Content-Language: en-US From: "Maulik Shah (mkshah)" In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: atbCLtlDnxC1znKPn1xjHxI_bMXtbXbz X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDA4MCBTYWx0ZWRfXw86uITqAuI09 IQgI1VrI6i2IHnAekD/q/qQHbfHIgRJKiPQ817gJYKhDFKpqRdEbMbveec7xsK6lA9v/Ka7a2CO AwwfXsjODeiLuFCUPMN4sBIAwBuDbLM= X-Proofpoint-GUID: atbCLtlDnxC1znKPn1xjHxI_bMXtbXbz X-Authority-Analysis: v=2.4 cv=R6Ez39RX c=1 sm=1 tr=0 ts=6a3cf3f2 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=VMtcQVj_OTphKyc3ifsA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDA4MCBTYWx0ZWRfXwG9RO3y9TCjU HzJd5nb8Nx8mk+ORqcQivLysEc19jOR5ikqYydZWyICm+MmT3JPL1oOGrsNBa4CVMXOeFXAc48A OeP9Q/4n9IVlVSwDkv2o1nH34sI4TOvh1ehAxbvxvjYwv77vykwJnEwxWV5jSqQVFpOw6sCWotg +RfoV3ABoV/Wy558VRHFnPCYYPBZtd7Vn17j/11XmvTrnRzbPQZ+pV7eGmIN9iovEeR0XDx6Z3C P+8K591RValjXekybN3KVdiTE1J+/cJM4Lc5Su+25X7/9KUc/9ktmb7jlJPnb2iD5QVntYmMbGq +dyEWl1aqXB0KMm47xcTbOOMCZUGwON8MBVw3TYIKmjaaEfeLEFJT36dSmBf4L6kSTHomn4jNwW VPXUrQ2Wc+jB9Nc+Vs0lls+yXJOWVQZcolwO0j1fB76bpgJcrkUYizyK5nNoPqzpMgXif7m8Syd LQe1mWkJSD2UcDltQ7A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250080 On 6/18/2026 1:48 PM, Konrad Dybcio wrote: > On 6/16/26 11:25 AM, Maulik Shah wrote: [...] >> + type = IRQ_TYPE_LEVEL_HIGH; > > > Please carry your comment from the previous revision: > > /* > * PDC forwards GPIOs as level high to GIC in secondary > * mode. Update the type and clear any previously latched > * phantom interrupt at PDC. > */ > I will add back this comment in v4. [...] >> + if (pdc->mode == PDC_PASS_THROUGH_MODE || !pdc_pin_is_gpio(hwirq)) { >> + ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq, >> + &qcom_pdc_gic_chip, >> + NULL); >> + if (ret) >> + return ret; >> >> - region = get_pin_region(hwirq); >> - if (!region) >> - return irq_domain_disconnect_hierarchy(domain->parent, virq); >> + if (type & IRQ_TYPE_EDGE_BOTH) >> + type = IRQ_TYPE_EDGE_RISING; >> >> - if (type & IRQ_TYPE_EDGE_BOTH) >> - type = IRQ_TYPE_EDGE_RISING; >> + if (type & IRQ_TYPE_LEVEL_MASK) >> + type = IRQ_TYPE_LEVEL_HIGH; >> + } else { >> + ret = irq_domain_set_hwirq_and_chip(domain, virq, hwirq, >> + &qcom_pdc_gic_secondary_chip, >> + NULL); >> + if (ret) >> + return ret; >> >> - if (type & IRQ_TYPE_LEVEL_MASK) >> + /* Secondary mode converts all interrupts to LEVEL HIGH type */ >> type = IRQ_TYPE_LEVEL_HIGH; >> + } > > nit: (pdc->mode == PDC_SECONDARY_MODE && pdc_pin_is_gpio(hwirq)) > could be the primary case to better communicate intent > > Konrad Made primary case as (pdc->mode == PDC_SECONDARY_MODE && pdc_pin_is_gpio(hwirq) in v4. Thanks, Maulik