From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 049B61BD01F for ; Mon, 30 Jun 2025 19:16:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751311005; cv=none; b=T3ixhP6+PWonRKQsS2vIruVTXsYnxwRdmzKRw7OgYct3MrZRRp54xzS0ZfAtk8qnKipFglF1SNYDQZoXRrV64h9lnqF0BP5PqxnvghhODFMyI1S0ODYAy6WJ97VSiOEuwvuced9Hg1gKNpIPgoHflUWDRRIlVM2NKacU3Pk+n9w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751311005; c=relaxed/simple; bh=BkVPf9VvjyU/6g05e8LRsSJlmFpCQMsrY6Q+ll0m+4A=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=E8dmauIK5XHqMOFzXLT4zSf8L2sJgu8fOCytee1aDBx/dQCqPxoqEhQF8xV5nnpz55t6g6KlqxrUsnY6fqTB5aIlx+4++R9RUT1FD7ChtvFu+lalSQS8QPNlLZU/QjnC1XYSJxw/4Htv83/QTwjCB8HxSAWXGEOpbOOLiNW3Ac8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca; spf=pass smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b=csFlK6KM; arc=none smtp.client-ip=209.85.160.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b="csFlK6KM" Received: by mail-qt1-f176.google.com with SMTP id d75a77b69052e-4a6f3f88613so27468821cf.1 for ; Mon, 30 Jun 2025 12:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1751311003; x=1751915803; darn=vger.kernel.org; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=zR6ngs40KDKrfuQ8uGrYMi9KPu0z0Fij7dHU34pFebA=; b=csFlK6KMugkCgLD5u877Qh/Ryzupv9A4ixxm3eViRuOaIv7pQd1UIs/meiACWd6Lv/ nw8W+bNZTCESlbMMmoowu0VP6/8qITcL4zq2ZwPQKLiDBuoI4hTCWJ9u9+OzNLvHA9MQ 5ZKCr6EAHetAcBCt6LIpPK366sBaZ3RwIJzFt3FzJu/u24Bs35aMlFP8ZDGezEDTVKKX sMMWq6N7TJ/gXezfpjE8DK7x5TLpN3qPHrVcwMiZCtcuguQGqFygO2qvx5zsu1p/vowM 2L3dMe8qgRC4kyHDR4z1pk+y4zRdLCZZfnttqCTQzSw5MeD3P7BN5GbQaCRR8rKTpIbd IPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751311003; x=1751915803; h=mime-version:user-agent:autocrypt:references:in-reply-to:date:cc:to :from:subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zR6ngs40KDKrfuQ8uGrYMi9KPu0z0Fij7dHU34pFebA=; b=eIP1hbSn1T8pKqJuDsWwfVKzn+DrnjM8hf+20zfYVUT+MJj4zhY7jBEeNizC8YLau5 jk+DNFXUhd0R5FHaGHXEZewqr2a4gH4T5CmeD++FzlG9xBmKrM6XNzcmabZXdGYJCAHi WhAB5IWCoopO6eSZpxZGSXvnaFWgyvKEuV6rNvrwTnMaxeOT5hJQIE6xtoJk2i+jtPE4 5XMk1fbbuDy6wwp2Z+OeQoYOrAq5ZXbpYgCXuwwwc+4NZnW0zs3hUc2qZ9uOwC/j1mzL b08w78ycmF3PYbxTFVA34iuW/KvoVyeb4Zkt17KqUBqAGWqd/HsLSIJLospE5/CPqXiT XahQ== X-Forwarded-Encrypted: i=1; AJvYcCVW8PJkHs5IRYQTdMQHLgL8PuPJPpWP6SEuoNzLmNngKjC0eDUtZJFl9o8p85Euc8vTTBGrOX5CnfnyGF8=@vger.kernel.org X-Gm-Message-State: AOJu0Yzh/KVWt20QBMGWPnHPilniwdAC2H9FbHDEFJEAyX2UrYqAsHSF tTt2vusWjKrEFuyKmRxGfykPcPJWn9MvMGrZtIVWuyDlMiaNM7vKTyx9C5WaWjf1DNE= X-Gm-Gg: ASbGncs3WZFmuC2wFI6yPORMPaVFtr1iGnEarWLxqe1a3wgrItP7cQq/cWwOmWW7aCl FBxnjCE7RP6IgnmsPRILG5IHNdv33vl0Ex5NsFOy3Kc2Gzfwe0yO5VfSZKlc1a/qpJwKQOol0OU S9GYojYM3/GWs0UULK3XfFlZKYK1Gw6RGvZGrcSVGRTJUIUMqFEPqqn2bqxl9BKrKenjVAN7pGK 7qtY+tZ/gFZehdqQRjseos5iYHlIXMPUiiYHc8HsW6u1/ARV/fITYpLfxgGX2hyZ48EzIz1pIry 7Qw9NU4NFlcRwWfC6KRdBqmAL27ATPXS8X0SNaQDNLx49JLj2da/fNw9KvH9dRoAjfw= X-Google-Smtp-Source: AGHT+IESAXpZrbCN9sq0IGqWEgBIgw7TERMevL4glDJMzoeekiYHSxfwJOAsDJinhURnk5aOEcbJIw== X-Received: by 2002:a05:622a:2611:b0:4a7:14c3:7405 with SMTP id d75a77b69052e-4a7fcbb0be4mr267384891cf.27.1751311002729; Mon, 30 Jun 2025 12:16:42 -0700 (PDT) Received: from ?IPv6:2606:6d00:17:b699::c41? ([2606:6d00:17:b699::c41]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a7fc57d81asm63480201cf.65.2025.06.30.12.16.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 12:16:41 -0700 (PDT) Message-ID: <82be6ca4c33d394fc52fbe2a90362fa6955d0a47.camel@ndufresne.ca> Subject: Re: [PATCH] media: cedrus: Add support for additional output formats From: Nicolas Dufresne To: Paul Kocialkowski , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Hans Verkuil , Jernej Skrabec Date: Mon, 30 Jun 2025 15:16:40 -0400 In-Reply-To: <20250523154359.2454180-1-paulk@sys-base.io> References: <20250523154359.2454180-1-paulk@sys-base.io> Autocrypt: addr=nicolas@ndufresne.ca; prefer-encrypt=mutual; keydata=mDMEaCN2ixYJKwYBBAHaRw8BAQdAM0EHepTful3JOIzcPv6ekHOenE1u0vDG1gdHFrChD /e0MU5pY29sYXMgRHVmcmVzbmUgPG5pY29sYXMuZHVmcmVzbmVAY29sbGFib3JhLmNvbT6ImQQTFg oAQQIbAwULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBO8NUoEVxMPCGgRvEtlBlFEpYHL0BQJ oLLLGBQkJZfd1AAoJENlBlFEpYHL0BEkA/3qkWYt99myYFSmTJUF8UB/7OroEm3vr1HRqXeQe9Qp2 AP0bsoAe6KjEPa/pJfuJ2khrOPPHxvyt/PBNbI5BYcIABLQnTmljb2xhcyBEdWZyZXNuZSA8bmljb 2xhc0BuZHVmcmVzbmUuY2E+iJkEExYKAEECGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AWIQ TvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaCyy+AUJCWX3dQAKCRDZQZRRKWBy9FJ5AQCNy8SX8DpHbLa cy58vgDwyIpB89mok9eWGGejY9mqpRwEAhHzs+/n5xlVlM3bqy1yHnAzJqVwqBE1D0jG0a9V6VQI= Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-PkVzrifhkU38IZasPoP3" User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 --=-PkVzrifhkU38IZasPoP3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Paul, Jernej, Le vendredi 23 mai 2025 =C3=A0 17:43 +0200, Paul Kocialkowski a =C3=A9crit= =C2=A0: > From: Jernej Skrabec >=20 > If VPU supports untiled output, it actually supports several different > YUV 4:2:0 layouts, namely NV12, NV21, YUV420 and YVU420. >=20 > Add support for all of them. >=20 > Signed-off-by: Jernej Skrabec > Reviewed-by: Paul Kocialkowski > --- >=20 > Looks like this patch never made it, sorry about that. > I've rebased it atop media/next and added my Reviewed-by tag. > --- > =C2=A0drivers/staging/media/sunxi/cedrus/cedrus_hw.c | 18 +++++++++++++++= ++- > =C2=A0.../staging/media/sunxi/cedrus/cedrus_video.c=C2=A0 | 18 ++++++++++= ++++++++ > =C2=A02 files changed, 35 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > index 32af0e96e762..168d89c5a16d 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_hw.c > @@ -86,9 +86,25 @@ void cedrus_dst_format_set(struct cedrus_dev *dev, > =C2=A0 > =C2=A0 switch (fmt->pixelformat) { > =C2=A0 case V4L2_PIX_FMT_NV12: > + case V4L2_PIX_FMT_NV21: > + case V4L2_PIX_FMT_YUV420: > + case V4L2_PIX_FMT_YVU420: > =C2=A0 chroma_size =3D ALIGN(width, 16) * ALIGN(height, 16) / 2; > =C2=A0 > - reg =3D VE_PRIMARY_OUT_FMT_NV12; > + switch (fmt->pixelformat) { > + case V4L2_PIX_FMT_NV12: > + reg =3D VE_PRIMARY_OUT_FMT_NV12; > + break; > + case V4L2_PIX_FMT_NV21: > + reg =3D VE_PRIMARY_OUT_FMT_NV21; > + break; > + case V4L2_PIX_FMT_YUV420: > + reg =3D VE_PRIMARY_OUT_FMT_YU12; > + break; > + case V4L2_PIX_FMT_YVU420: Just so its recorded, Hans added a default: case here while applying. regards, Nicolas > + reg =3D VE_PRIMARY_OUT_FMT_YV12; > + break; > + } > =C2=A0 cedrus_write(dev, VE_PRIMARY_OUT_FMT, reg); > =C2=A0 > =C2=A0 reg =3D chroma_size / 2; > diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > index 77f78266f406..9fae2c7493d0 100644 > --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c > @@ -64,6 +64,21 @@ static struct cedrus_format cedrus_formats[] =3D { > =C2=A0 .pixelformat =3D V4L2_PIX_FMT_NV12_32L32, > =C2=A0 .directions =3D CEDRUS_DECODE_DST, > =C2=A0 }, > + { > + .pixelformat =3D V4L2_PIX_FMT_NV21, > + .directions =3D CEDRUS_DECODE_DST, > + .capabilities =3D CEDRUS_CAPABILITY_UNTILED, > + }, > + { > + .pixelformat =3D V4L2_PIX_FMT_YUV420, > + .directions =3D CEDRUS_DECODE_DST, > + .capabilities =3D CEDRUS_CAPABILITY_UNTILED, > + }, > + { > + .pixelformat =3D V4L2_PIX_FMT_YVU420, > + .directions =3D CEDRUS_DECODE_DST, > + .capabilities =3D CEDRUS_CAPABILITY_UNTILED, > + }, > =C2=A0}; > =C2=A0 > =C2=A0#define CEDRUS_FORMATS_COUNT ARRAY_SIZE(cedrus_formats) > @@ -140,6 +155,9 @@ void cedrus_prepare_format(struct v4l2_pix_format > *pix_fmt) > =C2=A0 break; > =C2=A0 > =C2=A0 case V4L2_PIX_FMT_NV12: > + case V4L2_PIX_FMT_NV21: > + case V4L2_PIX_FMT_YUV420: > + case V4L2_PIX_FMT_YVU420: > =C2=A0 /* 16-aligned stride. */ > =C2=A0 bytesperline =3D ALIGN(width, 16); > =C2=A0 --=-PkVzrifhkU38IZasPoP3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTvDVKBFcTDwhoEbxLZQZRRKWBy9AUCaGLimAAKCRDZQZRRKWBy 9PJgAP9YO0WJH/NNq+CaJXSgK9tAYcGlb9/A+rt2u9ac3/xO2QD/SGzZr5aodnIh 3ut2Ast1YM6fTcN+X5020Z2kjtkjGgc= =mibq -----END PGP SIGNATURE----- --=-PkVzrifhkU38IZasPoP3--