From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DEABC433E0 for ; Thu, 9 Jul 2020 10:07:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F014420663 for ; Thu, 9 Jul 2020 10:07:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RY0QX2t2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726688AbgGIKHp (ORCPT ); Thu, 9 Jul 2020 06:07:45 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:46379 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726321AbgGIKHo (ORCPT ); Thu, 9 Jul 2020 06:07:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1594289262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XGzQ4h/xdgSnPNt6v8xNLAT0U2pdFmJEzgSG1Adoozc=; b=RY0QX2t2WUz6p8KA/tLxlSe5PLlqmo3VgsFLSwIkvW3dPCZ8SOvd+LoL3EQAXfHxSmzDxd U4HOW/uZlO0xf7hYfmhvI2psruar/2VGaHpv+z9In01UhnI1eX9+sqCCY0HXk+PRollMPj advSBZJxCxWJ02JGU/+TCWWMz4Z7q04= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-Z5QVYqCrNYSkZ5msYWkEuQ-1; Thu, 09 Jul 2020 06:07:41 -0400 X-MC-Unique: Z5QVYqCrNYSkZ5msYWkEuQ-1 Received: by mail-ej1-f70.google.com with SMTP id q11so2119581eja.3 for ; Thu, 09 Jul 2020 03:07:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XGzQ4h/xdgSnPNt6v8xNLAT0U2pdFmJEzgSG1Adoozc=; b=pty6xPjSnCLEi1UaP/WbbrgcvYQ9BmTfdjI2rprTmZe+hKf8MHpc850mlWeNhHmki7 BjJRdNmq0N2rY6ThT3Fp/VDRCviVSg0UEEJFPY0Vfv2Cs84dXcImFhcGvcgDRyfq2fOX ZVejyJtDwSfoF3rCSyz7BmcxMvEgudVcmgfApTjhSquB8fnVeON5CK2s2qmiq+qorYfH PqH63Me5GqRiRRmJY7+jWD4fDohOZrSXjIROsF7hoSOc6oROHktGTvo8X1FrWrIOpKKH oc5SzkcRGz+ZxI+lVyKZXdpGMntebtly+Py+44iOP/GNKzeZm2wBZSDdW5WE7+alXLPr eJ/g== X-Gm-Message-State: AOAM533u4bF6pOYGBqsPMkm2g0uCCKVUHBQ1fv5dC+kKFmpEg27Mw+Bh WamS2S97bQV9EHjQn4ixbsCMQYNlX83Z6GHcCxSt1u5q34cpKoDakTnIstYSWtxEIonO93XwYGk CNUZMPUlJM4VpemKsfKWxzX5H X-Received: by 2002:a17:906:7250:: with SMTP id n16mr48439745ejk.290.1594289260120; Thu, 09 Jul 2020 03:07:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwNztlPBh26eUmJzhZ9TTEOzcrkZpDS4/OKI+ILiWU7nscSANXIx0rJYN9g290LETLzlahYhQ== X-Received: by 2002:a17:906:7250:: with SMTP id n16mr48439733ejk.290.1594289259929; Thu, 09 Jul 2020 03:07:39 -0700 (PDT) Received: from x1.localdomain (83-84-126-242.cable.dynamic.v4.ziggo.nl. [83.84.126.242]) by smtp.gmail.com with ESMTPSA id b11sm1657097edw.76.2020.07.09.03.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Jul 2020 03:07:39 -0700 (PDT) Subject: Re: [PATCH v4] HID: i2c-hid: Enable wakeup capability from Suspend-to-Idle To: Kai-Heng Feng , jikos@kernel.org, benjamin.tissoires@redhat.com Cc: anthony.wong@canonical.com, You-Sheng Yang , Pavel Balan , Aaron Ma , HungNien Chen , Daniel Playfair Cal , "open list:HID CORE LAYER" , open list References: <20200709075731.5046-1-kai.heng.feng@canonical.com> From: Hans de Goede Message-ID: <82be7198-168f-d174-7cf8-10cd420e0bb6@redhat.com> Date: Thu, 9 Jul 2020 12:05:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200709075731.5046-1-kai.heng.feng@canonical.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 7/9/20 9:57 AM, Kai-Heng Feng wrote: > Many laptops can be woken up from Suspend-to-Idle by touchpad. This is > also the default behavior on other OSes. > > However, if touchpad and touchscreen contact to each other when lid is > closed, wakeup events can be triggered inadventertly. > > So let's disable the wakeup by default, but enable the wakeup capability > so users can enable it at their own discretion. > > Signed-off-by: Kai-Heng Feng Thank you, this version looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > v4: > - Enable the capability, but disable the wakeup default. > > v3: > - Use device_init_wakeup(). > - Wording change. > > v2: > - Fix compile error when ACPI is not enabled. > > drivers/hid/i2c-hid/i2c-hid-core.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c > index 294c84e136d7..c18ca6a6cb3d 100644 > --- a/drivers/hid/i2c-hid/i2c-hid-core.c > +++ b/drivers/hid/i2c-hid/i2c-hid-core.c > @@ -931,6 +931,14 @@ static void i2c_hid_acpi_fix_up_power(struct device *dev) > acpi_device_fix_up_power(adev); > } > > +static void i2c_hid_acpi_enable_wakeup(struct device *dev) > +{ > + if (acpi_gbl_FADT.flags & ACPI_FADT_LOW_POWER_S0) { > + device_set_wakeup_capable(dev, true); > + device_set_wakeup_enable(dev, false); > + } > +} > + > static const struct acpi_device_id i2c_hid_acpi_match[] = { > {"ACPI0C50", 0 }, > {"PNP0C50", 0 }, > @@ -945,6 +953,8 @@ static inline int i2c_hid_acpi_pdata(struct i2c_client *client, > } > > static inline void i2c_hid_acpi_fix_up_power(struct device *dev) {} > + > +static inline void i2c_hid_acpi_enable_wakeup(struct device *dev) {} > #endif > > #ifdef CONFIG_OF > @@ -1072,6 +1082,8 @@ static int i2c_hid_probe(struct i2c_client *client, > > i2c_hid_acpi_fix_up_power(&client->dev); > > + i2c_hid_acpi_enable_wakeup(&client->dev); > + > device_enable_async_suspend(&client->dev); > > /* Make sure there is something at this address */ >