From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E0811EB9FF for ; Mon, 20 Jan 2025 20:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737405281; cv=none; b=Ldtzt/CLVVO0yAN1KCyo4F/paYLwcFTm2gtS83yXW+S5nRETKNgHN1rRfzJ9ARnuECs3VKmq7MZt2tnwNn0jk+SPid63oGEzydqSsuEacvRDQ4BaUJV9woUEcfbiOtJOIwBiH3VmRwl6MPgOLLUwEwZybvT3Sf0yWHXWI1miWs8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737405281; c=relaxed/simple; bh=OFOJaoOKsrGz3gOvyi1JobwerKEkpS1+UhE+6XDb1NQ=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=WsF2NmULPICbHs+Cza9MAZF7LMLgZv1gwoqyOO0xKGNu9ToCiC7A20I9E3QHtUgV1BGG4OaJMBSVOrNURKhJUNWsRA5oS4JAQ9A7usUvTpoMWZxlcklK4Z93fJ1h5RCWIewSlxCK+ajCu0JS1fVj+VIPdD0KMRiYhZ+vnyrB5Ms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=bj/8FsI4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bj/8FsI4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737405278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/RHjUfwmCvBKXS2UvOCBF3DKXMyuVzwXscGRbef9ILg=; b=bj/8FsI4AIj9Z9RXuby1GA2RHcobmet53okbYi3y5RbdInQKNfeqsUmcsBWYHLkZeEEPyU /DHI5Azu7jyxNbu8BqA58uBbNSSB8bn2DApnIj+kNgTWxp1sH7g4WrX1b/KEg2NxSqqQoZ iKgIqz+WxqYAc3oCoAQzf59/NMGiLWw= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-H7rAknZmMoy3M8rHX0A01A-1; Mon, 20 Jan 2025 15:34:35 -0500 X-MC-Unique: H7rAknZmMoy3M8rHX0A01A-1 X-Mimecast-MFC-AGG-ID: H7rAknZmMoy3M8rHX0A01A Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7b6eeef7c38so1017605585a.1 for ; Mon, 20 Jan 2025 12:34:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737405275; x=1738010075; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=/RHjUfwmCvBKXS2UvOCBF3DKXMyuVzwXscGRbef9ILg=; b=R5qkSolxrFJPvGz7yaEbq4dI+aPLPw2nU8gp0RVSsezGMvSXgXS7onsbiNTNBT6rLO NnnljSYgQXY/b5khDVvMJ+cSUnrXKQ2SYvwktr1sOb20HAYqGVrBjkXCoz/v2IfCqUX1 xUaMnPyHgCOFVZDsvvvItrtXvZLFD+0ftmeDUdj/WN+lvwc+qDF1kRtB4qBdMbIPPmw9 KGCTkfHmW+5Q/glfMeAs4BmmFc9I2PMpsmsvN0W3xckhcGZUAKPuKYibShIwRy/XhFgY qw5b/jb95bFWLe83o54CMH/N6Z8qAP8zgFlFYRmp6odx2D6n1ZNqUdm+YCxH6QZF86Fu 5nDQ== X-Forwarded-Encrypted: i=1; AJvYcCWM7yluS5vx/naSY5tvcGoZYQ0L13H+ZkzDSfapKTuSr6yjIrNDZuY0La1vP59Z6II/LUienJrsQyRQLGE=@vger.kernel.org X-Gm-Message-State: AOJu0YxKr4Gnpy3o/kwAHGmwailr1Odztkm/IoltV46q3UpX0fG6sN1O +1gAwuSjskXy8XUFq99D1+RusOMgE6eCoXkZq7IhTfI4FZcQmMt7/wQkmsEp7mg+XLYY4cr7sTQ gnW56I0Dc07A/golfQTA2tnqoV9zilrLn5ENrbXQB9cnF3SCl44MnfhluiLnP0g== X-Gm-Gg: ASbGncuxjSA24Biy+yfJqiuBQNJHvHp32B3ntQNP8m9OES9sx/JQ+zmvB5MwNkgqnCE BSB30SAoKE8jxGVctfiQBfLI7RyYk8joVUgWTT5y60M6I3Jkj8toc9FkD1pFrjZhtsYgjfwewFP WzogEFk9zxX1yzdck5EoLZtoud8E6l2JSGZbpLQhI9Kb4sl4V1fzmzxeFtkmO5808hs8/fmj73E /RKy6Ay1Gnx1HIBJdzZ4QIsRJqld7wOWnbsc44QkECeLPPmALFsE0zdJsDWbVvk3aK41g== X-Received: by 2002:a05:620a:44c4:b0:7b1:52a9:ae1d with SMTP id af79cd13be357-7be631e5789mr2639891985a.6.1737405274901; Mon, 20 Jan 2025 12:34:34 -0800 (PST) X-Google-Smtp-Source: AGHT+IGS8PsgoXeVcEsGYNIKKCi8ACTs7vnBJLtP7ao6C9/luJJa01LBg2l1wcdbDBKQZ4HIL/WcaQ== X-Received: by 2002:a05:620a:44c4:b0:7b1:52a9:ae1d with SMTP id af79cd13be357-7be631e5789mr2639888685a.6.1737405274598; Mon, 20 Jan 2025 12:34:34 -0800 (PST) Received: from starship ([2607:fea8:fc01:8d8d:6adb:55ff:feaa:b156]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7be614d9949sm484869985a.71.2025.01.20.12.34.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2025 12:34:34 -0800 (PST) Message-ID: <82c011752e777eb77b1c988a5bf1114bc991fc44.camel@redhat.com> Subject: Re: [PATCH v2 00/20] KVM: selftests: Fixes and cleanups for dirty_log_test From: Maxim Levitsky To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Xu Date: Mon, 20 Jan 2025 15:34:33 -0500 In-Reply-To: <20250111003004.1235645-1-seanjc@google.com> References: <20250111003004.1235645-1-seanjc@google.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 7bit On Fri, 2025-01-10 at 16:29 -0800, Sean Christopherson wrote: > Fix a variety of flaws and false failures/passes in dirty_log_test, and > drop code/behavior that adds complexity while adding little-to-no benefit. > > Lots of details in the changelogs, and a partial list of complaints[1] in > Maxim's original thread[2]. > > [1] https://lore.kernel.org/all/Z1vR25ylN5m_DRSy@google.com > [2] https://lore.kernel.org/all/20241211193706.469817-1-mlevitsk@redhat.com > > v2: > - Collect reviews. [Maxim] > - Expand a few changelogs to be more explicit about the effects. [Maxim] > - Print the number of writes from each iteration. [Maxim] > - Fix goofs in the last patch (stale message and changelog). [Maxim] > > v1: https://lore.kernel.org/all/20241214010721.2356923-1-seanjc@google.com > > Maxim Levitsky (2): > KVM: selftests: Support multiple write retires in dirty_log_test > KVM: selftests: Limit dirty_log_test's s390x workaround to s390x > > Sean Christopherson (18): > KVM: selftests: Sync dirty_log_test iteration to guest *before* > resuming > KVM: selftests: Drop signal/kick from dirty ring testcase > KVM: selftests: Drop stale srandom() initialization from > dirty_log_test > KVM: selftests: Precisely track number of dirty/clear pages for each > iteration > KVM: selftests: Read per-page value into local var when verifying > dirty_log_test > KVM: selftests: Continuously reap dirty ring while vCPU is running > KVM: selftests: Honor "stop" request in dirty ring test > KVM: selftests: Keep dirty_log_test vCPU in guest until it needs to > stop > KVM: selftests: Post to sem_vcpu_stop if and only if vcpu_stop is true > KVM: selftests: Use continue to handle all "pass" scenarios in > dirty_log_test > KVM: selftests: Print (previous) last_page on dirty page value > mismatch > KVM: selftests: Collect *all* dirty entries in each dirty_log_test > iteration > KVM: sefltests: Verify value of dirty_log_test last page isn't bogus > KVM: selftests: Ensure guest writes min number of pages in > dirty_log_test > KVM: selftests: Tighten checks around prev iter's last dirty page in > ring > KVM: selftests: Set per-iteration variables at the start of each > iteration > KVM: selftests: Fix an off-by-one in the number of dirty_log_test > iterations > KVM: selftests: Allow running a single iteration of dirty_log_test > > tools/testing/selftests/kvm/dirty_log_test.c | 521 +++++++++---------- > 1 file changed, 246 insertions(+), 275 deletions(-) > > > base-commit: 10485c4bc3caad3e93a6a4e99003e8ffffcd826a I don't think I have any major objections to this patch series. Best regards, Maxim Levitsky