mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Carlos Jones <carlosjr.jones@analog.com>
Cc: alexisczezar.torreno@analog.com, conor+dt@kernel.org,
	corbet@lwn.net, devicetree@vger.kernel.org, krzk+dt@kernel.org,
	linux-doc@vger.kernel.org, linux-hwmon@vger.kernel.org,
	linux-kernel@vger.kernel.org, rdunlap@infradead.org,
	robh@kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH 2/2] hwmon: (pmbus/max20830) Add support for MAX20810, MAX20815, LTM4739, LTM4740
Date: Fri, 30 Oct 2026 08:27:54 -0700	[thread overview]
Message-ID: <82c524ad-762f-48ab-b94f-8e1dece2c72a@roeck-us.net> (raw)
In-Reply-To: <20261030100348.1955-1-carlosjr.jones@analog.com>

Hi Carlos,

On 10/30/26 03:03, Carlos Jones wrote:
> From: Carlos Jones Jr <carlosjr.jones@analog.com>
> 
> Hi Guenter,
> 
> Thanks for the review.
> 
>> According to the datasheets, MAX20810 reports "MAX20810", and MAX20815
>> reports "MAX20815". I find no reference to the "B" variants on the
>> Analog Web page.
>>
>> LTM4739, according to its datasheet, reports "LTM4739", and LTM4740
>> reports "LTM4740".
>>
>> Please explain the discrepancy.
> 
> The discrepancy is between the datasheets and what the parts actually store
> in IC_DEVICE_ID (0xAD).
> 
> The LTM4739 and LTM4740 are uModule products built around the MAX20810 and
> MAX20815 dies, respectively. On the hardware I tested, reading IC_DEVICE_ID
> returns the internal MAX die identifier, not the LTM part name:
> 
>      LTM4739 -> "MAX20810B"
>      LTM4740 -> "MAX20815B"
> 
> So the modules report the die's ID (with a "B" die/stepping suffix), which is
> not the string the LTM datasheets currently document. This is a datasheet vs
> silicon mismatch, not a driver choice: the driver matches what the silicon
> actually returns so that probe succeeds on real hardware.
> 
> I only added the IDs I could confirm on hardware (MAX20810B / MAX20815B, as
> reported by the LTM4739 / LTM4740 modules). I deliberately did not add the
> "MAX20810" / "MAX20815" / "LTM4739" / "LTM4740" strings, since no part I have
> reports them. The driver keeps the LTM4739/LTM4740 naming and device-tree
> compatibles for the modules while matching on the MAX die IDs they report.
> 
> I raised this with the product line and a datasheet correction has been
> initiated to document the MAX20810B / MAX20815B IC_DEVICE_ID values.
> 
> If you'd prefer the discrepancy spelled out in-tree, I'm happy to add a note to
> the commit message and a code comment in a v2.
> 

Please do. At the very least we should know what we get into. _If_ parts
do exist which match the current datasheets, it should at least be documented
why those are not matched.

Thanks,
Guenter


      reply	other threads:[~2026-10-30 15:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  5:02 [PATCH 0/2] hwmon: (pmbus/max20830) add MAX20810/15 and LTM4739/40 Carlos Jones Jr
2026-10-26  5:02 ` [PATCH 1/2] dt-bindings: hwmon: max20830: Add MAX20810, MAX20815, LTM4739, LTM4740 Carlos Jones Jr
2026-10-26 19:01   ` Conor Dooley
2026-10-26  5:02 ` [PATCH 2/2] hwmon: (pmbus/max20830) Add support for " Carlos Jones Jr
2026-10-26 14:22   ` Guenter Roeck
2026-10-30 10:03     ` Carlos Jones
2026-10-30 15:27       ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82c524ad-762f-48ab-b94f-8e1dece2c72a@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=alexisczezar.torreno@analog.com \
    --cc=carlosjr.jones@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=robh@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®