From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5242D3921EC for ; Thu, 5 Feb 2026 11:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770290613; cv=none; b=hu/JxaB11V9wDp56ERoNqP+eYuP0yDLm3+ySjA6YmS2wA9eVyC4zjB3I7K9rr7Hu9/wfpFligMob/iBJcycBJOpQnnqeLHtTv8LlNtnYy6muoYLIbVncuu14eBLo2dipWLAte/aOcgoKnq+eHEeOfcjFBHU/A1E4cDn91ipU2+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770290613; c=relaxed/simple; bh=RCZrlJ+4+OMz1hlIGp1AtgJCfStiAxEXsBfE8ZlFXm4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=u9kthwD4WBXChXkUiQdEg4g6AEGT5m2YyVg3leSQOWYtIodLfCGqlHvVLixAB12YjVgHwvETQc2urdHw9rWKrFA+G036egvkBHtUCEO6BeJ5xi6RM/ixBScbXoya+blQYJyoBjF0ON4kcjNxQPv7c4Zu6duRe4P87O4PTZYTmWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WHP1ueEv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WHP1ueEv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5963C4CEF7; Thu, 5 Feb 2026 11:23:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770290613; bh=RCZrlJ+4+OMz1hlIGp1AtgJCfStiAxEXsBfE8ZlFXm4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=WHP1ueEvlWmZb0YitFpYD0Yf9XwX5oZeh5UFQQvcaGXDfwB1W4DZnATxeSRPTNPfh AQXIKoDJ4asL6sXEQgNTqa+5MNxgrZlEPRS0v9VEan5Bm5SpAwTVW/jCPv8qZJnmOf eC41ldcegV5SpTVPaxmhqLOaDSkrL6QCsRXC5cAxa6SUMUft7w5JDBmykJ/1PjkXL4 dDwDqkI6rGz4/2u5oULjmF+qya8tEMBUR7fogc5Ksbz/NDQf4Yv2I95wS6k146moiX jkGGI6zhBUIoRWCl/QSj7huBkBWa694ID2lJFbwm71gevoz84C/VRXnXvCzs3frcB1 rvNwJb8QfUIKA== Message-ID: <82c73122-4d0e-45f5-b1b4-3cf743353fd6@kernel.org> Date: Thu, 5 Feb 2026 12:23:28 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] soc cache: L3 cache driver for HiSilicon SoC To: wangyushan Cc: Arnd Bergmann , Alexandre Belloni , Drew Fustini , Jonathan Cameron , Linus Walleij , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, fanghao11@huawei.com, linuxarm@huawei.com, liuyonglong@huawei.com, prime.zeng@hisilicon.com, Zhou Wang , Wei Xu References: <20260203161843.649417-1-wangyushan12@huawei.com> <20260203161843.649417-2-wangyushan12@huawei.com> <1d7abd11-2064-4437-8ad7-7cfe1b2e75c0@huawei.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <1d7abd11-2064-4437-8ad7-7cfe1b2e75c0@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 05/02/2026 12:19, wangyushan wrote: > > On 2/5/2026 5:37 PM, Krzysztof Kozlowski wrote: >> On 03/02/2026 18:19, Arnd Bergmann wrote: >>> On Tue, Feb 3, 2026, at 17:18, Yushan Wang wrote: >>>> The driver will create a file of `/dev/hisi_l3c` on init, mmap >>>> operations to it will allocate a memory region that is guaranteed to be >>>> placed in L3 cache. >>>> >>>> The driver also provides unmap() to deallocated the locked memory. >>>> >>>> The driver also provides an ioctl interface for user to get cache lock >>>> information, such as lock restrictions and locked sizes. >>>> >>>> Signed-off-by: Yushan Wang >>> >>> Hi Yushan, >>> >>> Thanks for your submission. Since we are in the last week of >>> the merge window, this is not going to be linux-7.0 material, >>> but I'll have a quick look for now. >> >> >> To be clear - this is a v3 but with removed previous history... >> >> Previous version: >> https://lore.kernel.org/all/20251217102357.1730573-2-wangyushan12@huawei.com/ >> >> Or even v4? >> >> https://lore.kernel.org/all/20250122065803.3363926-2-wangyushan12@huawei.com/ >> >> Yushan, please start versioning your patches correctly. Use b4 or git >> format-patch -vx > > Hi Krzysztof, > > Sorry about the confusing versions, the complete history is as below: > > Link to v1: https://lore.kernel.org/all/20250107132907.3521574-1-wangyushan12@huawei.com > > Link to v2: https://lore.kernel.org/all/20250122065803.3363926-1-wangyushan12@huawei.com/ > > Link to RFC v1: https://lore.kernel.org/all/20251125080542.3721829-1-wangyushan12@huawei.com/ > > Link to RFC v2: https://lore.kernel.org/all/20251217102357.1730573-1-wangyushan12@huawei.com/ > > Link to v1 again (this message): https://lore.kernel.org/all/20260203161843.649417-1-wangyushan12@huawei.com/ > >> >> Otherwise, please explain us how can we compare it with `b4 diff` with >> previous version? >> >> Sending something AGAIN as v1 ignoring entire previous submission is >> clear no go. Like you are trying till it succeeds. Negative review? >> Let's try from v1 this time... >> >> This is not correct and it should not be my task to find your previous >> discussions and decipher this v1. > > I did spin 2 versions to mainline as the actual v1, the thread was quiet. > Then I made a major refactor to it and sent it as RFC, the thread went > quiet again but some compile check issues popped up. I spinned 2 > versions of RFC for the compile issues and removed RFC in this version > since no strong objection showed up. > > Apologize that I broke the rules and any inconvenience caused by it. > As there's little discussion in previous patches, is it OK that we start > here as v1? No, it is not okay. Your patchset continues and entire previous feedback and history is important. Otherwise why would I review this if I can as well ignore it and wait for next year you sending another v1? Best regards, Krzysztof