mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ts'o <jojing64@gmail.com>
To: x86@kernel.org, linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	hpa@zytor.com, dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org
Subject: Re: [PATCH] x86/mm: Fix copy&paste error in comments
Date: Thu, 22 Apr 2021 17:29:55 +0800	[thread overview]
Message-ID: <82c81cd7-bced-d533-56f3-1d75c9f4593b@gmail.com> (raw)
In-Reply-To: <20210420053432.4842-1-jojing64@gmail.com>


On 20/4/2021 1:34 pm, Cao jin wrote:
> Direct page mapping in bottom-up way will allocate memory from low
> address for page structures in a range, which is the *bottom*,
> not the *end*.
> 
> Signed-off-by: Cao jin <jojing64@gmail.com>
> ---
>   arch/x86/mm/init.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/init.c b/arch/x86/mm/init.c
> index e26f5c5c6565..bc2f871c75f1 100644
> --- a/arch/x86/mm/init.c
> +++ b/arch/x86/mm/init.c
> @@ -663,7 +663,7 @@ static void __init memory_map_bottom_up(unsigned long map_start,
>   	/*
>   	 * We start from the bottom (@map_start) and go to the top (@map_end).
>   	 * The memblock_find_in_range() gets us a block of RAM from the
> -	 * end of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
> +	 * bottom of RAM in [min_pfn_mapped, max_pfn_mapped) used as new pages
>   	 * for page table.
>   	 */

FYI: There is exactly the same sentence in memory_map_top_down(), looks 
like a copy & paste error to me.

--
Cao jin

      reply	other threads:[~2021-04-22  9:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-20  5:34 Cao jin
2021-04-22  9:29 ` Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82c81cd7-bced-d533-56f3-1d75c9f4593b@gmail.com \
    --to=jojing64@gmail.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®