From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2B46C43334 for ; Tue, 12 Jul 2022 15:17:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233578AbiGLPRu (ORCPT ); Tue, 12 Jul 2022 11:17:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233270AbiGLPRY (ORCPT ); Tue, 12 Jul 2022 11:17:24 -0400 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34EB4CC027 for ; Tue, 12 Jul 2022 08:12:23 -0700 (PDT) Received: by mail-lf1-x130.google.com with SMTP id o7so14441467lfq.9 for ; Tue, 12 Jul 2022 08:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=FiFkU4mtsNMfFIb99Kyl4YKF0xVr8LFESHMNv5yOiro=; b=EQ/TF9qYYwlLAcO2ZviT1k6qc/VqInz5ERRkhyrsBi6dF+xJhJORcGJz7gMRx/PjKl p/C+PwHpO3s1AbBKfptcD8VVn1ui73ew69bGaWVROOf2+pr97zI4T1BDm1VunZL8NJnk f63yaybXdjvzlnkcmKhrRwuX3XiwqaFJ9DKzKKSZEdCCqNp9kuYS+/6QkM1ORYvsfqg2 g4BLvWwKZsWigB5JrPcBZ4bp5aOI1g7OViJTOxiv7JSOrlMGwsaEgckqEMKm+PVXregE MgqoQVQMOZeexN3A/otCm4oZqyhluKsMbpqXBG7HfbH2+2qviyOfRa9MoQ1JYrT/WaIQ sCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=FiFkU4mtsNMfFIb99Kyl4YKF0xVr8LFESHMNv5yOiro=; b=GpAUdhOHPezsYGaSZgeUT2HjvWcTjt2OyMQcJl/OFBLmXWYEajxGBO1CfAj13EpQHS Ozwo77gOKBcZgQIyL1KVLCnWXs2rq6SMEMTf9wFRQcdmK/JZbQPCPQ7t8atiesPxl3j8 7RwScEQpDtoR6jBQEm019Osx2pxFIbSe/3mBw7C4GBuyTCdrbYhCY15OrIssWtykveP8 6ISw+971yq9YwYopBE7OgCXzo/4+oPu66971x/rk+eiods/ydWQ5ZS6XDp3KD+5jV3Qa KS+eOdIlcbPfQF93p0m5vWrRekDLWbDgGHtIDtaxOLXDjFYYmww64iYDDhODvEi41W3h GLbQ== X-Gm-Message-State: AJIora+YzSxE8W8HYLZjvMh8MuU+u+aQB8Y+d4MvMPzWQFrFvLonL8vq UWyjflbwTj4A5M2VePKgpEM4cTa1kOW8kgNm X-Google-Smtp-Source: AGRyM1t0l7x/rCjC6lSD6LEP8zBtApvjhPsSOa6RpcuLkpgzQsIqIo44tpbIn6jIqUtwKONToFV0JQ== X-Received: by 2002:a05:6512:2241:b0:479:6426:15af with SMTP id i1-20020a056512224100b00479642615afmr14829398lfu.631.1657638741569; Tue, 12 Jul 2022 08:12:21 -0700 (PDT) Received: from [10.0.0.8] (fwa5da9-171.bb.online.no. [88.93.169.171]) by smtp.gmail.com with ESMTPSA id c5-20020ac25f65000000b00489dd78bdacsm1388358lfc.299.2022.07.12.08.12.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 08:12:20 -0700 (PDT) Message-ID: <82d4507a-d092-8cb0-2e88-4290661d114d@linaro.org> Date: Tue, 12 Jul 2022 17:12:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] media: dt-bindings: media: i2c: document OV4689 DT bindings Content-Language: en-US To: Mikhail Rudenko , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220712141925.678595-1-mike.rudenko@gmail.com> <20220712141925.678595-2-mike.rudenko@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220712141925.678595-2-mike.rudenko@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/07/2022 16:19, Mikhail Rudenko wrote: > Add device-tree binding documentation for OV4689 image sensor driver, > and the relevant MAINTAINERS entries. > > Signed-off-by: Mikhail Rudenko > --- > .../bindings/media/i2c/ovti,ov4689.yaml | 122 ++++++++++++++++++ > MAINTAINERS | 7 + > 2 files changed, 129 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > > diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > new file mode 100644 > index 000000000000..6bdebe5862b4 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov4689.yaml > @@ -0,0 +1,122 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/i2c/ovti,ov4689.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Omnivision OV4689 CMOS Sensor Device Tree Bindings s/Device Tree Bindings// > + > +maintainers: > + - Mikhail Rudenko > + > +description: |- No need for - > + The Omnivision OV4689 is a high performance, 1/3-inch, 4 megapixel > + image sensor. Ihis chip supports high frame rate speeds up to 90 fps > + at 2688x1520 resolution. It is programmable through an I2C > + interface, and sensor output is sent via 1/2/4 lane MIPI CSI-2 > + connection. > + > +allOf: > + - $ref: /schemas/media/video-interface-devices.yaml# > + > +properties: > + compatible: > + const: ovti,ov4689 > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + description: > + External clock for the sensor. This goes to clocks instead. > + items: > + - const: xclk No need for clock-names for such case. > + > + dovdd-supply: > + description: > + Definition of the regulator used as Digital I/O voltage supply. s/Definition of the regulator used as // It's redundant... > + > + avdd-supply: > + description: > + Definition of the regulator used as Analog voltage supply. Ditto > + > + dvdd-supply: > + description: > + Definition of the regulator used as Digital core voltage supply. Ditto > + > + powerdown-gpios: > + maxItems: 1 > + description: > + Reference to the GPIO connected to the powerdown pin (active low). s/Reference to the// > + > + reset-gpios: > + maxItems: 1 > + description: > + Reference to the GPIO connected to the reset pin (active low). The same. > + > + orientation: true > + > + rotation: true > + > + port: > + $ref: /schemas/graph.yaml#/$defs/port-base > + additionalProperties: false > + description: > + Output port node, single endpoint describing the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: /schemas/media/video-interfaces.yaml# > + unevaluatedProperties: false > + Best regards, Krzysztof