From: Tom Lendacky <thomas.lendacky@amd.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
Borislav Petkov <bp@alien8.de>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>
Subject: Re: [PATCH 0/2] Fixes for recent x86/boot rip-relative addressing changes
Date: Fri, 22 Mar 2024 13:05:45 -0500 [thread overview]
Message-ID: <82d9de6c-a76f-61e9-02bd-f74beb87166e@amd.com> (raw)
In-Reply-To: <CAMj1kXGUZAzBQMzZOsZaYuaGfAn4AHv1FMzZT9vvHCU3aAjcfg@mail.gmail.com>
On 3/22/24 11:10, Ard Biesheuvel wrote:
> On Fri, 22 Mar 2024 at 17:41, Tom Lendacky <thomas.lendacky@amd.com> wrote:
>>
>> This patch series provides fixes for the recent x86/boot rip-relative
>> addressing changes that causes system crashes when booting with 5-level
>> pagetables and SME active.
>>
>> I thought I had tested 5-level paging with SME, but must have missed
>> it. There are two patches to fix the issues that can be squashed into
>> a single patch with multiple Fixes: tags if desired.
>>
>
> Perhaps you tested the entire series, where the final patch removed
> those variables altogether?
Maybe, but that wouldn't explain the first fix in the series. I should've
encountered an issue no matter what. I probably used the wrong config file
or ... who knows at this point.
Thanks,
Tom
>
>> The second patch is sort of a revert, but instead uses the newer
>> RIP_REL_REF() macro instead of reverting the fix and continuing to use
>> the fixup_pointer() support.
>>
>
> Thanks for fixing this.
>
> Series
>
> Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
prev parent reply other threads:[~2024-03-22 18:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 15:41 Tom Lendacky
2024-03-22 15:41 ` [PATCH 1/2] x86/boot/64: Apply encryption mask to 5-level pagetable update Tom Lendacky
2024-03-22 15:41 ` [PATCH 2/2] x86/boot/64: Move 5-level paging global variable assignments back Tom Lendacky
2024-03-22 16:10 ` [PATCH 0/2] Fixes for recent x86/boot rip-relative addressing changes Ard Biesheuvel
2024-03-22 18:05 ` Tom Lendacky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82d9de6c-a76f-61e9-02bd-f74beb87166e@amd.com \
--to=thomas.lendacky@amd.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®