From: Jens Axboe <axboe@fb.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <paolo.valente@linaro.org>,
<osandov@fb.com>
Subject: Re: [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers
Date: Thu, 15 Dec 2016 14:44:17 -0700 [thread overview]
Message-ID: <82dd217d-2631-131a-a006-8b80908bf0ee@fb.com> (raw)
In-Reply-To: <20161215192940.GA29747@vader.dhcp.TheFacebook.com>
On 12/15/2016 12:29 PM, Omar Sandoval wrote:
> Hey, Jens, a couple of minor nits below.
>
> One bigger note: adding the blk_mq_sched_*() helpers and keeping the
> blk_mq_*() helpers that they replaced seems risky. For example,
> blk_mq_free_request() is superseded by blk_mq_sched_put_request(), but
> we kept blk_mq_free_request(). There are definitely some codepaths that
> are still using blk_mq_free_request() that are now wrong
> (__nvme_submit_user_cmd() is the most obvious one I saw).
>
> Can we get rid of the old, non-sched functions? Or maybe even make old
> interface do the sched stuff instead of adding blk_mq_sched_*()?
I fixed this up. blk_mq_free_request() is now what we still use as an
exported interface, and that just calls blk_mq_sched_put_request(). The
old (__)blk_mq_free_request() are now (__)blk_mq_finish_request() and
internal only.
--
Jens Axboe
next prev parent reply other threads:[~2016-12-15 21:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 5:26 [PATCHSET v3] blk-mq scheduling framework Jens Axboe
2016-12-15 5:26 ` [PATCH 1/7] block: move existing elevator ops to union Jens Axboe
2016-12-15 5:26 ` [PATCH 2/7] blk-mq: make mq_ops a const pointer Jens Axboe
2016-12-15 16:23 ` Bart Van Assche
2016-12-15 5:26 ` [PATCH 3/7] block: move rq_ioc() to blk.h Jens Axboe
2016-12-15 5:26 ` [PATCH 4/7] blk-mq: export some helpers we need to the scheduling framework Jens Axboe
2016-12-15 5:26 ` [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers Jens Axboe
2016-12-15 19:29 ` Omar Sandoval
2016-12-15 20:14 ` Jens Axboe
2016-12-15 21:44 ` Jens Axboe [this message]
2016-12-15 5:26 ` [PATCH 6/7] mq-deadline: add blk-mq adaptation of the deadline IO scheduler Jens Axboe
2016-12-15 5:26 ` [PATCH 7/7] blk-mq-sched: allow setting of default " Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2016-12-08 20:13 [PATCHSET/RFC v2] blk-mq scheduling framework Jens Axboe
2016-12-08 20:13 ` [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers Jens Axboe
2016-12-13 13:56 ` Bart Van Assche
2016-12-13 15:14 ` Jens Axboe
2016-12-14 10:31 ` Bart Van Assche
2016-12-14 15:05 ` Jens Axboe
2016-12-13 14:29 ` Bart Van Assche
2016-12-13 15:20 ` Jens Axboe
2016-12-07 23:09 [PATCHSET/RFC] blk-mq scheduling framework Jens Axboe
2016-12-07 23:09 ` [PATCH 5/7] blk-mq-sched: add framework for MQ capable IO schedulers Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82dd217d-2631-131a-a006-8b80908bf0ee@fb.com \
--to=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=osandov@osandov.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®