From: "Parag Warudkar" <parag.warudkar@gmail.com>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org,
"Arjan van de Ven" <arjan@linux.intel.com>
Subject: Re: [PATCH] e1000: Use deferrable timer for watchdog
Date: Wed, 19 Dec 2007 14:39:25 -0500 [thread overview]
Message-ID: <82e4877d0712191139k4dbae463icf2a59c8c0104010@mail.gmail.com> (raw)
In-Reply-To: <47696AC9.90204@intel.com>
On 12/19/07, Kok, Auke <auke-jan.h.kok@intel.com> wrote:
[snip]
> I can't possibly see any benefit from this other than that you just add up to a
> whole second to the initialization cycle, which is bad.
>
Well, Ok but it can't be bad - I've been using this patch sometime and
haven't seen any problem at all and powertop shows it reduces the
wakeups-from-idle.
But whatever - no big deal since it already uses round_jiffies().
Parag
> >
> > Signed-off-by: Parag Warudkar <parag.warudkar@gmail.com>
> >
> > --- linux-2.6/drivers/net/e1000/e1000_main.c 2007-12-07
> > 10:04:39.000000000 -0500
> > +++ linux-2.6-work/drivers/net/e1000/e1000_main.c 2007-12-18
> > 20:38:38.000000000 -0500
> > @@ -1030,7 +1030,7 @@
> > adapter->tx_fifo_stall_timer.function = &e1000_82547_tx_fifo_stall;
> > adapter->tx_fifo_stall_timer.data = (unsigned long) adapter;
> >
> > - init_timer(&adapter->watchdog_timer);
> > + init_timer_deferrable(&adapter->watchdog_timer);
> > adapter->watchdog_timer.function = &e1000_watchdog;
> > adapter->watchdog_timer.data = (unsigned long) adapter;
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2007-12-19 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 1:46 Parag Warudkar
2007-12-19 19:02 ` Kok, Auke
2007-12-19 19:39 ` Parag Warudkar [this message]
2007-12-19 21:38 ` Kok, Auke
2007-12-19 22:35 ` Parag Warudkar
2007-12-19 23:00 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82e4877d0712191139k4dbae463icf2a59c8c0104010@mail.gmail.com \
--to=parag.warudkar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=auke-jan.h.kok@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®