mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: Bhargava Marreddy <bhargava.marreddy@broadcom.com>,
	<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
	<pabeni@redhat.com>, <andrew+netdev@lunn.ch>, <horms@kernel.org>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<michael.chan@broadcom.com>, <pavan.chebbi@broadcom.com>,
	<vsrama-krishna.nemani@broadcom.com>, <vikas.gupta@broadcom.com>
Subject: Re: [PATCH net 0/4] bnge: Fix error-path and IRQ setup bugs in probe/open
Date: Mon, 5 Oct 2026 14:57:06 +0200	[thread overview]
Message-ID: <82e50484-fcfe-47a1-bfc6-ba78a935b375@intel.com> (raw)
In-Reply-To: <20261005121704.227866-1-bhargava.marreddy@broadcom.com>

On 10/5/26 2:17 PM, Bhargava Marreddy wrote:
> Four independent fixes for existing bugs in the bnge driver's probe/open
> path:
> 
>   [1/4] Unwind bnge_alloc_core() incrementally to avoid a NULL deref when an
>         allocation fails.
>   [2/4] Require aux_msix + min vectors so nq_nr_rings cannot end up 0.
>   [3/4] Treat an irq_set_affinity_hint() failure as a warning, not an open
>         failure.
>   [4/4] Clear bd->netdev when bnge_netdev_alloc() fails so it does not
>         point at a freed net_device.
> 
> Bhargava Marreddy (4):
>    bnge: fix NULL deref in bnge_alloc_core() on failure
>    bnge: require NQ vectors beyond aux reservation
>    bnge: do not fail open if IRQ affinity hint fails
>    bnge: clear bd->netdev on allocation failure
> 
>   .../net/ethernet/broadcom/bnge/bnge_netdev.c  | 51 +++++++++++++------
>   .../net/ethernet/broadcom/bnge/bnge_resc.c    |  2 +-
>   2 files changed, 37 insertions(+), 16 deletions(-)
> 

nothing controversial,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>

  parent reply	other threads:[~2026-10-05 12:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 12:17 Bhargava Marreddy
2026-10-05 12:17 ` [PATCH net 1/4] bnge: fix NULL deref in bnge_alloc_core() on failure Bhargava Marreddy
2026-10-05 12:17 ` [PATCH net 2/4] bnge: require NQ vectors beyond aux reservation Bhargava Marreddy
2026-10-05 12:17 ` [PATCH net 3/4] bnge: do not fail open if IRQ affinity hint fails Bhargava Marreddy
2026-10-05 12:17 ` [PATCH net 4/4] bnge: clear bd->netdev on allocation failure Bhargava Marreddy
2026-10-05 12:23 ` [PATCH net 0/4] bnge: Fix error-path and IRQ setup bugs in probe/open netdev-bot+sinfo
2026-10-05 12:42   ` Bhargava Chenna Marreddy
2026-10-05 12:57 ` Przemek Kitszel [this message]
2026-10-07  1:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82e50484-fcfe-47a1-bfc6-ba78a935b375@intel.com \
    --to=przemyslaw.kitszel@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=bhargava.marreddy@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=vikas.gupta@broadcom.com \
    --cc=vsrama-krishna.nemani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®