From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DF93290DC for ; Thu, 28 May 2026 07:35:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779953720; cv=none; b=ALep2Fro9YZYZdRPF9ux5WZ56enLWUhqLsaQx0E9lDYrQsvq02NfqwQY1ERUUJkEHbnT8ZbZl+2cikieuxqIv2/qI386r4IeZ6cc+EneKfuJDnhkKNL80iwjQXbu19bmuWffJXSIZDlbvIJpVIaaEzUeGiP7gEVSgc8DIM3NB3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779953720; c=relaxed/simple; bh=yKvxRgnqj+cPB2NT7vHuSgXoU5NU2Q1X/nX2Q9+oabk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LvKeB6AeDKLl5PPWaTTpse2wDL2Oqbv0mIVwcqAp0c6maPEtqYkpwO7Elp1A7ktjuFhS4yyiRU2BgFSdUzTMnfrAlXrVAJAE3PV75XK5LkRneMlF/a2D/BLMynPAQEd0OBbv4UEodrqb6goDwYdk5KtqZn1rkuHK3zXL+QxRptY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QmttyIII; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Eu0wwtHv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QmttyIII"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Eu0wwtHv" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64S6rag32463985 for ; Thu, 28 May 2026 07:35:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7X1Bngct7YO4BzT4ZQN0OEh1vv2g5/BKavf/V01QcBk=; b=QmttyIII6NDbEJ4Y jv6YMiyCgL3C06GKtOZkG1ejil935jwmnv9GA3d4lyhL22/JD5SKB+JuqqaoxGV/ d5Iighy14LnEBqTCsB9SUNR+sUwZEiJqqgDKd7w4sX+gN2eo6FLGjafGTbQofGvp eIcPoFvnPftTZY68pSNmlon0yWcTl5KHcSndJkIfwlZkOYpCfkEIOPZVCnNJcX5K 21YdFcaroPpV72g5z9NOX215/m1IAaNKc/5xM27LLS8hXQlfimX0mz4kGHRbvdMj /C8OKFlBL8h9xbUg8q2dSD310Qc3Ih5lkCjDQuQoxu9I2gINvLCw/J2Ov+rjl1Um bx4zvA== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ee7y4sscn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 28 May 2026 07:35:18 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-837cc5bc6deso8382918b3a.3 for ; Thu, 28 May 2026 00:35:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779953717; x=1780558517; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7X1Bngct7YO4BzT4ZQN0OEh1vv2g5/BKavf/V01QcBk=; b=Eu0wwtHvBWNAYhBYYGnAzTqvFdd9GpPkUtSvvKUf2npl3NJ4FXoO9YPdw8VaN4BnJx 9INQMmdOUU4GiNWLox+2rqdr/Vv6r3lJZUGpC9hq9Hxn64F0J3YAlxatsFy0kclnH9Cl DYT2vl4A3YZ5QIKbHbo2E1ywHDu0RT8KsRjlooUoRQ+0XgFfUtCGLP7vIgmKtk/r2JD4 ZPkD8zh0s5C1Eq5oH8TOiI3rLtGArbeDbEIJ8BFdlAbEhiTIir/BGTmE+VEmLRlcKQ+a ZCxd4RTEyPwHvq044n3+E041JqIRdF5CnfZNVLtaHLUu264ykkn9us8nyZsXIf317v0c tlEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779953717; x=1780558517; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7X1Bngct7YO4BzT4ZQN0OEh1vv2g5/BKavf/V01QcBk=; b=btYw3M4qvd7+G9/b8aKX/M0ZwDBeZU9b5xMeG4fUDvzDpTbd6SBzJckr5ZM0huMm6X L0ailTiRPwaVX2Ah9kExJ9n1bJYc9clla6IVwpHf9/P4gZKbmxv4xRUdTZT8eO4nT7At 7tsUUiMj+SWZPkQ7I2CzP/DksX2FoHN+Vs7svFczzot1f0o2BECZJsghYk8W8bhaPrqF D9PqFSEOk+/m9dAe650R3C0XsJ8IEnGcc9BpKk16p28qxZ2UVB6zedseywcefYGA4ta7 GZTZg7H0tUTSS1fS4YepmMIj2EV6sbpm+F9Z/vHAmoHXx+TU5tOI/6qT10ss2T2RsCj1 y+4w== X-Forwarded-Encrypted: i=1; AFNElJ8FuxySQ5YNQOOSQ6cQQ2ZyW3hRsOyRqET3KitJ2pGHq/c2QqMit2C1ZH6CRAPnE8KVdQvfflluVQv8M/4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDFNdug6aDHUUK67zAMNkciqIUB3sUK2wvMe9/S3yuIemg+hSQ BgcEmh+ZYk2Y3P20dNds0h7bnc7CezwRH5BTiZVgV/XX/Ln5i5aXg156vwXd6jCiWRE261eCnvN tGMvmBAOlfZtAvGIAFdsrXuVzd4d0Vv4u7tt3YaizvrNXY6SYS43vJCt7WyldIZP7QnQ= X-Gm-Gg: Acq92OEbK4R1TrRtjf4E07yPkdtYcVljNqvw6kcsBmxjvAP7waihn+jGNdVZ9cheUwA O4AkSpYecmWWGhpAJO5m6to4lSibo0SU1JCcFtZbxYRtwLLJ19G3KgIy8uaZ79M/JsgH2yJIg8Q nQBMGtgwKYKovwcZxGZb4LxFgs/UyI2ickHSnOoRQX8Ala7DWh0QavHju+PGUWOV2iF7niWKnmN uRgztjJUj2vSgOjfkox3oI9I+XyFGhcOVdW+m2Mjnd7uG96qD18fqCf6INDuEhL/TUWHyQC5Upv FMWhCJvUK1CUQ/fP/bNalv0SgVSNmXz0aJ1MLLwjKR/eBDJCcD9M6/2n9LsAxeXXA+C8UWPNZki grBpITGZ0fy4aeRya78dWbpZGe8KNswImyzldEDcEadD18BFssVicJpd2v2O+KQSENtv5TL+47i AwlSLFv2eccYp1TcmMetBcQkN9VwFC X-Received: by 2002:a05:6a00:ad02:b0:829:8c08:d1f4 with SMTP id d2e1a72fcca58-8415f546346mr26231500b3a.39.1779953717489; Thu, 28 May 2026 00:35:17 -0700 (PDT) X-Received: by 2002:a05:6a00:ad02:b0:829:8c08:d1f4 with SMTP id d2e1a72fcca58-8415f546346mr26231479b3a.39.1779953717012; Thu, 28 May 2026 00:35:17 -0700 (PDT) Received: from [10.133.33.21] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-841d6e806e0sm5056859b3a.7.2026.05.28.00.35.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 May 2026 00:35:16 -0700 (PDT) Message-ID: <82e84f2a-8978-4b24-b355-e46d1a002a57@oss.qualcomm.com> Date: Thu, 28 May 2026 15:35:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath12k: allow peer_id 0 in dp peer lookup To: Hangtian Zhu , jjohnson@kernel.org Cc: ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260512025732.1297849-1-hangtian.zhu@oss.qualcomm.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260512025732.1297849-1-hangtian.zhu@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI4MDA3NCBTYWx0ZWRfX0MUz3QqEUdfu 1uyT97YUOyXcG5GRjtnEj7ju7y3aU+3oOCblnlflf8wt7YXAiTvAtz440ok3BfNUIPYz0eLVyC7 rIkEqgjdoBrO4jKHJBFq+Vxl6I16xhdoCZ3vYXX6rcgaqwzlSstm5nRBY/1fPpbsbQpYjVMaL8R SQsRzUZxRdNpG7121JhokE2wsvZIvraz7kDMJlJa5dWUv5k90W/HmDp6Gd+5QmaAs3wQnFjHYCH ZCoaT61aZVH9nmCB5yMQUrg9rYv0QGu7bG2mtaIY5Go3YYrVIW+O73tC2jafd+sVsYjVTj1jWBH MOOCbbYAvywvmhCMFckxIiq3Kq40O/B6T/EFG/J/lItrzToDuNyXXmsj1ucgEePH3ogQUTfhKIX /Mk+NTCX2gQNvxhULWhcpFYv79APKWb8E+iS+QEbE+0AAwqD9Hhn6wS5Hgz3RaUVErC5TU7K2Al tvTCuBYAMkd1prq921w== X-Authority-Analysis: v=2.4 cv=feidDUQF c=1 sm=1 tr=0 ts=6a17f036 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=SnksKqQ5Byg3HTYQ0yEA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-GUID: 1H6fPJtsNmHNmwfqv4G4JFqAl5gPj83g X-Proofpoint-ORIG-GUID: 1H6fPJtsNmHNmwfqv4G4JFqAl5gPj83g X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-05-28_02,2026-05-26_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 priorityscore=1501 phishscore=0 suspectscore=0 bulkscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2605280074 On 5/12/2026 10:57 AM, Hangtian Zhu wrote: > For some chipsets, firmware can report HTT_T2H_MSG_TYPE_PEER_MAP2 with > peer_id 0 as a valid value for mapping ath12k_dp_link_peer to > ath12k_dp_peer. > > ath12k_dp_peer_find_by_peerid() currently treats peer_id 0 as invalid. > When firmware assigns peer_id 0, peer lookup fails. As a result, > DHCP OFFER packets are dropped in __ieee80211_rx_handle_packet() > because pubsta is NULL. > > ath12k_dp_rx_deliver_msdu() <- rx_info->peer_id 0 > ath12k_dp_peer_find_by_peerid -> peer NULL > ieee80211_rx_napi <- pubsta NULL > ieee80211_rx_list > __ieee80211_rx_handle_packet <- pubsta NULL, skb undelivered > > The following error in the TX completion path is caused by the same issue: > > ath12k_wifi7_pci 0000:04:00.0: dp_tx: failed to find the peer with peer_id 0 > > The error message is triggered by: > ath12k_wifi7_dp_tx_complete_msdu > ath12k_dp_link_peer_find_by_peerid <- ts->peer_id 0 > ath12k_dp_peer_find_by_peerid -> peer NULL > > ath12k_dp_tx_htt_tx_complete_buf > ath12k_dp_link_peer_find_by_peerid <- peer_id 0 > ath12k_dp_peer_find_by_peerid -> peer NULL > > Fix this by allowing peer_id 0 in ath12k_dp_peer_find_by_peerid() and > rejecting only values >= ATH12K_DP_PEER_ID_INVALID. > > Also update peer_id 0 handling in monitor path: > Always call ath12k_dp_link_peer_find_by_peerid() in > ath12k_dp_rx_h_find_link_peer() to fetch the peer, including when > peer_id is 0. > Always store peer_id in ppdu_info->peer_id in > ath12k_wifi7_dp_mon_rx_parse_status_tlv(), including peer_id 0. > > Tested-on: QCC2072 hw1.0 PCI WLAN.COL.1.0.c2-00074-QCACOLSWPL_V1_TO_SILICONZ-1 > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.1.c7-00108-QCAHMTSWPL_V1.0_V2.0_SILICONZ_UPSTREAM-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.6-01243-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Hangtian Zhu Reviewed-by: Baochen Qiang