mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Julien Panis <jpanis@baylibre.com>
To: William Breathitt Gray <william.gray@linaro.org>,
	linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, mranostay@ti.com,
	fabien.lahoudere@collabora.com, gwendal@chromium.org,
	enric.balletbo@collabora.com, bleung@chromium.org,
	groeck@chromium.org, jic23@kernel.org, david@lechnology.com,
	robertcnelson@gmail.com
Subject: Re: [RFC PATCH 2/2] counter: Introduce the COUNTER_COMP_ARRAY_U64 component type
Date: Tue, 6 Sep 2022 16:41:16 +0200	[thread overview]
Message-ID: <82ec09fd-a940-cae6-f793-1bb903190664@baylibre.com> (raw)
In-Reply-To: <31a35481813ec26949018888253278a634998a92.1661785438.git.william.gray@linaro.org>



On 29/08/2022 17:17, William Breathitt Gray wrote:
> The COUNTER_COMP_ARRAY_U64 Counter component type is introduced to
> enable support for Counter array components. With Counter array
> components, exposure for buffers on counter devices can be defined via
> new Counter array component macros. This should simplify code for driver
> authors who would otherwise need to define individual Counter components
> for each array element.
>
> Three Counter array component macros are introduced::
>
>          COUNTER_COMP_DEVICE_ARRAY_U64(_name, _read, _write, _length)
>          COUNTER_COMP_COUNT_ARRAY_U64(_name, _read, _write, _length)
>          COUNTER_COMP_SIGNAL_ARRAY_U64(_name, _read, _write, _length)

Hi William,

I have 2 comments :

1) What about ENUM ? I guess that it will not be possible to handle 
ARRAY of ENUM ?
     That would be useful for polarity0/1/2/3 in my ECAP driver
     (something like COUNTER_COMP_SIGNAL_ARRAY_ENUM for instance)

2) I made some tests with COUNTER_COMP_COUNT_ARRAY_U64
         COUNTER_COMP_COUNT_ARRAY_U64("capture", ecap_cnt_cap_read, 
NULL, ECAP_NB_CEVT)
     I can get consistent data value when using 'cat captureX' linux 
commands.
     But I get weird values when using watches from userspace 
application code (I will send my test results to you).

Julien Panis

  reply	other threads:[~2022-09-06 15:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-29 15:17 [RFC PATCH 0/2] Add support for Counter array components William Breathitt Gray
2022-08-29 15:17 ` [RFC PATCH 1/2] counter: Consolidate Counter extension sysfs attribute creation William Breathitt Gray
2022-08-29 15:17 ` [RFC PATCH 2/2] counter: Introduce the COUNTER_COMP_ARRAY_U64 component type William Breathitt Gray
2022-09-06 14:41   ` Julien Panis [this message]
2022-09-10 23:40     ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82ec09fd-a940-cae6-f793-1bb903190664@baylibre.com \
    --to=jpanis@baylibre.com \
    --cc=bleung@chromium.org \
    --cc=david@lechnology.com \
    --cc=enric.balletbo@collabora.com \
    --cc=fabien.lahoudere@collabora.com \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mranostay@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=william.gray@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®