From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79C643B95F9 for ; Wed, 8 Apr 2026 12:02:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775649747; cv=none; b=liQLshzF1cwMgP0C4QITW9yoG2xnhYQ1mZDTarC0PwgCccVe8vyYpQKjmebzk61yQ1rXEzz+JhIKX3Xds4C/cIe2/r9ZtsYfPcutaiAjp3YXti8bjEwZ7+w3hABtfMmBTuZt5Ncqouh+bHAGJvZP6atzzKCHNeNsI3/7Uvg/Tdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775649747; c=relaxed/simple; bh=OB1EJTI3OjTKytPUQyznROmSRXazcnBRHOjCCFirnGI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pl9HWi+oqiClReboOI5CHsvf3gjPK16UjkbyLbKjBYc8tkFi8afeZ69FGTbtJoEcVgcXKuon2K3FFMG58ipdN2sgLgMtOKqheYz7xSyXZUxnnI+Fc3f1hrpdOpm/VmhwYbk8yJLMHuADQIaRpYZmZC0n+9vZtNMN6fRTRBVfj1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nSBWWy4o; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nSBWWy4o" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82cef263bedso2824682b3a.0 for ; Wed, 08 Apr 2026 05:02:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775649746; x=1776254546; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LvwUSoCp81ob7OZ/uiYdZqYepJJ6XzLLo7Vd69vn/eY=; b=nSBWWy4o8LbJEzo7J319Af518mY+skjgXHS2XbW5PYBgpvDpZjP4SbMTHMh1uyiL35 D5XA4rTeIInWVKKJq7Vt76N4XK1El3dckNrhaB1U2fK3e313kiPmsuNfz1N7xFDvs1Z5 XaxCEDWKQAsIVuHdlFQDdkjAn09r87OKxYEyB6JVpxaY4tS4L51ilpzDFNtMHUxA4+rv /cA2OMNdZGimQ0/GC688SIfcnKbBNnx4TSqIAKv+nB+PaRzaAdScdUWK53Bsr78A0X2s /ug10ZAVDAfscrB6XEJrLzSqLuaCHy42DT3Wcu8shZjkP6jBojLAGSUNKOrkKFYzigkN kXLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775649746; x=1776254546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=LvwUSoCp81ob7OZ/uiYdZqYepJJ6XzLLo7Vd69vn/eY=; b=R1FTA1PLpgSK5sJ/2EIyx624NCwbSmGEfypFkGfr8gZLJ+70Mr1eOugO2hzFx8ZZN8 8fPcjdfqezbta9A7D/9XSeGl0B3Oz5n7BOoSrSgK9pSxOgCwrjA1TLHeLzQcVhf/VCsf DtKYqmVoxCd/T81ZSA/vbnmylDOK3JaFmxFNlmw4KahJFstXyTMppoBHERbzs/2Dwcyv raocwuvVEf0CsoOaONXUkEXc2YY0VZWfq+o3lp9LZH/JTLMvzdiS9tkEUjvyTc2lU/af BSATnnTouHqjhEihXdnFUD0tpBzplAUyIU8tKfoY1bwSUvhCgS4gubkUCClW2QFhl8WK xqYw== X-Forwarded-Encrypted: i=1; AJvYcCUIexJIk7+6VrsHckMElsKTthPx25wtnOqOmv8kvQoz2t8qCUpMISVJR2LE2rY6M9bzc04wzgQWJGeiXPs=@vger.kernel.org X-Gm-Message-State: AOJu0YwgXpTowkZ8IFewWReBJladCWNPt/ZpU4LjXBgnqioBZVdqKnEW FsQ+2LKnhJW61ZRcS+dJjnoVlV31Gd1jjoA9lSvK4Zu9PkxGG33QGN36 X-Gm-Gg: AeBDietY8cHWkLICjT7CLht3wtB+xacQZ7qN94EnnSL1RBarBf419sQoog60HUldNM+ NNXWTMgm6sVyBIOmkF0XJa4N10WkkPo1NNgTbR78M4bv4NqOldtxYwgXHwj/rMw0BFiKMpw7kkM TwrbsrjYUVPX7oCjlK68Tf+KlhxgFEuSyzVvcgIcGk6VMdpRNuW0XG4G2jiefnUmIsZDB3+4aKe K+yyxAOxqgKR9V3PpRvUrQmH6KzRwgd89h8lqtE7Sv3jaMNtRB8I8FnaAf2kQyEJaWYtYTLxC3F v/APh2UVwGa1Ulw7rcaPgkISIWzAe4XV6oRIiy+JAPp15gIq0d1EJj1sMXtfv2EBt4VfIc27+GC 3pLtLJfJivqt99ggXFWaIOdhWRI9OmUXIEe4/s/Ik7VIkQM9+Ux7MaUv+QfFCfSxHWI8xB/WSkD o8CLVe3rnQO+HU3SEHjTK30/vqKlbM1cnNkVsDz2BRwESo X-Received: by 2002:a05:6a00:6ca8:b0:82c:ae58:46ad with SMTP id d2e1a72fcca58-82d0dbc813emr20521123b3a.51.1775649745709; Wed, 08 Apr 2026 05:02:25 -0700 (PDT) Received: from Mac.localdomain ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b3e169sm21209322b3a.18.2026.04.08.05.02.22 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 08 Apr 2026 05:02:24 -0700 (PDT) From: "Ritesh Harjani (IBM)" To: linuxppc-dev@lists.ozlabs.org, Haren Myneni Cc: Madhavan Srinivasan , Christophe Leroy , Venkat Rao Bagalkote , Nicholas Piggin , linux-kernel@vger.kernel.org, "Ritesh Harjani (IBM)" Subject: [RFC v2 08/10] pseries/papr-hvpipe: Simplify error handling in papr_hvpipe_init() Date: Wed, 8 Apr 2026 17:31:38 +0530 Message-ID: <82eca9775d5c66104d7499aa877841cd89d5731d.1775648406.git.ritesh.list@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Remove such 3 levels of nesting patterns to check success return values from function calls. ret = enable_hvpipe_IRQ() if (!ret) ret = set_hvpipe_sys_param(1) if (!ret) ret = misc_register() Instead just bail out to "out*:" labels, in case of any error. This simplifies the init flow. Signed-off-by: Ritesh Harjani (IBM) --- arch/powerpc/platforms/pseries/papr-hvpipe.c | 26 +++++++++++--------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/arch/powerpc/platforms/pseries/papr-hvpipe.c b/arch/powerpc/platforms/pseries/papr-hvpipe.c index ac2c4b42b373..5d04d1fa4370 100644 --- a/arch/powerpc/platforms/pseries/papr-hvpipe.c +++ b/arch/powerpc/platforms/pseries/papr-hvpipe.c @@ -783,23 +783,27 @@ static int __init papr_hvpipe_init(void) } ret = enable_hvpipe_IRQ(); - if (!ret) { - ret = set_hvpipe_sys_param(1); - if (!ret) - ret = misc_register(&papr_hvpipe_dev); - } + if (ret) + goto out_wq; - if (!ret) { - pr_info("hvpipe feature is enabled\n"); - hvpipe_feature = true; - return 0; - } + ret = set_hvpipe_sys_param(1); + if (ret) + goto out_wq; - pr_err("hvpipe feature is not enabled %d\n", ret); + ret = misc_register(&papr_hvpipe_dev); + if (ret) + goto out_wq; + + pr_info("hvpipe feature is enabled\n"); + hvpipe_feature = true; + return 0; + +out_wq: destroy_workqueue(papr_hvpipe_wq); out: kfree(papr_hvpipe_work); papr_hvpipe_work = NULL; + pr_err("hvpipe feature is not enabled %d\n", ret); return ret; } machine_device_initcall(pseries, papr_hvpipe_init); -- 2.39.5