From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 894D1322B84 for ; Wed, 14 Jan 2026 07:12:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768374768; cv=none; b=rsnmy//HBKwP5lEZd+7jI8ujpZTUpcvajmHoA1OVz6DXYjxhtRM1o3Wli5R+hksSNfwnRZ5XHiy2310Nt3mUu6s6d1GxGrcNSuGJ78BRHOkw4Nzxicrh4t6FvDYS8YE9gI7FYUzrT8uaseRp13+noeYL1rQL/5HU2sijUE7/8vA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768374768; c=relaxed/simple; bh=aaEOElibCQ3t/A6Z0q9Al1Bga6nizTCAT/PF0vkpmps=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=sHzTjr5Rqbnd+Tkgbsx6EEqZYkBDB5H5mifjBsJuD8O3pfPOhJU2c69I/p5rCyHr+Fxdzt6pv7u9ERcuo4ThXxsZ0vTX+GVVpi55aEevjnNmfroCFGTr7jLTZGcWWHHZOkwgykOiCRs+ktRFUR5WaGnw+lBf47vgyW0Vt+Cl2Wc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=CYCGXGCX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZPjFvvpj; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="CYCGXGCX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZPjFvvpj" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60E66PcI1689510 for ; Wed, 14 Jan 2026 07:12:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Fq4a38fiWnx2ftPjHIPdlFRol4VhEcllxEgvdPr2E2A=; b=CYCGXGCXwtBGAyv4 ZbtZWa5OLlMJxC3Wmi9roBToVjfhdOnA6LlX10cPNqohCnu0wJnG+FlnMtAg6ucH l2alwITHDMLsxWM2hN0OHk3CM0srY6hvxXau2TJA2lWl3vzvOYzXwj8iMGjPlgHA EBABpf/7G7z7HytjIor/TBm18e58ekPD5DpX9cmQ3J6fzGTHnx6zXM8agkhNWP4r MKPLWm/sAfs4DV6UTVwz4PSewnfAAgG0Y9rU7tCE0RR6QMTlEIG7TpBl7l7DJzvf WIWUHB0pNIe1C7III50BqKA58bYOSvXQCqWLhJG3b870B5a4BXv8u4mlgY80doj4 0mVb6A== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bnsybahsx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 14 Jan 2026 07:12:37 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-29f8e6a5de4so79993955ad.2 for ; Tue, 13 Jan 2026 23:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768374757; x=1768979557; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fq4a38fiWnx2ftPjHIPdlFRol4VhEcllxEgvdPr2E2A=; b=ZPjFvvpjtVJGkRuwtZe1aXqm5BmAR+hD/37186tCZKw5tiJxsWYmKE8zX1TAh/gqZr y1hH88l6ahHFXe9/jO/WfRssJVVbbV3pK4+hnrL/3SWR5snAvhTG9K9d4/13rBAdArqO +flEUD+cLrUhls7gXx6xNig8q0H5XSMHya+MyiY3tIFAdqelT5UZA+bGBsCWUVA1yjNz 6HyxTTFUkXP7RRwqAegqD+TCQX0irVXCtcotDUfdnNUUFk6fIXzQilSBMXxcwiZe3pro yT1lkIEWPF+E3GzElrsrHp30+BSjBxWO32rpb7cnRTJh5SO+R3n6hl4TOlxOA/dqF5TE W9iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768374757; x=1768979557; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fq4a38fiWnx2ftPjHIPdlFRol4VhEcllxEgvdPr2E2A=; b=PtYI6HclpokdY43wwa+t4+poTvHGy9BUX4SY1nJR5GVFRen0IDgUbG3kOIJq2BIp8O 9C8VOTelHyXlFUXU6dKsf9q5gpsxvEeRtT3YLALj4lTr4a9GWuCXGotTX9SExYwsKL1Z JobtgNJ9zAtF00tLqKywrYYqt+cguuK4hRCt6RgFoJSpGSAcn3hDGGWYsYYQDvUQnvux dqMOGJ4YCcEfM0UKETcPIBWppEdpHJXUHp0SGQZo+PwEi2sNxFnUbGBiEsU42s7y4Gzf 8cECPNmWn/kbmM3aEuCuZ4oQLmzL3MU+YRr5ycdlZt8EPVF5+8Bl6tLJ1E6kROn8ZXAc Wehg== X-Forwarded-Encrypted: i=1; AJvYcCW605Tfibr7yf3u6jOJnrAYfQeI1HaaVfw/HsJa/X4b9jFlumr4y09Q6GkQaa2pM0logZRWqmUkTwAJkMA=@vger.kernel.org X-Gm-Message-State: AOJu0YzUGRGdt5/bOpXUWn80MRZKGt3q8G3DCqWL7h98/p3VuHidt682 /lwLYnO23mAexL1CNXqZQ2Kh/s/LuijMHS9FMkkQNgbkzr85h30TKmC9dkuzoV9X/gEe+fpFqki ZJgLs3T9ejLFcEzr/893W3nDPmoTFfAZKKX7bj8YJ6WvlHUKPImlHVUtsd5McPnqk2ks= X-Gm-Gg: AY/fxX7FdhAmoW7LHWe5p6cQosvXs2VUjMCD/6ocbL5xd0UDbGEXpjG65NR/fcAtgyQ AMImedjMuSwLmBTVk+DKaEZyIOnB1owchaSP4o8J5xN/iMI0RscsPJTW4Mjicq/KElX0UwS7h/4 Vg0HHf15VpkxrRAD55JMJHj4S74/T6BDSTNVBU45AnOy/7duRxzzpBI0tyNeNMD8p+uZIRdSOdS x4vtF+rzzivT6ewRYvPfgcDuLDgMynCOAAwgqXrca3rkyOa3M1aZbBZ5U8EnxWwwhqNX9WEP4gH 3FunD60yE8mNvNUKK/ioO35OmrxFYqrU2fKaSy1hsn/xSd8kTW+QIBbY4kUnvTHZn2Tmqi/ojRv DssxdDYg8NXsiVCfz8Ba6IUWwsDJGUs0IXW6nJrYM5itc X-Received: by 2002:a17:903:b0f:b0:2a0:d364:983b with SMTP id d9443c01a7336-2a599e5cb87mr14570365ad.60.1768374756704; Tue, 13 Jan 2026 23:12:36 -0800 (PST) X-Received: by 2002:a17:903:b0f:b0:2a0:d364:983b with SMTP id d9443c01a7336-2a599e5cb87mr14570035ad.60.1768374756186; Tue, 13 Jan 2026 23:12:36 -0800 (PST) Received: from [10.206.109.90] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a3e3c49299sm215214325ad.42.2026.01.13.23.12.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jan 2026 23:12:35 -0800 (PST) Message-ID: <82f03ed2-bec6-01c8-8ede-d4c4c406cdd6@oss.qualcomm.com> Date: Wed, 14 Jan 2026 12:42:27 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 03/11] media: iris: retrieve UBWC platform configuration To: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Akhil P Oommen , Vikash Garodia , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, Bryan O'Donoghue References: <20260113-iris-ubwc-v2-0-4346a6ef07a9@oss.qualcomm.com> <20260113-iris-ubwc-v2-3-4346a6ef07a9@oss.qualcomm.com> Content-Language: en-US From: Dikshita Agarwal In-Reply-To: <20260113-iris-ubwc-v2-3-4346a6ef07a9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: ZOHjZb8WRMzcS17wLXDjMr13u2ECo6uB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE0MDA1NSBTYWx0ZWRfX5M7zudHs8Ahq zXfjK1RlbotLOBTKLRpp87AAzzRGL3biFdXI+MEWxRP/5We/IpHq6qlOO5+ulyUi6un1RGfJuDS AeAHjJXjeOziUtgPnA76tFbwj+izxAnGcJzOuGv4BpcGxiciZCJVUfWPONa3+qBMgMkpJVFClO+ rJ2R5WY1hXMV7QDz/i4Z0dF0VgiEH0JafIL9jv5zKSvn9WZqqPqkIjyFC8nhdoMYxTuwqm+zKXL xlUDTVhcxX2RH7rjm/kDchXPEzddBNFZVcZRzA8zC3vrXf5Y8yjClPwBEHdlqiSTD6uwDD+eiEG pTwHNcxBN6mc3AoMYAsviGQeIYYkwBKjuH1cua6a4D9W4Huuc+vT+gaQWW9j3IZxSo/0Skk75kj qG5LCuH5+5ex2+48tIce8KSlwghrZvKsw5pks+kiWPCmhoRDBoyMhEDDZ5O6GsTMfF0z/rvThKO +wmelnEeyYQ1Wgqi8pA== X-Proofpoint-GUID: ZOHjZb8WRMzcS17wLXDjMr13u2ECo6uB X-Authority-Analysis: v=2.4 cv=IpETsb/g c=1 sm=1 tr=0 ts=696741e5 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=Hb1tMkpcLnUKv6SOSUkA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-14_02,2026-01-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 bulkscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601140055 On 1/13/2026 10:27 PM, Dmitry Baryshkov wrote: > Specifying UBWC data in each driver doesn't scale and is prone to > errors. Request UBWC data from the central database in preparation to > using it through the rest of the driver. > > Reviewed-by: Bryan O'Donoghue > Signed-off-by: Dmitry Baryshkov > --- > drivers/media/platform/qcom/iris/Kconfig | 1 + > drivers/media/platform/qcom/iris/iris_core.h | 4 ++++ > drivers/media/platform/qcom/iris/iris_probe.c | 5 +++++ > 3 files changed, 10 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/Kconfig b/drivers/media/platform/qcom/iris/Kconfig > index 3c803a05305a..39b06de6c3e6 100644 > --- a/drivers/media/platform/qcom/iris/Kconfig > +++ b/drivers/media/platform/qcom/iris/Kconfig > @@ -5,6 +5,7 @@ config VIDEO_QCOM_IRIS > select V4L2_MEM2MEM_DEV > select QCOM_MDT_LOADER if ARCH_QCOM > select QCOM_SCM > + select QCOM_UBWC_CONFIG > select VIDEOBUF2_DMA_CONTIG > help > This is a V4L2 driver for Qualcomm iris video accelerator > diff --git a/drivers/media/platform/qcom/iris/iris_core.h b/drivers/media/platform/qcom/iris/iris_core.h > index fb194c967ad4..d10a03aa5685 100644 > --- a/drivers/media/platform/qcom/iris/iris_core.h > +++ b/drivers/media/platform/qcom/iris/iris_core.h > @@ -30,6 +30,8 @@ enum domain_type { > DECODER = BIT(1), > }; > > +struct qcom_ubwc_cfg_data; > + > /** > * struct iris_core - holds core parameters valid for all instances > * > @@ -52,6 +54,7 @@ enum domain_type { > * @resets: table of iris reset clocks > * @controller_resets: table of controller reset clocks > * @iris_platform_data: a structure for platform data > + * @ubwc_cfg: UBWC configuration for the platform > * @state: current state of core > * @iface_q_table_daddr: device address for interface queue table memory > * @sfr_daddr: device address for SFR (Sub System Failure Reason) register memory > @@ -95,6 +98,7 @@ struct iris_core { > struct reset_control_bulk_data *resets; > struct reset_control_bulk_data *controller_resets; > const struct iris_platform_data *iris_platform_data; > + const struct qcom_ubwc_cfg_data *ubwc_cfg; > enum iris_core_state state; > dma_addr_t iface_q_table_daddr; > dma_addr_t sfr_daddr; > diff --git a/drivers/media/platform/qcom/iris/iris_probe.c b/drivers/media/platform/qcom/iris/iris_probe.c > index 9bc9b34c2576..85e531b35ecf 100644 > --- a/drivers/media/platform/qcom/iris/iris_probe.c > +++ b/drivers/media/platform/qcom/iris/iris_probe.c > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > > #include "iris_core.h" > #include "iris_ctrls.h" > @@ -248,6 +249,10 @@ static int iris_probe(struct platform_device *pdev) > > core->iris_platform_data = of_device_get_match_data(core->dev); > > + core->ubwc_cfg = qcom_ubwc_config_get_data(); > + if (IS_ERR(core->ubwc_cfg)) > + return PTR_ERR(core->ubwc_cfg); > + > ret = devm_request_threaded_irq(core->dev, core->irq, iris_hfi_isr, > iris_hfi_isr_handler, IRQF_TRIGGER_HIGH, "iris", core); > if (ret) > Reviewed-by: Dikshita Agarwal Thanks, Dikshita