From: "Chester A. Unal" <chester.a.unal@arinc9.com>
To: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dwayne Du Preez <dwayne.dupreez@xpedite-tech.com>,
Alexander Scholten <alexander.scholten@xpedite-tech.com>,
Zenon van Deventer <zenon@xpedite-tech.com>
Subject: Re: [PATCH] USB: serial: option: add MeiG Smart SLM828
Date: Thu, 23 Jan 2025 15:18:21 +0000 (UTC) [thread overview]
Message-ID: <82f2d730-7871-4ac3-a1a3-e51ed50bb764@arinc9.com> (raw)
In-Reply-To: <20250123-for-johan-meig-slm828-v1-1-6456996e94a5@arinc9.com>
On 23/01/2025 13:13, Chester A. Unal via B4 Relay wrote:
> drivers/usb/serial/option.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 1e2ae0c6c41c79dd38f2c1d3a98e58ebf076050a..e25acac854cca38d2e0ace464be11337d3bbecee 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -621,7 +621,9 @@ static void option_instat_callback(struct urb *urb);
>
> /* MeiG Smart Technology products */
> #define MEIGSMART_VENDOR_ID 0x2dee
> -/* MeiG Smart SRM815/SRM825L based on Qualcomm 315 */
> +/* MeiG Smart SLM828, SRM815, and SRM825L use the same product ID. SRM815 and
> + * SRM825L are based on Qualcomm 315.
> + */
> #define MEIGSMART_PRODUCT_SRM825L 0x4d22
> /* MeiG Smart SLM320 based on UNISOC UIS8910 */
> #define MEIGSMART_PRODUCT_SLM320 0x4d41
> @@ -2405,10 +2407,12 @@ static const struct usb_device_id option_ids[] = {
> { USB_DEVICE_AND_INTERFACE_INFO(UNISOC_VENDOR_ID, LUAT_PRODUCT_AIR720U, 0xff, 0, 0) },
> { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SLM320, 0xff, 0, 0) },
> { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SLM770A, 0xff, 0, 0) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0, 0) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0xff, 0x30) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0xff, 0x40) },
> - { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0xff, 0x60) },
> + { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0, 0) }, /* MeiG Smart SRM815 */
> + { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0x10, 0x02) }, /* MeiG Smart SLM828 */
> + { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0x10, 0x03) }, /* MeiG Smart SLM828 */
> + { USB_DEVICE_AND_INTERFACE_INFO(MEIGSMART_VENDOR_ID, MEIGSMART_PRODUCT_SRM825L, 0xff, 0xff, 0x30) }, /* MeiG Smart SRM825L */
SRM815 has an interface with this specification as well. Perhaps, it would
be a good idea to change this comment to:
/* MeiG Smart SRM815 and SRM825L */
Chester A.
prev parent reply other threads:[~2025-01-23 15:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-23 13:13 Chester A. Unal via B4 Relay
2025-01-23 15:18 ` Chester A. Unal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f2d730-7871-4ac3-a1a3-e51ed50bb764@arinc9.com \
--to=chester.a.unal@arinc9.com \
--cc=alexander.scholten@xpedite-tech.com \
--cc=dwayne.dupreez@xpedite-tech.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=zenon@xpedite-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®