From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B515ECDE5F for ; Mon, 23 Jul 2018 17:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AAED20854 for ; Mon, 23 Jul 2018 17:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1AAED20854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=deltatee.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388481AbeGWTAO (ORCPT ); Mon, 23 Jul 2018 15:00:14 -0400 Received: from ale.deltatee.com ([207.54.116.67]:58384 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387981AbeGWTAN (ORCPT ); Mon, 23 Jul 2018 15:00:13 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1fhf5h-0007m4-WC; Mon, 23 Jul 2018 11:57:51 -0600 To: Julia Lawall Cc: Jon Mason , Dave Jiang , Allen Hubbe , linux-ntb@googlegroups.com, linux-kernel@vger.kernel.org, kbuild-all@01.org References: From: Logan Gunthorpe Message-ID: <82f3a6a0-57a8-b7c4-4b25-2dc423ba6525@deltatee.com> Date: Mon, 23 Jul 2018 11:57:45 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: kbuild-all@01.org, linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com, allenbh@gmail.com, dave.jiang@intel.com, jdmason@kudzu.us, julia.lawall@lip6.fr X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] NTB: fix debugfs_simple_attr.cocci warnings X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/18 12:47 AM, Julia Lawall wrote: > From: kbuild test robot > > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Fixes: c75153197d20 ("NTB: Introduce NTB MSI Test Client") > Signed-off-by: kbuild test robot > Signed-off-by: Julia Lawall > --- > > I don't know much about this issue, beyondwhat is explained by the > semantic patch. Please check if the changes can be relevant. Oops, this work wasn't meant for public consumption yet. Everyone pretend you didn't see that ;). I must have pushed it to my repo that kbuild tests by accident. Though, I'm glad to have learned about the more efficient use of debugfs attributes. Logan