From: Vlastimil Babka <vbabka@suse.cz>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Mel Gorman <mgorman@suse.de>, NeilBrown <neilb@suse.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic
Date: Mon, 26 Jun 2017 14:17:30 +0200 [thread overview]
Message-ID: <82f5331e-8a3d-ed61-3d5d-3dfcbf557072@suse.cz> (raw)
In-Reply-To: <20170626121411.GK11534@dhcp22.suse.cz>
On 06/26/2017 02:14 PM, Michal Hocko wrote:
> On Mon 26-06-17 13:45:19, Vlastimil Babka wrote:
>> On 06/23/2017 10:53 AM, Michal Hocko wrote:
> [...]
>>> - GFP_KERNEL - both background and direct reclaim are allowed and the
>>> _default_ page allocator behavior is used. That means that !costly
>>> allocation requests are basically nofail (unless the requesting task
>>> is killed by the OOM killer)
>>
>> Should we explicitly point out that failure must be handled? After lots
>> of talking about "too small to fail", people might get the wrong impression.
>
> OK. What about the following.
> "That means that !costly allocation requests are basically nofail but
> there is no guarantee of thaat behavior so failures have to be checked
that
> properly by callers (e.g. OOM killer victim is allowed to fail
> currently).
Looks good, thanks!
next prev parent reply other threads:[~2017-06-26 12:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-23 8:53 [PATCH 0/6] mm: give __GFP_REPEAT a better semantic Michal Hocko
2017-06-23 8:53 ` [PATCH 1/6] MIPS: do not use __GFP_REPEAT for order-0 request Michal Hocko
2017-06-23 10:27 ` Ralf Baechle
2017-06-26 9:36 ` Vlastimil Babka
2017-06-23 8:53 ` [PATCH 2/6] mm, tree wide: replace __GFP_REPEAT by __GFP_RETRY_MAYFAIL with more useful semantic Michal Hocko
2017-06-26 11:45 ` Vlastimil Babka
2017-06-26 12:14 ` Michal Hocko
2017-06-26 12:17 ` Vlastimil Babka [this message]
2017-06-26 12:38 ` Michal Hocko
2017-06-26 12:42 ` Michal Hocko
2017-06-26 11:53 ` Vlastimil Babka
2017-06-23 8:53 ` [PATCH 3/6] xfs: map KM_MAYFAIL to __GFP_RETRY_MAYFAIL Michal Hocko
2017-06-27 8:49 ` Michal Hocko
2017-06-27 13:47 ` Christoph Hellwig
2017-06-27 14:06 ` Michal Hocko
2017-06-28 4:12 ` Darrick J. Wong
2017-06-23 8:53 ` [PATCH 4/6] mm: kvmalloc support __GFP_RETRY_MAYFAIL for all sizes Michal Hocko
2017-06-26 12:00 ` Vlastimil Babka
2017-06-26 12:18 ` Michal Hocko
2017-06-23 8:53 ` [PATCH 5/6] drm/i915: use __GFP_RETRY_MAYFAIL Michal Hocko
2017-06-23 8:53 ` [PATCH 6/6] mm, migration: do not trigger OOM killer when migrating memory Michal Hocko
2017-06-23 20:43 ` Andrew Morton
2017-06-26 5:28 ` Michal Hocko
2017-06-26 12:13 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f5331e-8a3d-ed61-3d5d-3dfcbf557072@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®