Re: [PATCH 7/7] media: qcom: iris: describe QC10C as TP10

[Nicolas Dufresne <nicolas.dufresne@collabora.com>]

[-- Attachment #1: Type: text/plain, Size: 1356 bytes --]

Hi,

Le mercredi 04 novembre 2026 à 18:36 +0200, Dmitry Baryshkov a écrit :
> The comment describing the QC10C buffer layout calls it a compressed
> P010. It is not: P010 stores each sample in 16 bits, QC10C packs three
> 10-bit samples in each 32-bit word, which is what the stride computed
> below (width * 4 / 3) assumes. Name the format correctly.

Keeping this separate from other thread. Maybe we should upfront tell what is
the DRM_fourcc + DRM_modifier pair in the doc [0].

[0] Documentation/userspace-api/media/v4l/pixfmt-reserved.rst

> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  drivers/media/platform/qcom/iris/iris_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/qcom/iris/iris_buffer.c b/drivers/media/platform/qcom/iris/iris_buffer.c
> index eb8de60c1177..ec2bf2a2d953 100644
> --- a/drivers/media/platform/qcom/iris/iris_buffer.c
> +++ b/drivers/media/platform/qcom/iris/iris_buffer.c
> @@ -266,7 +266,7 @@ static u32 iris_yuv_buffer_size_qc08c(struct iris_inst *inst)
>  
>  /*
>   * QC10C:
> - * UBWC-compressed format for P010.
> + * UBWC-compressed TP10, YUV 4:2:0 with three 10 bit samples packed in 32 bits.
>   * Contains 4 planes in the following order -
>   * (A) Y_Meta_Plane
>   * (B) Y_UBWC_Plane

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]