mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Darren Jenkins <darrenrjenkins@gmail.com>
To: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Kernel Janitors <kernel-janitors@vger.kernel.org>,
	Len Brown <lenb@kernel.org>,
	linux ACPI <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/acpi/ec.c fix a small memory leak
Date: Wed, 3 Feb 2010 22:33:06 +1100	[thread overview]
Message-ID: <82faac5b1002030333w6eea479sb9148a329c0eb441@mail.gmail.com> (raw)
In-Reply-To: <4B684650.9070807@suse.de>

Hello Alexey,

On Wed, Feb 3, 2010 at 2:35 AM, Alexey Starikovskiy
<astarikovskiy@suse.de> wrote:
> NAK
>
> saved_ec is allocated if flag EC_FLAGS_VALIDATE_ECDT is true.
> EC_FLAGS_SKIP_DSDT_SCAN have no sense in such case, thus this new code path
> is never executed.

>From what I can tell this is not guaranteed by the code, it is relying
on DMI data not matching two of the stings at once.
However I don't know anything about DMI, so if you say this makes no
sense and will never happen I am happy.

I will mark this as ignore in the Coverity databse.

> On the other hand, unconditionally freeing pointer, which is might be NULL, is not
> right either.

Nowadays this is the preferred method actually.

> Regards,
> Alex.

Thanks for the feedback.

Darren J

      parent reply	other threads:[~2010-02-03 11:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 12:12 Darren Jenkins
2010-02-02 15:35 ` Alexey Starikovskiy
2010-02-03  6:12   ` Dan Carpenter
2010-02-03 11:06   ` Bernd Petrovitsch
2010-02-03 11:33   ` Darren Jenkins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82faac5b1002030333w6eea479sb9148a329c0eb441@mail.gmail.com \
    --to=darrenrjenkins@gmail.com \
    --cc=astarikovskiy@suse.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®