From: Hector Martin <marcan@marcan.st>
To: Adrian Hunter <adrian.hunter@intel.com>,
Ben Chuang <benchuanggli@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Sven Peter <sven@svenpeter.dev>, Marc Zyngier <maz@kernel.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] mmc: sdhci-pci-gli: GL9755: Support for CD/WP inversion on OF platforms
Date: Tue, 14 Dec 2021 20:17:46 +0900 [thread overview]
Message-ID: <82faec71-31f7-f64e-e8e7-cf698b29fa16@marcan.st> (raw)
In-Reply-To: <72e29a9d-7e2a-5c2e-c44b-42172aae4f2d@intel.com>
On 14/12/2021 19.41, Adrian Hunter wrote:
>> #define PCI_GLI_9755_PECONF 0x44
>> -#define PCI_GLI_9755_LFCLK GENMASK(14, 12)
>> -#define PCI_GLI_9755_DMACLK BIT(29)
>> +#define PCI_GLI_9755_LFCLK GENMASK(14, 12)
>> +#define PCI_GLI_9755_DMACLK BIT(29)
>
> Please don't mix in white space changes.
This is aligning the existing code with the additions; is it preferable
to have the new ifdefs below misaligned?
>> +#define PCI_GLI_9755_INVERT_CD BIT(30)
>> +#define PCI_GLI_9755_INVERT_WP BIT(31)
>>
>> #define PCI_GLI_9755_CFG2 0x48
>> #define PCI_GLI_9755_CFG2_L1DLY GENMASK(28, 24)
>> @@ -570,6 +573,18 @@ static void gl9755_hw_setting(struct sdhci_pci_slot *slot)
>> gl9755_wt_on(pdev);
>>
>> pci_read_config_dword(pdev, PCI_GLI_9755_PECONF, &value);
>> +#ifdef CONFIG_OF
>> + if (pdev->dev.of_node) {
>
> As Robin wrote, please remove #ifdef and if (pdev->dev.of_node)
> because they are not needed.
Ack, will send out a v3 soon with the requested changes and hopefully it
should be good to go :)
--
Hector Martin (marcan@marcan.st)
Public Key: https://mrcn.st/pub
next prev parent reply other threads:[~2021-12-14 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-12 7:02 [PATCH v2 0/2] Hi folks, Hector Martin
2021-12-12 7:02 ` [PATCH v2 1/2] mmc: sdhci-pci-gli: GL9755: Support for CD/WP inversion on OF platforms Hector Martin
2021-12-13 11:45 ` Robin Murphy
2021-12-15 15:58 ` Hector Martin
2021-12-14 10:41 ` Adrian Hunter
2021-12-14 11:17 ` Hector Martin [this message]
2021-12-14 11:27 ` Adrian Hunter
2021-12-12 7:02 ` [PATCH v2 2/2] mmc: sdhci-pci-gli: GL975[50]: Issue 8/16-bit MMIO reads as 32-bit reads Hector Martin
2021-12-14 10:42 ` Adrian Hunter
2021-12-12 7:05 ` [PATCH v2 0/2] (mmc: sdhci-pci-gli: GL9755: Quirks for Apple ARM platforms) Hector Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82faec71-31f7-f64e-e8e7-cf698b29fa16@marcan.st \
--to=marcan@marcan.st \
--cc=adrian.hunter@intel.com \
--cc=benchuanggli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=sven@svenpeter.dev \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®