From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EA2B1E2310 for ; Mon, 20 Jan 2025 13:56:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737381375; cv=none; b=cu6laltCBzFPddZhtt2+0yIorDNvs05aJMzAECcRmGXcY2KJLFdAofbi8kuwaOW8P3ozSdh5HvMhA9jG/DyLS1m9acXyb6blhY182wcsIoQF2oB6I7Q/qNpoj4SiUB43MFyfgYUxUrxwCZ311sO6jJBfR0WSwr6sDTTPvEmyjvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737381375; c=relaxed/simple; bh=Ror+LioIZOIpCPtU4GjEvHNFwAYtYXcGKBWcYF1Is7g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gomNAvbOywD7qfsw+yFGNS0Lw5QBYrtvRR98SBi0+3Xm/JvTj5ua4+0AVIjo58D1O2Y5TX3iO5EV8559txFQU/M6solY1dGGq4fWk5t2vDqYZyhvBs9Xy7y9sNB2eRXp4oQSpc5gnWlinyZXVzpQuFPMkcsKTKQPItQCu1HofYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=RXTP8TmJ; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RXTP8TmJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737381373; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mJj1hVE0UPrptk8KoZN8nx3Hw+c/+iunwLyM9zGG1YE=; b=RXTP8TmJqIb6UfsT6FoNaAAMl7jJ6CZG+3lo0BcPSBZpkKPlqbjupHCh5U4PLNcZ+9b7VG zygWLc5VhrAsf37N5HwYLDnOXduWgDm3v/gSZABYWarEBcVY78isd86613YBmyrE/91Ssl OWgZ/dMUUMkYE3Q89cS7da2Ya/kyL0M= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-X40m-US4MpS_IK2fOaftDA-1; Mon, 20 Jan 2025 08:56:11 -0500 X-MC-Unique: X40m-US4MpS_IK2fOaftDA-1 X-Mimecast-MFC-AGG-ID: X40m-US4MpS_IK2fOaftDA Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4362153dcd6so23611795e9.2 for ; Mon, 20 Jan 2025 05:56:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737381371; x=1737986171; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=mJj1hVE0UPrptk8KoZN8nx3Hw+c/+iunwLyM9zGG1YE=; b=YFnilkgDziuh48dUZ63r8tDJwaRp6OxdSmIEMBuSK27ArM4fq5U3cYRj3mgVhghfD4 MAEwlsBs2tAmL12QTMzLY+umoWynVjyhTgZdAMgFbylpdSDemBaI93WZ3PpMyfWfzNtf CRg6MCfu/dsHY5ZD5hO1EY7m8a+nlpN5ae5ao7N1Sjjsu7wPSorLf8oQwkEWEU+Yz3Tw Yhi2P6EO2sJhw+LEAuzQMr9Qj2Ui3Yo9zoWS1zgzA35XJG74wOpq9bX+aNCjDWoC+VEN F9YREh2242YovOJk4xHmbwWtM5AI+0j4ORUyvgnh3UehVnVqSt0vemU4saeXBwZbXZ91 ji5A== X-Gm-Message-State: AOJu0YyRTBkelI9llZHo6TNkKT3s7AJaaHfV3633ITjvur4Y6nMgAgIT OlpESrdl13nM/CvwBJjMp3ZQ5pYtXrMWtIROrLoLDs7AxiZU94gAnF1L+ltcdEBLDK6AVTfhHga kl6SN7ly4uV00hNC5xRjGVZQrhI1h1GgpQ+rtEGLb+o5ezYcGHAK+CTpqpKJsOw== X-Gm-Gg: ASbGncs5jTCRvfwsmjb9UqC/gVILTtNVtN0Ia0A1DTjzIwZriC3MTBuuNJaV90bqKnE ANiqb4Wtp2QSoVAn8XDE/PVZX3chTYhDDRGckKQvP5r527EGAfmfGhBF2PXqO+jkQ9N7WnX31Tk 3Dg1xOpcVVUP+uRIWwzGqm3YF2TM/9eVpQPzmsNvgGyIFDHbwxn6cg2BDpA2ArLG+RppzyPcMxl 8/C5rH2QKDxQfpyVtQJhIiB1PkbHFM4FlJqSsTA0ya/N9KwSPGaEwC5ilHJvZzWr+n+UWVKQ4jW gu7nOhLifDJl/sIGKl4BdddH8WumalQoF734etVe5PCRldzDpD8FtX3xaSvPYkeHJvT1jTH8AQN 54Yu410sYoEbD73si9mcklw== X-Received: by 2002:a05:600c:3495:b0:434:a315:19c with SMTP id 5b1f17b1804b1-438913bdb0emr117566205e9.3.1737381370723; Mon, 20 Jan 2025 05:56:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxGLnqO/6yc7CmONG/QtHqoi11ADJGilOKam2v8Xd/JmhOIK1v8XYKW7vPn2qboulXEHBx5g== X-Received: by 2002:a05:600c:3495:b0:434:a315:19c with SMTP id 5b1f17b1804b1-438913bdb0emr117565805e9.3.1737381370274; Mon, 20 Jan 2025 05:56:10 -0800 (PST) Received: from ?IPV6:2003:d8:2f22:1000:d72d:fd5f:4118:c70b? (p200300d82f221000d72dfd5f4118c70b.dip0.t-ipconnect.de. [2003:d8:2f22:1000:d72d:fd5f:4118:c70b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43890409758sm144011285e9.2.2025.01.20.05.56.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 05:56:09 -0800 (PST) Message-ID: <8305ddf7-1ada-4a75-a2c3-385b530b25d4@redhat.com> Date: Mon, 20 Jan 2025 14:56:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 00/11] khugepaged: mTHP support To: Ryan Roberts , Nico Pache Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, willy@infradead.org, kirill.shutemov@linux.intel.com, aarcange@redhat.com, raquini@redhat.com, dev.jain@arm.com, sunnanyong@huawei.com, usamaarif642@gmail.com, audra@redhat.com, akpm@linux-foundation.org References: <20250108233128.14484-1-npache@redhat.com> <40a65c5e-af98-45f9-a254-7e054b44dc95@arm.com> <37375ace-5601-4d6c-9dac-d1c8268698e9@redhat.com> <0a318ea8-7836-405a-a033-f073efdc958f@arm.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <0a318ea8-7836-405a-a033-f073efdc958f@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20.01.25 14:37, Ryan Roberts wrote: > On 20/01/2025 12:54, David Hildenbrand wrote: >>>> I think the 1 problem that emerged during review of Dev's series, which we don't >>>> have a proper solution to yet, is the issue of "creep", where regions can be >>>> collapsed to progressively higher orders through iterative scans. At each >>>> collapse, the required thresholds (e.g. max_ptes_none) are met, and the collapse >>>> effectively adds more non-none ptes so the next scan will then collapse to even >>>> higher order. Does your solution suffer from this (theoretical/edge case) issue? >>>> If not, how did you solve? >>> >>> Yes sadly it suffers from the same issue. bringing max_ptes_none much >>> lower as a default would "help". >> >> Can we just keep it simple and only support max_ptes_none = 511 ("pagefault >> behavior" -- PMD_NR_PAGES - 1) or max_ptes_none = 0 ("deferred behavior") and >> document that the other weird configurations will make mTHP skip, because "weird >> and unexpetced" ? :) >> > > That sounds like a great simplification in principle! And certainly a much easier to start with :) If we ever get the request to support something else, maybe that's also where we can learn *why*, and what we would actually want to do with mTHP. > We would need to consider > the swap and shared tunables too though. Perhaps we can pull a similar trick > with those? Swapped and shared are a bit more challenging, because they are set to "/ 2" or "/ 8" heuristics. One simple starting point here is of course to say "when collapsing mTHP, all have to be unshared and all have to be swapped in", so to essentially ignore both tunables (in a memory friendly way, as if they are set to 0) for mTHP collapse and worry about that later, when really required. Two alternatives I discussed with Nico for these (not sure which is implemented here) is to calculate it proportionally to the folio order we are collapsing: Assuming max_ptes_swap = 64 (PMD: 512 PTEs) and we are collapsing a 1 MiB mTHP (256 PTEs), 32 PTEs would be allowed to be swapped out. -- Cheers, David / dhildenb