From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.secunet.com (mx1.secunet.com [62.96.220.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 793F9344020; Tue, 27 Jan 2026 10:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.96.220.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510565; cv=none; b=Je4N202pnxiG1i9gn9MH9O8H6vCYE8/CmQZ8dUlCJwiOeVVu22p4l4LYFwKwNFNcgAnQcL+liRyh9+8lxos/IwhplqtCOdmMol55SDKTIrGsyWDSK47oI+2g2brgzFdfrl0kcXS10LboDjmyGToNea776XX445nY47x/Z+rl1hU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769510565; c=relaxed/simple; bh=5d+aB+Kk+Z09mvPx4+e/Ini+FCw75mDwQ+LeMTuYvnY=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=c+wlfBNoInJKjyW2dl++v59lJOpz6qiVT6jsWPSz1DS7JUYZdONGVCcDibl3ZJJELn5FEawcNXXus7PfmLa7F66aZ6DyIK8UVjjWAo3EQULEKUKP9LSGOqQF+s4QIToGYx9cKJOjL+rRVHU13xH/30AuswzUw1iIZlkFePW3Wis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com; spf=pass smtp.mailfrom=secunet.com; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b=GcyOiavj; arc=none smtp.client-ip=62.96.220.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=secunet.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=secunet.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=secunet.com header.i=@secunet.com header.b="GcyOiavj" Received: from localhost (localhost [127.0.0.1]) by mx1.secunet.com (Postfix) with ESMTP id 960C3200AC; Tue, 27 Jan 2026 11:42:40 +0100 (CET) X-Virus-Scanned: by secunet Received: from mx1.secunet.com ([127.0.0.1]) by localhost (mx1.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r9Urdc6e1NwD; Tue, 27 Jan 2026 11:42:40 +0100 (CET) Received: from EXCH-02.secunet.de (rl2.secunet.de [10.32.0.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.secunet.com (Postfix) with ESMTPS id 0DD2B2006C; Tue, 27 Jan 2026 11:42:40 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.secunet.com 0DD2B2006C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=secunet.com; s=202301; t=1769510560; bh=O+65kgrRmjW9u4/OuBzXhAvfNF7wjCYEleqneUzt/LM=; h=From:To:CC:Subject:Date:In-Reply-To:References:From; b=GcyOiavjbj9Erw38lG7HqU46CAxBwP39yWF4EdNLt4PbRfBtYiOI1UmrDRMcn1Jr5 0cXgEEY6qPtz+rN8k0XwgO7yg3PSA+o8d+rU7WUgzKVqb4T2Mu5wvOAlu9wfFmZYrh qWOEONlEbx3Q95RbArwguMc8spNiaeF9jsPNXa7Z6O4l123VUuXgV9KY2IR2lJ82Q7 1NM6sHdDmfWNkZjK5aoxc7hH/5hTdWCN+MvE8bvqW3FatCx3lZoeTUMo3l7/ge3cYI A1nOEMZu1mRXpoaz7T1LIxmVovOHA2r/sq4oTk5yTdCr5dwJwwcE+HXiM+DlVdTST7 VUcG1yTREG7vA== Received: from moon.secunet.de (172.18.149.1) by EXCH-02.secunet.de (10.32.0.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 27 Jan 2026 11:42:39 +0100 From: Antony Antony To: Antony Antony , Steffen Klassert , Herbert Xu , CC: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chiachang Wang , Yan Yan , , Simon Horman , Subject: [PATCH ipsec-next v5 2/8] xfrm: remove redundant assignments Date: Tue, 27 Jan 2026 11:42:23 +0100 Message-ID: <83091de75e6605e2efb28a906f3f5346b8bdea22.1769509131.git.antony.antony@secunet.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EXCH-02.secunet.de (10.32.0.172) To EXCH-02.secunet.de (10.32.0.172) These assignments are overwritten within the same function further down commit e8961c50ee9cc ("xfrm: Refactor migration setup during the cloning process") x->props.family = m->new_family; Which actually moved it in the commit e03c3bba351f9 ("xfrm: Fix xfrm migrate issues when address family changes") And the initial commit 80c9abaabf428 ("[XFRM]: Extension for dynamic update of endpoint address(es)") added x->props.saddr = orig->props.saddr; and memcpy(&xc->props.saddr, &m->new_saddr, sizeof(xc->props.saddr)); Signed-off-by: Antony Antony --- v1->v2: remove extra saddr copy, previous line --- net/xfrm/xfrm_state.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/xfrm/xfrm_state.c b/net/xfrm/xfrm_state.c index 98b362d51836..3ee92f93dbd2 100644 --- a/net/xfrm/xfrm_state.c +++ b/net/xfrm/xfrm_state.c @@ -1980,8 +1980,6 @@ static struct xfrm_state *xfrm_state_clone_and_setup(struct xfrm_state *orig, x->props.mode = orig->props.mode; x->props.replay_window = orig->props.replay_window; x->props.reqid = orig->props.reqid; - x->props.family = orig->props.family; - x->props.saddr = orig->props.saddr; if (orig->aalg) { x->aalg = xfrm_algo_auth_clone(orig->aalg); -- 2.39.5