From: "Andrew F. Davis" <afd@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Jens Wiklander <jens.wiklander@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method
Date: Tue, 19 Sep 2017 10:54:34 -0500 [thread overview]
Message-ID: <830b4d20-26e2-02ce-76db-b63c73967e39@ti.com> (raw)
In-Reply-To: <CAL_JsqJ00f3i3BQKjuVUXO8Rc_EC8BaycQi1Z_9OyRff7_kDpg@mail.gmail.com>
On 09/19/2017 08:36 AM, Rob Herring wrote:
> On Mon, Sep 18, 2017 at 3:50 PM, Andrew F. Davis <afd@ti.com> wrote:
>> On TI platforms OP-TEE must be called using a modified SMC call,
>> allow the selection of this though DT.
>>
>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>> ---
>> Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt | 2 ++
>> drivers/tee/optee/core.c | 2 ++
>> 2 files changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
>> index d38834c67dff..a3275ecdf186 100644
>> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
>> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
>> @@ -20,6 +20,8 @@ the reference implementation maintained by Linaro.
>> "hvc" : HVC #0, with the register assignments specified
>> in drivers/tee/optee/optee_smc.h
>>
>> + "ti-smc" : Similar to "smc" with TI specific register
>> + adjustments
>
> Sigh, really? IMO, this should be determined from the compatible
> string. Then the next TI (or any vendor) specific thing can be handled
> without a DT change.
>
Which compatible string, do you mean the OP-TEE driver check the top
level platform compatible string?
> Maybe some day we'll figure out that not just h/w needs to be
> probe-able, but all the firmware pieces do too.
>
> Rob
>
next prev parent reply other threads:[~2017-09-19 15:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 20:50 [PATCH 1/2] ARM: smccc-call: Use r12 to route secure monitor calls on TI platforms Andrew F. Davis
2017-09-18 20:50 ` [PATCH 2/2] tee: optee: allow selection of ti-smc as a calling method Andrew F. Davis
2017-09-19 13:36 ` Rob Herring
2017-09-19 15:54 ` Andrew F. Davis [this message]
2017-09-19 21:10 ` Rob Herring
2017-09-19 14:09 ` Mark Rutland
2017-09-20 0:27 ` kbuild test robot
2017-09-20 0:44 ` kbuild test robot
2017-09-19 14:19 ` [PATCH 1/2] ARM: smccc-call: Use r12 to route secure monitor calls on TI platforms Mark Rutland
2017-09-19 15:07 ` Andrew F. Davis
2017-09-21 14:47 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=830b4d20-26e2-02ce-76db-b63c73967e39@ti.com \
--to=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jens.wiklander@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®