mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Sagi Grimberg <sagi@grimberg.me>, Li Feng <fengli@smartx.com>
Cc: "lifeng1519@gmail.com" <lifeng1519@gmail.com>,
	"open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
	Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH] nvme/tcp: Add support to set the tcp worker cpu affinity
Date: Tue, 18 Apr 2023 03:58:32 +0000	[thread overview]
Message-ID: <8310edb2-84cf-6211-f37d-d8f3df1e2320@nvidia.com> (raw)
In-Reply-To: <7f553d34-9ada-426c-4847-c7cd1aba64a8@grimberg.me>


> - It is not backed by performance improvements, but more importantly
> does not cover any potential regressions in key metrics (bw/iops/lat)
> or lack there of.
>

I've already asked for this, without seeing performance numbers
and any regression for general usecase it is hard to justify this.

-ck




  parent reply	other threads:[~2023-04-18  3:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-13  6:23 Li Feng
2023-04-13  6:33 ` Li Feng
2023-04-13 12:53   ` kernel test robot
2023-04-17 13:45   ` Sagi Grimberg
2023-04-18  3:39     ` Li Feng
2023-04-19  9:32       ` Sagi Grimberg
2023-04-25  8:32         ` Li Feng
2023-04-26 11:31           ` Hannes Reinecke
2023-04-27 12:21             ` Sagi Grimberg
2023-04-27 14:36             ` Ming Lei
2023-04-27 12:11           ` Sagi Grimberg
2023-04-18  3:58     ` Chaitanya Kulkarni [this message]
2023-04-18  4:21       ` Li Feng
2023-04-18  9:20       ` Li Feng
2023-04-13 13:29 ` [PATCH v2] " Li Feng
2023-04-14  8:36   ` Hannes Reinecke
2023-04-14  9:35     ` Li Feng
2023-04-15 20:21       ` Chaitanya Kulkarni
2023-04-15 21:06       ` David Laight
2023-04-17  3:31         ` Li Feng
2023-04-17  6:27         ` Hannes Reinecke
2023-04-17  8:32           ` Li Feng
2023-04-17  7:37   ` Ming Lei
2023-04-17  7:50     ` Li Feng
2023-04-17  8:05       ` Ming Lei
2023-04-17 13:33         ` Sagi Grimberg
2023-04-18  3:29           ` Li Feng
2023-04-18  4:33           ` Ming Lei
2023-04-18  9:32             ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8310edb2-84cf-6211-f37d-d8f3df1e2320@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=axboe@fb.com \
    --cc=fengli@smartx.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=lifeng1519@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®