From: "Wappler Marcel" <Marcel.Wappler@bridgeco.net>
To: "Stephen Hemminger" <shemminger@vyatta.com>
Cc: "Patrick McHardy" <kaber@trash.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <ebiederman@lnxi.com>
Subject: RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24
Date: Wed, 27 Feb 2008 18:25:10 +0100 [thread overview]
Message-ID: <83116F0A4FF67A4F97BA0B6E408C48E301C5CE6D@zuerich.BC-Int.NET> (raw)
In-Reply-To: <20080227083819.70ddb374@extreme>
-----Original Message-----
>> In my opinion it is necessary to distinguish between INADDR_ANY and
>> the ZERO address which ist requested to be in the DHCPDISCOVER packet.
>Just delete the lines and the address will be zero because of earlier memset().
>From my personal point of view it is important to document the requirement of the
two addresses to be 0.0.0.0 either through the code itself or through a comment
which states clear the side effect of memset'ting the structure.
Both roads lead to Rome :-)
Marcel
--
Marcel Wappler
Bridgeco AG
CH-8600 Dübendorf
Switzerland
next prev parent reply other threads:[~2008-02-27 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 12:23 Wappler Marcel
2008-02-27 12:46 ` Patrick McHardy
2008-02-27 13:11 ` Wappler Marcel
2008-02-27 16:38 ` Stephen Hemminger
2008-02-27 17:25 ` Wappler Marcel [this message]
2008-02-27 19:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83116F0A4FF67A4F97BA0B6E408C48E301C5CE6D@zuerich.BC-Int.NET \
--to=marcel.wappler@bridgeco.net \
--cc=davem@davemloft.net \
--cc=ebiederman@lnxi.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®