mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Alex Dewar <alex.dewar90@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RDMA/ucma: Fix resource leak on error path
Date: Wed, 2 Sep 2020 19:34:26 -0500	[thread overview]
Message-ID: <83132be0-a33b-ab7a-0da9-cc5c9398d0d4@embeddedor.com> (raw)
In-Reply-To: <20200902162454.332828-1-alex.dewar90@gmail.com>

Hi Alex,

On 9/2/20 11:24, Alex Dewar wrote:
> In ucma_process_join(), if the call to xa_alloc() fails, the function
> will return without freeing mc. Fix this by jumping to the correct line.
> 
> In the process I renamed the jump labels to something more memorable for
> extra clarity.
> 
> Addresses-Coverity: ("Resource leak")

If you are using a public Coverity scan, please also include the Coverity ID.
In this case ID 1496814, something like:

Addresses-Coverity-ID: 1496814 ("Resource leak")

People that don't include an CID is because they are using a private Coverity
scan, so it doesn't make sense for them to add an ID because no one but
them have access to that scan report.

Thanks
--
Gustavo


  parent reply	other threads:[~2020-09-03  0:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02 16:24 Alex Dewar
2020-09-02 20:10 ` Jason Gunthorpe
2020-09-03  0:34 ` Gustavo A. R. Silva [this message]
2020-09-03  0:32   ` Jason Gunthorpe
2020-09-03  0:40     ` Gustavo A. R. Silva
2020-09-03  9:35   ` Alex Dewar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83132be0-a33b-ab7a-0da9-cc5c9398d0d4@embeddedor.com \
    --to=gustavo@embeddedor.com \
    --cc=alex.dewar90@gmail.com \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®