From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20950C76188 for ; Sat, 20 Jul 2019 13:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E75AB2085A for ; Sat, 20 Jul 2019 13:48:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="hc2vn/K3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728486AbfGTNpv (ORCPT ); Sat, 20 Jul 2019 09:45:51 -0400 Received: from merlin.infradead.org ([205.233.59.134]:55934 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728464AbfGTNpv (ORCPT ); Sat, 20 Jul 2019 09:45:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=RIOU5LAIILgInsLZKUJUGf35teEgUvYEPJttEJyAaQY=; b=hc2vn/K3NITr/qd1/BeBsZT89k zpOPsH5kbh9nphMRj0YhRabkG2m1KOYcLKyR3VLjEXzz5541Dbqq7VCmAmNGuhaxjQlb7Z4KMTjmB TVMtHk3ecngXCQITb+nv8IrZob3Q4piWDyvRQ8hmi/Y2d08pzOq9QgikWJskvrscwbo5VVFSGyv0v +mQPo3uZbr3Z+kTRfPEQys46PYqncVZSM7HXqbMdMsaAWJSfulRFirm35y6RWxJ59ovNr3Ojmzgi/ 0aMqZ+Q4OfkizaD2yOJH7YYBFGGmsOkTd+caVR3EgB0JyvZEewk5PIgcmdnFoNif3cYLEm2cWO3nS cXprQMaw==; Received: from static-50-53-52-16.bvtn.or.frontiernet.net ([50.53.52.16] helo=[192.168.1.17]) by merlin.infradead.org with esmtpsa (Exim 4.92 #3 (Red Hat Linux)) id 1hopgF-00027k-Q9; Sat, 20 Jul 2019 13:45:44 +0000 Subject: Re: [PATCH] mtd: hyperbus: Kconfig: Fix HBMC_AM654 dependencies To: Vignesh Raghavendra , Miquel Raynal , Richard Weinberger Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Mao Wenan References: <20190719082912.10316-1-vigneshr@ti.com> From: Randy Dunlap Message-ID: <83175738-a41e-04e6-7be2-85213dfdc416@infradead.org> Date: Sat, 20 Jul 2019 06:45:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190719082912.10316-1-vigneshr@ti.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/19/19 1:29 AM, Vignesh Raghavendra wrote: > On x86_64, when CONFIG_OF is not disabled: > > WARNING: unmet direct dependencies detected for MUX_MMIO > Depends on [n]: MULTIPLEXER [=y] && (OF [=n] || COMPILE_TEST [=n]) > Selected by [y]: > - HBMC_AM654 [=y] && MTD [=y] && MTD_HYPERBUS [=y] > > due to > config HBMC_AM654 > tristate "HyperBus controller driver for AM65x SoC" > select MULTIPLEXER > select MUX_MMIO > > Fix this by making HBMC_AM654 imply MUX_MMIO instead of select so > that dependencies are taken care of. MUX_MMIO is optional for > functioning of driver. > > Fixes: b07079f1642c ("mtd: hyperbus: Add driver for TI's HyperBus memory controller") > Reported-by: Randy Dunlap > Signed-off-by: Vignesh Raghavendra Acked-by: Randy Dunlap # build-tested Thanks. > --- > drivers/mtd/hyperbus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mtd/hyperbus/Kconfig b/drivers/mtd/hyperbus/Kconfig > index cff6bbd226f5..1c691df8eff7 100644 > --- a/drivers/mtd/hyperbus/Kconfig > +++ b/drivers/mtd/hyperbus/Kconfig > @@ -15,7 +15,7 @@ if MTD_HYPERBUS > config HBMC_AM654 > tristate "HyperBus controller driver for AM65x SoC" > select MULTIPLEXER > - select MUX_MMIO > + imply MUX_MMIO > help > This is the driver for HyperBus controller on TI's AM65x and > other SoCs > -- ~Randy