From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5011EC2B9F4 for ; Mon, 14 Jun 2021 13:09:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 340AE6124B for ; Mon, 14 Jun 2021 13:09:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233098AbhFNNLX (ORCPT ); Mon, 14 Jun 2021 09:11:23 -0400 Received: from mail-wr1-f46.google.com ([209.85.221.46]:36453 "EHLO mail-wr1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233478AbhFNNLQ (ORCPT ); Mon, 14 Jun 2021 09:11:16 -0400 Received: by mail-wr1-f46.google.com with SMTP id n7so8322410wri.3 for ; Mon, 14 Jun 2021 06:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:organization:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hStNeExndAJKlr2+D1oBe+je+9Di+B0AKJsmhmeHTHQ=; b=zIfPjNFCiHxfObTFs8ltCt7sZ9oD7I2SfVX1afkSlrtXayb9culO2R5WYKq/e+R9/+ gZJ08pzrH9I/bNRndmH6uhaFMZhakSpKCZWtdV/RsA8AntfFXpi6mykw6LyjOMI1R2lL OiCPiyg6YL0rjkobE198CFEKdvLW/3mvr/n7CGkrPAAQg3Ox+m6qk1YjRBq0g+yVESPH PiqvzF8Ws8MVwVNhz46e+j0MRL31iAAP7wtdT0U42M3EXjkkB7ZGHiUROoxO/adSSOVQ EPdAymMh0bgA3s0q/5Gj7eqf/kby/SrINUTUwWE7hs4avz+4JTko1aGxDExjjf+lwLuo Bwsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=hStNeExndAJKlr2+D1oBe+je+9Di+B0AKJsmhmeHTHQ=; b=PeqL1VZ19zr3g+nHqoy3kfAJ5g3oknsIoIIgJM2tmpKR2u22VQGCN8EYshQsax1yrY Ep7Og4SOnDeQVuzffLJzvxhofAad5+L9nS2CUlHbdYJ3f0nrn5UzesDpB3VUKPNDp9VB gX5i+RsrURhgmRdAwRGwoh0k8UuCd1M5mj8sRi5UPH4AnTBBekV8Fu3HVjzoFr4WNYHN WZ4uvjcdZ1TQ/HnwfCWk4W6cEoQ+ZN2vTG0OgBGRUpg1adq5IXT00t6YGRfk9JZQkwmL 4j4Y5gHB1TiwRoBqURG0pkqHvl2v1SIxvBgU00a5cZtCo70p2WX7NTQNCOL76UDJAv5C PwMA== X-Gm-Message-State: AOAM533wZtFIPcUFEuLGq5s5rlE4uaBnMLiE5fYwdY2/QckC1qlUKOUT kSbTr7g8Zc2NCYnuJ+3EFPITRbRhBzVzqc1e X-Google-Smtp-Source: ABdhPJzhrbsLUQYWmMLMpZ5iObfaCDIXTZ3flWw2olgqdOuaNg4kbgxCwgzzFk8AtkZqvNIeEdQSAg== X-Received: by 2002:a05:6000:1847:: with SMTP id c7mr18646898wri.368.1623676092087; Mon, 14 Jun 2021 06:08:12 -0700 (PDT) Received: from ?IPv6:2a01:e0a:90c:e290:f0d4:3c02:f06a:77bb? ([2a01:e0a:90c:e290:f0d4:3c02:f06a:77bb]) by smtp.gmail.com with ESMTPSA id r7sm25083457wma.9.2021.06.14.06.08.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jun 2021 06:08:11 -0700 (PDT) Subject: Re: [PATCH v2 1/2] spi: meson-spicc: fix memory leak in meson_spicc_probe To: zpershuai , Mark Brown , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <1623562156-21995-1-git-send-email-zpershuai@gmail.com> From: Neil Armstrong Organization: Baylibre Message-ID: <8317e3b1-120a-eb55-95bc-7cb3cd1777c5@baylibre.com> Date: Mon, 14 Jun 2021 15:08:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1623562156-21995-1-git-send-email-zpershuai@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 13/06/2021 07:29, zpershuai wrote: > when meson_spicc_clk_init returns failed, it should goto the > out_clk label. > > Signed-off-by: zpershuai > --- > drivers/spi/spi-meson-spicc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c > index ecba6b4..d675334 100644 > --- a/drivers/spi/spi-meson-spicc.c > +++ b/drivers/spi/spi-meson-spicc.c > @@ -752,7 +752,7 @@ static int meson_spicc_probe(struct platform_device *pdev) > ret = meson_spicc_clk_init(spicc); > if (ret) { > dev_err(&pdev->dev, "clock registration failed\n"); > - goto out_master; > + goto out_clk; > } > > ret = devm_spi_register_master(&pdev->dev, master); > Reviewed-by: Neil Armstrong