From: Andrew Lunn <andrew@lunn.ch>
To: Yajun Deng <yajun.deng@linux.dev>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: phy: Synchronize c45_ids to phy_id
Date: Thu, 22 May 2025 15:39:04 +0200 [thread overview]
Message-ID: <831a5923-5946-457e-8ff6-e92c8a0818fd@lunn.ch> (raw)
In-Reply-To: <20250522131918.31454-1-yajun.deng@linux.dev>
On Thu, May 22, 2025 at 09:19:18PM +0800, Yajun Deng wrote:
> The phy_id_show() function emit the phy_id for the phy device. If the phy
> device is a c45 device, the phy_id is empty. In other words, phy_id_show()
> only works with the c22 device.
>
> Synchronize c45_ids to phy_id, phy_id_show() will work with both the c22
> and c45 devices.
First off, they are different things. A device can have both a C22 and
a collection of C45 IDs. So they should not be mixed up in one sysfs
attribute.
The second point has already been made by Russell, there are lots of
different C45 IDs, and phylib will try to find a driver based on any
of them.
If you want to export the C45 IDs, please think about adding new sysfs
attributes.
Andrew
next prev parent reply other threads:[~2025-05-22 13:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 13:19 Yajun Deng
2025-05-22 13:26 ` Russell King (Oracle)
2025-05-22 13:39 ` Andrew Lunn [this message]
2025-05-23 2:10 ` Yajun Deng
2025-05-23 13:03 ` Andrew Lunn
2025-05-23 17:39 ` Russell King (Oracle)
2025-05-23 17:37 ` Russell King (Oracle)
2025-05-24 1:36 ` Yajun Deng
2025-05-28 6:35 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831a5923-5946-457e-8ff6-e92c8a0818fd@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®